From patchwork Tue Feb 3 01:09:05 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Klimov X-Patchwork-Id: 5168 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n1318LcW031257 for ; Tue, 3 Feb 2009 01:09:13 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754525AbZBCBJM (ORCPT ); Mon, 2 Feb 2009 20:09:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754573AbZBCBJL (ORCPT ); Mon, 2 Feb 2009 20:09:11 -0500 Received: from fg-out-1718.google.com ([72.14.220.157]:44655 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754238AbZBCBJK (ORCPT ); Mon, 2 Feb 2009 20:09:10 -0500 Received: by fg-out-1718.google.com with SMTP id 16so763430fgg.17 for ; Mon, 02 Feb 2009 17:09:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc :content-type:date:message-id:mime-version:x-mailer :content-transfer-encoding; bh=jUL7VHn7dlUST/3ss7S5tqD2bMyjuOJO9MCkn9tj/LQ=; b=k735jhQKumIW9yObugf5ImrA1AldOCue94oWrOlWTjwqv1a4+X0gDY/25fqomMtZSd NbyazWrpS61n0gX8fDDBs3HI9PMahKz1zbd3NhZhZMOA9Xs0nS8qv6zjfL9dMKPa7cE6 W9i30S8snpIz2GcoRX/64MxBNC+Cr6YhrBdmQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=TFxPZuuy+Wg5AD373b3GgvtMJZmoCjF97AzcriIZPKXGJuBicyuLPwPtXJ9qcNTqmP QrrjB/kBjkAGKcnLMFcVCz8qaQi3Z6BioMhE5Mb3bDWctiQi4Av7fElXmzH8rIshqERO LSCv+8W/pNm6/pcoYgNTtFxhVQTJsfHk9lHzw= Received: by 10.86.94.11 with SMTP id r11mr865792fgb.11.1233623349404; Mon, 02 Feb 2009 17:09:09 -0800 (PST) Received: from ?192.168.1.42? (gw.zunet.ru [217.67.117.64]) by mx.google.com with ESMTPS id d6sm411599fga.39.2009.02.02.17.09.08 (version=SSLv3 cipher=RC4-MD5); Mon, 02 Feb 2009 17:09:09 -0800 (PST) Subject: [patch review 8/8] radio-mr800: increase version and add comments From: Alexey Klimov To: Douglas Schilling Landgraf Cc: linux-media@vger.kernel.org, David Ellingsworth Date: Tue, 03 Feb 2009 04:09:05 +0300 Message-Id: <1233623345.17456.264.camel@tux.localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.24.2 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Increase driver version to 0.10, remove old and add new useful comments. Signed-off-by: Alexey Klimov diff -r e7bb8f79fc4e linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Mon Feb 02 21:08:27 2009 +0300 +++ b/linux/drivers/media/radio/radio-mr800.c Tue Feb 03 02:52:09 2009 +0300 @@ -22,7 +22,7 @@ */ /* - * Big thanks to authors of dsbr100.c and radio-si470x.c + * Big thanks to authors and contributors of dsbr100.c and radio-si470x.c * * When work was looked pretty good, i discover this: * http://av-usbradio.sourceforge.net/index.php @@ -30,18 +30,23 @@ * Latest release of theirs project was in 2005. * Probably, this driver could be improved trough using their * achievements (specifications given). - * So, we have smth to begin with. + * Also, Faidon Liambotis wrote nice driver for this radio + * in 2007. He allowed to use his driver to improve current mr800 radio driver. + * http://kerneltrap.org/mailarchive/linux-usb-devel/2007/10/11/342492 * - * History: * Version 0.01: First working version. * It's required to blacklist AverMedia USB Radio * in usbhid/hid-quirks.c + * Version 0.10: A lot of cleanups and fixes: unpluging the device, + * few mutex locks were added, codinstyle issues, etc. + * Added stereo support. Thanks to + * Douglas Schilling Landgraf and + * David Ellingsworth + * for discussion, help and support. * * Many things to do: * - Correct power managment of device (suspend & resume) - * - Make x86 independance (little-endian and big-endian stuff) * - Add code for scanning and smooth tuning - * - Checked and add stereo&mono stuff * - Add code for sensitivity value * - Correct mistakes * - In Japan another FREQ_MIN and FREQ_MAX @@ -63,8 +68,8 @@ /* driver and module definitions */ #define DRIVER_AUTHOR "Alexey Klimov " #define DRIVER_DESC "AverMedia MR 800 USB FM radio driver" -#define DRIVER_VERSION "0.01" -#define RADIO_VERSION KERNEL_VERSION(0, 0, 1) +#define DRIVER_VERSION "0.10" +#define RADIO_VERSION KERNEL_VERSION(0, 1, 0) MODULE_AUTHOR(DRIVER_AUTHOR); MODULE_DESCRIPTION(DRIVER_DESC); @@ -312,14 +317,11 @@ return retval; } - - -/* USB subsystem interface begins here */ - -/* handle unplugging of the device, release data structures -if nothing keeps us from doing it. If something is still -keeping us busy, the release callback of v4l will take care -of releasing it. */ +/* Handle unplugging the device. + * We call video_unregister_device in any case. + * The last function called in this procedure is + * usb_amradio_device_release. + */ static void usb_amradio_disconnect(struct usb_interface *intf) { struct amradio_device *radio = usb_get_intfdata(intf);