From patchwork Tue Mar 24 21:12:47 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stoyan Gaydarov X-Patchwork-Id: 14101 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n2OLF8Xq032448 for ; Tue, 24 Mar 2009 21:15:08 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753274AbZCXVN3 (ORCPT ); Tue, 24 Mar 2009 17:13:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753228AbZCXVN2 (ORCPT ); Tue, 24 Mar 2009 17:13:28 -0400 Received: from mail-qy0-f118.google.com ([209.85.221.118]:37968 "EHLO mail-qy0-f118.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753040AbZCXVN0 (ORCPT ); Tue, 24 Mar 2009 17:13:26 -0400 Received: by mail-qy0-f118.google.com with SMTP id 16so3694397qyk.33 for ; Tue, 24 Mar 2009 14:13:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=7sMkWCKdgS9Ev/YzNygPC2HWD2qQt1/rgU32jAuJVac=; b=KmREJTXhzxEdIWczRgUtwz+ob9+2zGtocACx0lGGJr2vOIhegnu2cTzfTkbtYkR2io Tz/4980BXrQtUJTpCqF8FZCjZCs63SPZNL36k3+SvOgLLsi+fuRGjTKE75l8zG3NidfT f0f8sNKv1biOQihIoUhjL3P7ZscwSZshFRZv4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=Z0kQRTrBibQXIfBAG1+mc5V1VS2UvKbCPkimOwcqhma0bN6ckHqUCLQNt6Dol7GTuO 1R7OJNinxLsyCtuYOWoEn6hJzjT8DjLSR8FEjZqY7lDgxOEuDuwLq2IDehcUZMMkyih7 aMyvVJecxuaouHHATvyNTU8zEC2iy5dYGuz68= Received: by 10.142.157.6 with SMTP id f6mr3548046wfe.257.1237929204034; Tue, 24 Mar 2009 14:13:24 -0700 (PDT) Received: from localhost.localdomain (c-24-13-204-240.hsd1.il.comcast.net [24.13.204.240]) by mx.google.com with ESMTPS id 28sm14187165wfg.51.2009.03.24.14.13.22 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 24 Mar 2009 14:13:23 -0700 (PDT) From: stoyboyker@gmail.com To: linux-kernel@vger.kernel.org Cc: Stoyan Gaydarov , linux-media@vger.kernel.org Subject: [PATCH 12/13] [drivers/media] changed ioctls to unlocked Date: Tue, 24 Mar 2009 16:12:47 -0500 Message-Id: <1237929168-15341-13-git-send-email-stoyboyker@gmail.com> X-Mailer: git-send-email 1.6.2.1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Stoyan Gaydarov Signed-off-by: Stoyan Gaydarov --- drivers/media/dvb/bt8xx/dst_ca.c | 7 +++++-- drivers/media/video/dabusb.c | 11 ++++++++--- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/media/dvb/bt8xx/dst_ca.c b/drivers/media/dvb/bt8xx/dst_ca.c index 0258451..d3487c5 100644 --- a/drivers/media/dvb/bt8xx/dst_ca.c +++ b/drivers/media/dvb/bt8xx/dst_ca.c @@ -552,8 +552,10 @@ free_mem_and_exit: return result; } -static int dst_ca_ioctl(struct inode *inode, struct file *file, unsigned int cmd, unsigned long ioctl_arg) +static long dst_ca_ioctl(struct file *file, unsigned int cmd, unsigned long ioctl_arg) { + lock_kernel(); + struct dvb_device* dvbdev = (struct dvb_device*) file->private_data; struct dst_state* state = (struct dst_state*) dvbdev->priv; struct ca_slot_info *p_ca_slot_info; @@ -647,6 +649,7 @@ static int dst_ca_ioctl(struct inode *inode, struct file *file, unsigned int cmd kfree (p_ca_slot_info); kfree (p_ca_caps); + unlock_kernel(); return result; } @@ -684,7 +687,7 @@ static ssize_t dst_ca_write(struct file *file, const char __user *buffer, size_t static struct file_operations dst_ca_fops = { .owner = THIS_MODULE, - .ioctl = dst_ca_ioctl, + .unlocked_ioctl = dst_ca_ioctl, .open = dst_ca_open, .release = dst_ca_release, .read = dst_ca_read, diff --git a/drivers/media/video/dabusb.c b/drivers/media/video/dabusb.c index 298810d..ae4cd79 100644 --- a/drivers/media/video/dabusb.c +++ b/drivers/media/video/dabusb.c @@ -657,8 +657,9 @@ static int dabusb_release (struct inode *inode, struct file *file) return 0; } -static int dabusb_ioctl (struct inode *inode, struct file *file, unsigned int cmd, unsigned long arg) +static long dabusb_ioctl (struct file *file, unsigned int cmd, unsigned long arg) { + lock_kernel(); pdabusb_t s = (pdabusb_t) file->private_data; pbulk_transfer_t pbulk; int ret = 0; @@ -666,13 +667,16 @@ static int dabusb_ioctl (struct inode *inode, struct file *file, unsigned int cm dbg("dabusb_ioctl"); - if (s->remove_pending) + if (s->remove_pending) { + unlock_kernel(); return -EIO; + } mutex_lock(&s->mutex); if (!s->usbdev) { mutex_unlock(&s->mutex); + unlock_kernel(); return -EIO; } @@ -713,6 +717,7 @@ static int dabusb_ioctl (struct inode *inode, struct file *file, unsigned int cm break; } mutex_unlock(&s->mutex); + unlock_kernel(); return ret; } @@ -721,7 +726,7 @@ static const struct file_operations dabusb_fops = .owner = THIS_MODULE, .llseek = no_llseek, .read = dabusb_read, - .ioctl = dabusb_ioctl, + .unlocked_ioctl = dabusb_ioctl, .open = dabusb_open, .release = dabusb_release, };