From patchwork Fri Mar 27 16:08:22 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Klimov X-Patchwork-Id: 14757 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n2RG7d4X018206 for ; Fri, 27 Mar 2009 16:07:39 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753161AbZC0QHH (ORCPT ); Fri, 27 Mar 2009 12:07:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754927AbZC0QHG (ORCPT ); Fri, 27 Mar 2009 12:07:06 -0400 Received: from mail-fx0-f158.google.com ([209.85.220.158]:35516 "EHLO mail-fx0-f158.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753161AbZC0QHF (ORCPT ); Fri, 27 Mar 2009 12:07:05 -0400 Received: by fxm2 with SMTP id 2so1090902fxm.37 for ; Fri, 27 Mar 2009 09:07:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc :content-type:date:message-id:mime-version:x-mailer :content-transfer-encoding; bh=pglYxfTugaYkvQtlvH4P9J+1nx6PYOkqIMYny7iuxA0=; b=tQl0EHRvXoCVEC8MH464mK0hAmlpv9I2EhvCrPZrX32OMewqrrM4kwpTMbwZshgJmH NXmQbJ8904g2WgGVJlsJIVz60EmBu9FZCE38E8PYX/37uBAtT2GCblxNg9YDBBukhIjm MHAV/mmHX3qvrqlncntEFHDHUdWzTItMfK0Xo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=Riew13rRx74OBSGIq9ed1WrnIK2rPIwLOsMdqki2cCre73cfr3owfHwhuxhUICBH/J IjvBU4fmmZaianWZlEj/1z5W7xcYOc+iiBU9irFpAtixqPrwbbkFVzWJSTpxP7tD1MFt q3c3SQl3PxYzWW4uuNGe+5VGZR4ZJufthz0dw= Received: by 10.103.8.17 with SMTP id l17mr506132mui.125.1238170022572; Fri, 27 Mar 2009 09:07:02 -0700 (PDT) Received: from ?192.168.56.42? (radio.mipt.ru [194.85.80.56]) by mx.google.com with ESMTPS id i5sm3512159mue.43.2009.03.27.09.07.01 (version=SSLv3 cipher=RC4-MD5); Fri, 27 Mar 2009 09:07:02 -0700 (PDT) Subject: [patch review] gspca - mr97310a: return error instead of -1 in sd_mod_init From: Alexey Klimov To: Jean-Francois Moine Cc: linux-media@vger.kernel.org Date: Fri, 27 Mar 2009 19:08:22 +0300 Message-Id: <1238170102.3791.8.camel@tux.localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.24.4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hello, Jean-Francois What do you think about such small cleanup ? --- Patch reformats sd_mod_init in the way to make it return error code from usb_register instead of -1. Signed-off-by: Alexey Klimov -- diff -r 56cf0f1772f7 linux/drivers/media/video/gspca/mr97310a.c --- a/linux/drivers/media/video/gspca/mr97310a.c Mon Mar 23 19:18:34 2009 -0300 +++ b/linux/drivers/media/video/gspca/mr97310a.c Fri Mar 27 01:42:28 2009 +0300 @@ -347,8 +347,10 @@ /* -- module insert / remove -- */ static int __init sd_mod_init(void) { - if (usb_register(&sd_driver) < 0) - return -1; + int ret; + ret = usb_register(&sd_driver); + if (ret < 0) + return ret; PDEBUG(D_PROBE, "registered"); return 0; }