From patchwork Sun Mar 29 23:19:54 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Klimov X-Patchwork-Id: 15062 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n2TNJo7l032728 for ; Sun, 29 Mar 2009 23:20:02 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751293AbZC2XUB (ORCPT ); Sun, 29 Mar 2009 19:20:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751390AbZC2XUB (ORCPT ); Sun, 29 Mar 2009 19:20:01 -0400 Received: from mu-out-0910.google.com ([209.85.134.190]:24990 "EHLO mu-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751293AbZC2XUA (ORCPT ); Sun, 29 Mar 2009 19:20:00 -0400 Received: by mu-out-0910.google.com with SMTP id g7so749504muf.1 for ; Sun, 29 Mar 2009 16:19:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc :content-type:date:message-id:mime-version:x-mailer :content-transfer-encoding; bh=wnsQAnRQJV0v6Myb4RQ8uhivNHpphKCxPjuO73alT0Q=; b=AA6tcD4stE3KFaP3CSe4UBDTzZvE4X1UyFquhCFQ0urrNuO9KhbHf1gQdiR8BGiS7B zThf7/F3qXO0/W0Lui8RRk1RZyfMNlwALLdFiMMVLk5aqr+7fDJTb1qZ6MJ6l8l3LPfI Clhl1wlbkhh/Ev12Zwpw8rwqigKp8r5adcnPg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=pWb15mqwK783NqlTkT19ZgWZLxWIHdSdqtqmV0Pz0vlSNtH+BzYeEq87amj8zsQlze HC2cISJTMPMKolZnHnBFM58XT8QCW7aKw7RRjQmqNj25vR/CfqCzVx0wFmEL6X3ygXgE Z5mHysrUXRzbcjmrVeMrYg4eoxEnjVQDrPn0o= Received: by 10.103.173.15 with SMTP id a15mr1403379mup.59.1238368797490; Sun, 29 Mar 2009 16:19:57 -0700 (PDT) Received: from ?192.168.1.42? (gw.zunet.ru [217.67.117.64]) by mx.google.com with ESMTPS id e8sm7777409muf.48.2009.03.29.16.19.56 (version=SSLv3 cipher=RC4-MD5); Sun, 29 Mar 2009 16:19:57 -0700 (PDT) Subject: [patch 2/2 review] pci-isa radios: remove open and release functions From: Alexey Klimov To: Mauro Carvalho Chehab , Hans Verkuil Cc: Douglas Schilling Landgraf , linux-media@vger.kernel.org Date: Mon, 30 Mar 2009 03:19:54 +0400 Message-Id: <1238368794.21620.36.camel@tux.localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.24.4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Alexey Klimov Patch removes empty open and release functions in pci and isa radio drivers, setting them to NULL. V4L module doesn't call for them due to previous patch. Priority: normal Signed-off-by: Alexey Klimov diff -r a38076781c9a linux/drivers/media/radio/radio-aimslab.c --- a/linux/drivers/media/radio/radio-aimslab.c Mon Mar 30 01:14:44 2009 +0400 +++ b/linux/drivers/media/radio/radio-aimslab.c Mon Mar 30 02:05:12 2009 +0400 @@ -356,20 +356,8 @@ return a->index ? -EINVAL : 0; } -static int rtrack_open(struct file *file) -{ - return 0; -} - -static int rtrack_release(struct file *file) -{ - return 0; -} - static const struct v4l2_file_operations rtrack_fops = { .owner = THIS_MODULE, - .open = rtrack_open, - .release = rtrack_release, .ioctl = video_ioctl2, }; diff -r a38076781c9a linux/drivers/media/radio/radio-aztech.c --- a/linux/drivers/media/radio/radio-aztech.c Mon Mar 30 01:14:44 2009 +0400 +++ b/linux/drivers/media/radio/radio-aztech.c Mon Mar 30 02:05:12 2009 +0400 @@ -319,20 +319,8 @@ return -EINVAL; } -static int aztech_open(struct file *file) -{ - return 0; -} - -static int aztech_release(struct file *file) -{ - return 0; -} - static const struct v4l2_file_operations aztech_fops = { .owner = THIS_MODULE, - .open = aztech_open, - .release = aztech_release, .ioctl = video_ioctl2, }; diff -r a38076781c9a linux/drivers/media/radio/radio-gemtek-pci.c --- a/linux/drivers/media/radio/radio-gemtek-pci.c Mon Mar 30 01:14:44 2009 +0400 +++ b/linux/drivers/media/radio/radio-gemtek-pci.c Mon Mar 30 02:05:12 2009 +0400 @@ -357,20 +357,8 @@ MODULE_DEVICE_TABLE(pci, gemtek_pci_id); -static int gemtek_pci_open(struct file *file) -{ - return 0; -} - -static int gemtek_pci_release(struct file *file) -{ - return 0; -} - static const struct v4l2_file_operations gemtek_pci_fops = { .owner = THIS_MODULE, - .open = gemtek_pci_open, - .release = gemtek_pci_release, .ioctl = video_ioctl2, }; diff -r a38076781c9a linux/drivers/media/radio/radio-gemtek.c --- a/linux/drivers/media/radio/radio-gemtek.c Mon Mar 30 01:14:44 2009 +0400 +++ b/linux/drivers/media/radio/radio-gemtek.c Mon Mar 30 02:05:12 2009 +0400 @@ -376,20 +376,9 @@ /* * Video 4 Linux stuff. */ -static int gemtek_open(struct file *file) -{ - return 0; -} - -static int gemtek_release(struct file *file) -{ - return 0; -} static const struct v4l2_file_operations gemtek_fops = { .owner = THIS_MODULE, - .open = gemtek_open, - .release = gemtek_release, .ioctl = video_ioctl2, }; diff -r a38076781c9a linux/drivers/media/radio/radio-maestro.c --- a/linux/drivers/media/radio/radio-maestro.c Mon Mar 30 01:14:44 2009 +0400 +++ b/linux/drivers/media/radio/radio-maestro.c Mon Mar 30 02:05:12 2009 +0400 @@ -293,20 +293,8 @@ return a->index ? -EINVAL : 0; } -static int maestro_open(struct file *file) -{ - return 0; -} - -static int maestro_release(struct file *file) -{ - return 0; -} - static const struct v4l2_file_operations maestro_fops = { .owner = THIS_MODULE, - .open = maestro_open, - .release = maestro_release, .ioctl = video_ioctl2, }; diff -r a38076781c9a linux/drivers/media/radio/radio-maxiradio.c --- a/linux/drivers/media/radio/radio-maxiradio.c Mon Mar 30 01:14:44 2009 +0400 +++ b/linux/drivers/media/radio/radio-maxiradio.c Mon Mar 30 02:05:12 2009 +0400 @@ -340,20 +340,8 @@ return -EINVAL; } -static int maxiradio_open(struct file *file) -{ - return 0; -} - -static int maxiradio_release(struct file *file) -{ - return 0; -} - static const struct v4l2_file_operations maxiradio_fops = { .owner = THIS_MODULE, - .open = maxiradio_open, - .release = maxiradio_release, .ioctl = video_ioctl2, }; diff -r a38076781c9a linux/drivers/media/radio/radio-rtrack2.c --- a/linux/drivers/media/radio/radio-rtrack2.c Mon Mar 30 01:14:44 2009 +0400 +++ b/linux/drivers/media/radio/radio-rtrack2.c Mon Mar 30 02:05:12 2009 +0400 @@ -261,20 +261,8 @@ return a->index ? -EINVAL : 0; } -static int rtrack2_open(struct file *file) -{ - return 0; -} - -static int rtrack2_release(struct file *file) -{ - return 0; -} - static const struct v4l2_file_operations rtrack2_fops = { .owner = THIS_MODULE, - .open = rtrack2_open, - .release = rtrack2_release, .ioctl = video_ioctl2, }; diff -r a38076781c9a linux/drivers/media/radio/radio-sf16fmi.c --- a/linux/drivers/media/radio/radio-sf16fmi.c Mon Mar 30 01:14:44 2009 +0400 +++ b/linux/drivers/media/radio/radio-sf16fmi.c Mon Mar 30 02:05:12 2009 +0400 @@ -261,20 +261,8 @@ return a->index ? -EINVAL : 0; } -static int fmi_open(struct file *file) -{ - return 0; -} - -static int fmi_release(struct file *file) -{ - return 0; -} - static const struct v4l2_file_operations fmi_fops = { .owner = THIS_MODULE, - .open = fmi_open, - .release = fmi_release, .ioctl = video_ioctl2, }; diff -r a38076781c9a linux/drivers/media/radio/radio-sf16fmr2.c --- a/linux/drivers/media/radio/radio-sf16fmr2.c Mon Mar 30 01:14:44 2009 +0400 +++ b/linux/drivers/media/radio/radio-sf16fmr2.c Mon Mar 30 02:05:12 2009 +0400 @@ -378,20 +378,8 @@ return a->index ? -EINVAL : 0; } -static int fmr2_open(struct file *file) -{ - return 0; -} - -static int fmr2_release(struct file *file) -{ - return 0; -} - static const struct v4l2_file_operations fmr2_fops = { .owner = THIS_MODULE, - .open = fmr2_open, - .release = fmr2_release, .ioctl = video_ioctl2, }; diff -r a38076781c9a linux/drivers/media/radio/radio-terratec.c --- a/linux/drivers/media/radio/radio-terratec.c Mon Mar 30 01:14:44 2009 +0400 +++ b/linux/drivers/media/radio/radio-terratec.c Mon Mar 30 02:05:12 2009 +0400 @@ -333,20 +333,8 @@ return a->index ? -EINVAL : 0; } -static int terratec_open(struct file *file) -{ - return 0; -} - -static int terratec_release(struct file *file) -{ - return 0; -} - static const struct v4l2_file_operations terratec_fops = { .owner = THIS_MODULE, - .open = terratec_open, - .release = terratec_release, .ioctl = video_ioctl2, }; diff -r a38076781c9a linux/drivers/media/radio/radio-trust.c --- a/linux/drivers/media/radio/radio-trust.c Mon Mar 30 01:14:44 2009 +0400 +++ b/linux/drivers/media/radio/radio-trust.c Mon Mar 30 02:05:12 2009 +0400 @@ -339,20 +339,8 @@ return a->index ? -EINVAL : 0; } -static int trust_open(struct file *file) -{ - return 0; -} - -static int trust_release(struct file *file) -{ - return 0; -} - static const struct v4l2_file_operations trust_fops = { .owner = THIS_MODULE, - .open = trust_open, - .release = trust_release, .ioctl = video_ioctl2, }; diff -r a38076781c9a linux/drivers/media/radio/radio-typhoon.c --- a/linux/drivers/media/radio/radio-typhoon.c Mon Mar 30 01:14:44 2009 +0400 +++ b/linux/drivers/media/radio/radio-typhoon.c Mon Mar 30 02:05:12 2009 +0400 @@ -315,20 +315,8 @@ return 0; } -static int typhoon_open(struct file *file) -{ - return 0; -} - -static int typhoon_release(struct file *file) -{ - return 0; -} - static const struct v4l2_file_operations typhoon_fops = { .owner = THIS_MODULE, - .open = typhoon_open, - .release = typhoon_release, .ioctl = video_ioctl2, }; diff -r a38076781c9a linux/drivers/media/radio/radio-zoltrix.c --- a/linux/drivers/media/radio/radio-zoltrix.c Mon Mar 30 01:14:44 2009 +0400 +++ b/linux/drivers/media/radio/radio-zoltrix.c Mon Mar 30 02:05:12 2009 +0400 @@ -371,21 +371,9 @@ return a->index ? -EINVAL : 0; } -static int zoltrix_open(struct file *file) -{ - return 0; -} - -static int zoltrix_release(struct file *file) -{ - return 0; -} - static const struct v4l2_file_operations zoltrix_fops = { .owner = THIS_MODULE, - .open = zoltrix_open, - .release = zoltrix_release, .ioctl = video_ioctl2, };