From patchwork Mon Apr 20 14:27:27 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: hermann pitton X-Patchwork-Id: 19019 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n3KETLCs029477 for ; Mon, 20 Apr 2009 14:29:21 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755797AbZDTO3S (ORCPT ); Mon, 20 Apr 2009 10:29:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756041AbZDTO3S (ORCPT ); Mon, 20 Apr 2009 10:29:18 -0400 Received: from mail-in-10.arcor-online.net ([151.189.21.50]:35610 "EHLO mail-in-10.arcor-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755797AbZDTO3R (ORCPT ); Mon, 20 Apr 2009 10:29:17 -0400 Received: from mail-in-03-z2.arcor-online.net (mail-in-03-z2.arcor-online.net [151.189.8.15]) by mx.arcor.de (Postfix) with ESMTP id C7D0B28EE59; Mon, 20 Apr 2009 16:29:15 +0200 (CEST) Received: from mail-in-06.arcor-online.net (mail-in-06.arcor-online.net [151.189.21.46]) by mail-in-03-z2.arcor-online.net (Postfix) with ESMTP id AAB1F2D3770; Mon, 20 Apr 2009 16:29:15 +0200 (CEST) Received: from [192.168.178.20] (pD9E11A12.dip0.t-ipconnect.de [217.225.26.18]) (Authenticated sender: hermann-pitton@arcor.de) by mail-in-06.arcor-online.net (Postfix) with ESMTPSA id 5925D39A7B8; Mon, 20 Apr 2009 16:29:13 +0200 (CEST) X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-06.arcor-online.net 5925D39A7B8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arcor.de; s=mail-in; t=1240237753; bh=y1fuoEU9QCIM+yB0m7iV/7Lu9VTW++duXimGNLE41Cs=; h=Subject:From:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id:Mime-Version; b=f81Y7dZ9VtFqEax+RCaacI7I1jQCdE1DFl4AxXvOozcNU6RiPZfJ0/hpOU7QQQvdx 4itTOLZi5rN4fVD94wITErhE+oetbEsYXEOGgAAm6rafIPfVCAltEhQmexvn9npWbH gc7ORov5sqAIqwixSz+qFtdNmfKO0aJMaZQV4oP8= Subject: Re: [PATCH] Enabling of the Winfast TV2000 XP Global TV capture card remote control From: hermann pitton To: Pieter Van Schaik Cc: linux-media@vger.kernel.org In-Reply-To: References: Date: Mon, 20 Apr 2009 16:27:27 +0200 Message-Id: <1240237647.4250.10.camel@pc07.localdom.local> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-5.fc8) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Pieter, Am Montag, den 20.04.2009, 09:47 +0200 schrieb Pieter Van Schaik: > The Winfast TV2000 XP Global video capture card IR remote keys were > not initialized and handled in cx88-input.c; added two corresponding > case statements, where this card's remote works exactly the same as > the DTV1000's. > > Signed-off-by: Pieter C van Schaik > --- > --- linux-2.6.29/drivers/media/video/cx88/cx88-input.c.orig > 2009-04-01 12:38:34.000000000 +0200 > +++ linux-2.6.29/drivers/media/video/cx88/cx88-input.c 2009-04-01 > 12:39:07.000000000 +0200 > @@ -92,6 +92,7 @@ static void cx88_ir_handle_key(struct cx > gpio=(gpio & 0x7fd) + (auxgpio & 0xef); > break; > case CX88_BOARD_WINFAST_DTV1000: > + case CX88_BOARD_WINFAST_TV2000_XP_GLOBAL: > gpio = (gpio & 0x6ff) | ((cx_read(MO_GP1_IO) << 8) & 0x900); > auxgpio = gpio; > break; > @@ -239,6 +240,7 @@ int cx88_ir_init(struct cx88_core *core, > break; > case CX88_BOARD_WINFAST2000XP_EXPERT: > case CX88_BOARD_WINFAST_DTV1000: > + case CX88_BOARD_WINFAST_TV2000_XP_GLOBAL: > ir_codes = ir_codes_winfast; > ir->gpio_addr = MO_GP0_IO; > ir->mask_keycode = 0x8f8; this is at least your third try on it, but it doesn't make it into http://patchwork.kernel.org/project/linux-media/list Broken lines and indentation with spaces instead of tabs for what I get. Also it has an offset of four lines for the second hunk on recent mercurial v4l-dvb. Use "hg diff" to create it on that and don't send patches against 2.6.29. Try README.patches and run at least "make checkpatch" once. This gives an ERROR for wrong indentation and so on. Else try to tweak your mailer or also send as .patch attachment like the one below for testing. Cheers, Hermann diff -r ac3865b16886 linux/drivers/media/video/cx88/cx88-input.c --- a/linux/drivers/media/video/cx88/cx88-input.c Mon Apr 20 08:47:22 2009 -0300 +++ b/linux/drivers/media/video/cx88/cx88-input.c Mon Apr 20 15:25:19 2009 +0200 @@ -92,6 +92,7 @@ gpio=(gpio & 0x7fd) + (auxgpio & 0xef); break; case CX88_BOARD_WINFAST_DTV1000: + case CX88_BOARD_WINFAST_TV2000_XP_GLOBAL: gpio = (gpio & 0x6ff) | ((cx_read(MO_GP1_IO) << 8) & 0x900); auxgpio = gpio; break; @@ -243,6 +244,7 @@ break; case CX88_BOARD_WINFAST2000XP_EXPERT: case CX88_BOARD_WINFAST_DTV1000: + case CX88_BOARD_WINFAST_TV2000_XP_GLOBAL: ir_codes = ir_codes_winfast; ir->gpio_addr = MO_GP0_IO; ir->mask_keycode = 0x8f8;