| Message ID | 1242412579-11355-1-git-send-email-m-karicheri2@ti.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Hi, On Friday 15 May 2009 20:36:19 m-karicheri2@ti.com wrote: > From: Muralidharan Karicheri <a0868495@gt516km11.gt.design.ti.com> > > CCDC hw device header file > > Adds ccdc hw device header for vpfe capture driver > > This has comments incorporated from previous review. > > Reviewed By "Hans Verkuil". > Reviewed By "Laurent Pinchart". > > Signed-off-by: Muralidharan Karicheri <m-karicheri2@ti.com> > --- > Applies to v4l-dvb repository > > include/media/davinci/ccdc_hw_device.h | 109 > ++++++++++++++++++++++++++++++++ 1 files changed, 109 insertions(+), 0 > deletions(-) > create mode 100644 include/media/davinci/ccdc_hw_device.h > > diff --git a/include/media/davinci/ccdc_hw_device.h > b/include/media/davinci/ccdc_hw_device.h new file mode 100644 > index 0000000..71904f3 > --- /dev/null > +++ b/include/media/davinci/ccdc_hw_device.h > @@ -0,0 +1,109 @@ > +/* > + * Copyright (C) 2008-2009 Texas Instruments Inc > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 > USA + * > + * ccdc device API > + */ > +#ifndef _CCDC_HW_DEVICE_H > +#define _CCDC_HW_DEVICE_H > + > +#ifdef __KERNEL__ > +#include <linux/videodev2.h> > +#include <linux/device.h> > +#include <media/davinci/vpfe_types.h> > +#include <media/davinci/ccdc_types.h> > + > +/* > + * ccdc hw operations > + */ > +struct ccdc_hw_ops { > + /* set ccdc base address */ > + void (*set_ccdc_base)(void *base, int size); > + /* set vpss base address */ > + void (*set_vpss_base)(void *base, int size); > + void (*enable) (int en); > + /* Pointer to function to enable or disable ccdc */ > + void (*reset) (void); > + /* reset sbl. only for 6446 */ > + void (*enable_out_to_sdram) (int en); > + /* Pointer to function to set hw frame type */ > + int (*set_hw_if_params) (struct vpfe_hw_if_param *param); > + /* get interface parameters */ > + int (*get_hw_if_params) (struct vpfe_hw_if_param *param); > + /* > + * Pointer to function to set parameters. Used > + * for implementing VPFE_S_CCDC_PARAMS > + */ > + int (*setparams) (void *params); > + /* > + * Pointer to function to get parameter. Used > + * for implementing VPFE_G_CCDC_PARAMS > + */ > + int (*getparams) (void *params); Most other fields use underscores to separate words. Should those be updated ? > + /* Pointer to function to configure ccdc */ > + int (*configure) (void); > + /* enumerate hw pix formats */ > + int (*enum_pix)(enum vpfe_hw_pix_format *hw_pix, int i); > + /* Pointer to function to set buffer type */ > + int (*set_buftype) (enum ccdc_buftype buf_type); > + /* Pointer to function to get buffer type */ > + enum ccdc_buftype (*get_buftype) (void); > + /* Pointer to function to set frame format */ > + int (*set_frame_format) (enum ccdc_frmfmt frm_fmt); > + /* Pointer to function to get frame format */ > + enum ccdc_frmfmt (*get_frame_format) (void); > + /* Pointer to function to set buffer type */ > + enum vpfe_hw_pix_format (*get_pixelformat) (void); > + /* Pointer to function to get pixel format. */ > + int (*set_pixelformat) (enum vpfe_hw_pix_format pixfmt); > + /* Pointer to function to set image window */ > + int (*set_image_window) (struct v4l2_rect *win); > + /* Pointer to function to set image window */ > + void (*get_image_window) (struct v4l2_rect *win); > + /* Pointer to function to get line length */ > + unsigned int (*get_line_length) (void); > + > + /* Query SoC control IDs */ > + int (*queryctrl)(struct v4l2_queryctrl *qctrl); > + /* Set SoC control */ > + int (*setcontrol)(struct v4l2_control *ctrl); > + /* Get SoC control */ > + int (*getcontrol)(struct v4l2_control *ctrl); > + /* Pointer to function to set frame buffer address */ > + void (*setfbaddr) (unsigned long addr); > + /* Pointer to function to get field id */ > + int (*getfid) (void); > +}; > + > +struct ccdc_hw_device { > + /* ccdc device name */ > + char name[30]; Unless there's a specific reason to use 30, make it 32. It won't use any more memory as the next field is 4 bytes aligned anyway. > + /* module owner */ > + struct module *owner; > + /* Pointer to initialize function to initialize ccdc device */ > + int (*open) (struct device *dev); > + /* Pointer to deinitialize function */ > + int (*close) (struct device *dev); Why are the open and close functions outside of ccdc_hw_ops ? > + /* hw ops */ > + struct ccdc_hw_ops hw_ops; > +}; > + > +/* Used by CCDC module to register & unregister with vpfe capture driver > */ +int vpfe_register_ccdc_device(struct ccdc_hw_device *dev); > +void vpfe_unregister_ccdc_device(struct ccdc_hw_device *dev); > + > +#endif > +#endif Best regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/media/davinci/ccdc_hw_device.h b/include/media/davinci/ccdc_hw_device.h new file mode 100644 index 0000000..71904f3 --- /dev/null +++ b/include/media/davinci/ccdc_hw_device.h @@ -0,0 +1,109 @@ +/* + * Copyright (C) 2008-2009 Texas Instruments Inc + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * ccdc device API + */ +#ifndef _CCDC_HW_DEVICE_H +#define _CCDC_HW_DEVICE_H + +#ifdef __KERNEL__ +#include <linux/videodev2.h> +#include <linux/device.h> +#include <media/davinci/vpfe_types.h> +#include <media/davinci/ccdc_types.h> + +/* + * ccdc hw operations + */ +struct ccdc_hw_ops { + /* set ccdc base address */ + void (*set_ccdc_base)(void *base, int size); + /* set vpss base address */ + void (*set_vpss_base)(void *base, int size); + void (*enable) (int en); + /* Pointer to function to enable or disable ccdc */ + void (*reset) (void); + /* reset sbl. only for 6446 */ + void (*enable_out_to_sdram) (int en); + /* Pointer to function to set hw frame type */ + int (*set_hw_if_params) (struct vpfe_hw_if_param *param); + /* get interface parameters */ + int (*get_hw_if_params) (struct vpfe_hw_if_param *param); + /* + * Pointer to function to set parameters. Used + * for implementing VPFE_S_CCDC_PARAMS + */ + int (*setparams) (void *params); + /* + * Pointer to function to get parameter. Used + * for implementing VPFE_G_CCDC_PARAMS + */ + int (*getparams) (void *params); + /* Pointer to function to configure ccdc */ + int (*configure) (void); + /* enumerate hw pix formats */ + int (*enum_pix)(enum vpfe_hw_pix_format *hw_pix, int i); + /* Pointer to function to set buffer type */ + int (*set_buftype) (enum ccdc_buftype buf_type); + /* Pointer to function to get buffer type */ + enum ccdc_buftype (*get_buftype) (void); + /* Pointer to function to set frame format */ + int (*set_frame_format) (enum ccdc_frmfmt frm_fmt); + /* Pointer to function to get frame format */ + enum ccdc_frmfmt (*get_frame_format) (void); + /* Pointer to function to set buffer type */ + enum vpfe_hw_pix_format (*get_pixelformat) (void); + /* Pointer to function to get pixel format. */ + int (*set_pixelformat) (enum vpfe_hw_pix_format pixfmt); + /* Pointer to function to set image window */ + int (*set_image_window) (struct v4l2_rect *win); + /* Pointer to function to set image window */ + void (*get_image_window) (struct v4l2_rect *win); + /* Pointer to function to get line length */ + unsigned int (*get_line_length) (void); + + /* Query SoC control IDs */ + int (*queryctrl)(struct v4l2_queryctrl *qctrl); + /* Set SoC control */ + int (*setcontrol)(struct v4l2_control *ctrl); + /* Get SoC control */ + int (*getcontrol)(struct v4l2_control *ctrl); + /* Pointer to function to set frame buffer address */ + void (*setfbaddr) (unsigned long addr); + /* Pointer to function to get field id */ + int (*getfid) (void); +}; + +struct ccdc_hw_device { + /* ccdc device name */ + char name[30]; + /* module owner */ + struct module *owner; + /* Pointer to initialize function to initialize ccdc device */ + int (*open) (struct device *dev); + /* Pointer to deinitialize function */ + int (*close) (struct device *dev); + /* hw ops */ + struct ccdc_hw_ops hw_ops; +}; + +/* Used by CCDC module to register & unregister with vpfe capture driver */ +int vpfe_register_ccdc_device(struct ccdc_hw_device *dev); +void vpfe_unregister_ccdc_device(struct ccdc_hw_device *dev); + +#endif +#endif