From patchwork Tue Jun 9 10:59:40 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexey Klimov X-Patchwork-Id: 28991 X-Patchwork-Delegate: dougsland@redhat.com Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n59B0BhO024429 for ; Tue, 9 Jun 2009 11:00:12 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759479AbZFIK7Z (ORCPT ); Tue, 9 Jun 2009 06:59:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759369AbZFIK7Z (ORCPT ); Tue, 9 Jun 2009 06:59:25 -0400 Received: from mail-fx0-f213.google.com ([209.85.220.213]:44429 "EHLO mail-fx0-f213.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759559AbZFIK7W (ORCPT ); Tue, 9 Jun 2009 06:59:22 -0400 Received: by fxm9 with SMTP id 9so2867722fxm.37 for ; Tue, 09 Jun 2009 03:59:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc :content-type:date:message-id:mime-version:x-mailer :content-transfer-encoding; bh=DqCoZDzupnreoaHYqFh5M5pzP9mssxwU28v8TyZJRas=; b=URv/xUvBQye82Bh33ttDBrsC/LSYuS0WXZnBLsrHAk3icraDHP/rOsxHOL241j2H2U g54It8/hl/C7Wo9uZg/pnpY7FKZXjKSXjAEuwwhOd4Fsw3Pp5N6bg3Bfii9UxgxAgSHG whg+1ii3zvYX4d4u/UHPeT6JKQOtDR20yFV+M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=atRTRsIry+3YN8zK9TYPbXpHAzxI4TXciE3fr919PKpxLtUAiWneVrNAKhCi/+OszF l2EVymHukwM/Mpg/+BHy2F1PJZXqiHXjCqMdas8nhPUNoChAKyjXso3xwiu7EZE4FXWg 1eMF8Kc30ZWpd1oZXk9f5cChZxePPFfQmVK5E= Received: by 10.103.2.14 with SMTP id e14mr2908225mui.41.1244545163579; Tue, 09 Jun 2009 03:59:23 -0700 (PDT) Received: from ?10.55.86.21? ([93.175.15.0]) by mx.google.com with ESMTPS id y2sm10025992mug.43.2009.06.09.03.59.21 (version=SSLv3 cipher=RC4-MD5); Tue, 09 Jun 2009 03:59:22 -0700 (PDT) Subject: [patch review] gspca - stv06xx: remove needless if check and goto From: Alexey Klimov To: Jean-Francois Moine , Erik =?ISO-8859-1?Q?Andr=E9n?= Cc: linux-media@vger.kernel.org Date: Tue, 09 Jun 2009 14:59:40 +0400 Message-Id: <1244545180.28249.8.camel@tux.localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hello, Jean-Francois and Erik André What do you think about such small change? Looks like the code doesn't need if-check and goto here in stv06xx_stopN function. The code after label "out" does this. Reviewed-by: Erik Andrén --- Patch removes needless if check and goto. Signed-off-by: Alexey Klimov -- diff -r ed3781a79c73 linux/drivers/media/video/gspca/stv06xx/stv06xx.c --- a/linux/drivers/media/video/gspca/stv06xx/stv06xx.c Sat Jun 06 16:31:34 2009 +0400 +++ b/linux/drivers/media/video/gspca/stv06xx/stv06xx.c Tue Jun 09 14:49:04 2009 +0400 @@ -293,8 +293,6 @@ goto out; err = sd->sensor->stop(sd); - if (err < 0) - goto out; out: if (err < 0)