From patchwork Fri Jul 17 22:49:50 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: hermann pitton X-Patchwork-Id: 36136 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n6HMocqW010275 for ; Fri, 17 Jul 2009 22:50:38 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751942AbZGQWug (ORCPT ); Fri, 17 Jul 2009 18:50:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757929AbZGQWug (ORCPT ); Fri, 17 Jul 2009 18:50:36 -0400 Received: from mail-in-04.arcor-online.net ([151.189.21.44]:50344 "EHLO mail-in-04.arcor-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751942AbZGQWuf (ORCPT ); Fri, 17 Jul 2009 18:50:35 -0400 Received: from mail-in-12-z2.arcor-online.net (mail-in-12-z2.arcor-online.net [151.189.8.29]) by mx.arcor.de (Postfix) with ESMTP id BBE6133A752; Sat, 18 Jul 2009 00:50:33 +0200 (CEST) Received: from mail-in-09.arcor-online.net (mail-in-09.arcor-online.net [151.189.21.49]) by mail-in-12-z2.arcor-online.net (Postfix) with ESMTP id 9A2A327945D; Sat, 18 Jul 2009 00:50:33 +0200 (CEST) Received: from [192.168.178.24] (pD9E10C56.dip0.t-ipconnect.de [217.225.12.86]) (Authenticated sender: hermann-pitton@arcor.de) by mail-in-09.arcor-online.net (Postfix) with ESMTPSA id 56FD51AF2F4; Sat, 18 Jul 2009 00:50:33 +0200 (CEST) X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-09.arcor-online.net 56FD51AF2F4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arcor.de; s=mail-in; t=1247871033; bh=/TL8H3vRknztndzbirAPRMk0Cy+XEkSl+9jPaeTgMos=; h=Subject:From:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id:Mime-Version:Content-Transfer-Encoding; b=hoZckjOppuKw0MVvirqbc0phIIVLabWcvzJ/x+IYFNsdcK7scCHLsLuzi+qZJsoHN mrkQAFDgeP6xz9KFe+hjuq6cKyvcMLgpJGF25ZoxY8oDnmQJZudZQ/F6zLrfirHBOF 7TRvyeLyFb+zVdIaHZ2xeIMqCCz4xebsLWCwsZUI= Subject: Re: AVerMedia AVerTV GO 007 FM, no radio sound (with routing enabled) From: hermann pitton To: Mauro Carvalho Chehab Cc: Pham Thanh Nam , Laszlo Kustan , linux-media@vger.kernel.org In-Reply-To: <20090717051956.1b6253c4@pedra.chehab.org> References: <88b49f150907161417r7d487078h3e27b514cf8dd5cf@mail.gmail.com> <1247794346.3921.22.camel@AcerAspire4710> <1247797282.3187.47.camel@pc07.localdom.local> <1247803058.26678.2.camel@AcerAspire4710> <20090717051956.1b6253c4@pedra.chehab.org> Date: Sat, 18 Jul 2009 00:49:50 +0200 Message-Id: <1247870990.4268.31.camel@pc07.localdom.local> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-5.fc8) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi, Am Freitag, den 17.07.2009, 05:19 -0300 schrieb Mauro Carvalho Chehab: > Em Fri, 17 Jul 2009 10:57:38 +0700 > Pham Thanh Nam escreveu: > > > Hi > > So, should we add an option for this card? For example: > > modprobe saa7134 card=57 radioontv > > IMO, we should just apply a patch doing the right thing. > > I couldn't find any explanation for the change. Let's just fix it with a good > explanation and hope that this will work with all AverTV GO 007 FM boards. If > not, someone will complain. > > > > Cheers, > Mauro have looked up some details and agree with Mauro here. First, Avermedia cards on the saa7134 driver are all identified safely by PCI subsystem. No problems and we deal with GO 007 FM tda8275c1 and not the later tda8275ac1. Assaf reported the radio working, _but later_ he reported also that the frequencies are off. I saw the same later too and lots of ghosting radio stations with Asus P7131 Dual until Hartmut added radio IF support for saa7133/35/31e and all tda8290 tuners with the 5.5MHz filter. LINE1 was never changed for radio on the GO 007. Assaf's patch came in with a bunch of patches Nickolay collected that time. http://linuxtv.org/hg/v4l-dvb/rev/291d5d1089eb Then Hartmut added correct basic radio IF support and I guess this did "break" the previous "ghost" radio. http://linuxtv.org/hg/v4l-dvb/rev/b9edd4165113 Else there was only this change unrelated to radio. ---- hg export 5481 # HG changeset patch # User Mauro Carvalho Chehab # Date 1175168859 10800 # Node ID 9f42fb6940eeaa63305b1048811ea25d74c9e806 # Parent bcf83c0130363da08eabac5092013ed6fec1d9eb 4linux: Fix audio input for AverTv Go 007 From: Damian Minkov Fix audio input source for capturing(playing) audio on AverTv Go 007 cards. Signed-off-by: Damian Minkov Signed-off-by: Andrew Morton Signed-off-by: Mauro Carvalho Chehab ------------------ And furthermore it has .gpiomask = 0x00300003 and gpio21 is set high for radio and low for TV. .radio = { .name = name_radio, .amux = LINE1, .gpio = 0x00300001, }, That is why changing the radio amux to TV just works. Cheers, Hermann --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -r bcf83c013036 -r 9f42fb6940ee linux/drivers/media/video/saa7134/saa7134-cards.c --- a/linux/drivers/media/video/saa7134/saa7134-cards.c Thu Mar 29 08:47:04 2007 -0300 +++ b/linux/drivers/media/video/saa7134/saa7134-cards.c Thu Mar 29 08:47:39 2007 -0300 @@ -1544,12 +1544,12 @@ },{ .name = name_comp1, .vmux = 0, - .amux = LINE2, + .amux = LINE1, .gpio = 0x02, },{ .name = name_svideo, .vmux = 6, - .amux = LINE2, + .amux = LINE1, .gpio = 0x02, }}, .radio = {