From patchwork Thu Aug 20 23:49:24 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: hermann pitton X-Patchwork-Id: 43024 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n7KNx2oX027717 for ; Thu, 20 Aug 2009 23:59:03 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754117AbZHTX65 (ORCPT ); Thu, 20 Aug 2009 19:58:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754462AbZHTX65 (ORCPT ); Thu, 20 Aug 2009 19:58:57 -0400 Received: from mail-in-04.arcor-online.net ([151.189.21.44]:49855 "EHLO mail-in-04.arcor-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754117AbZHTX64 (ORCPT ); Thu, 20 Aug 2009 19:58:56 -0400 Received: from mail-in-20-z2.arcor-online.net (mail-in-20-z2.arcor-online.net [151.189.8.85]) by mx.arcor.de (Postfix) with ESMTP id C9B2E33A739 for ; Fri, 21 Aug 2009 01:58:56 +0200 (CEST) Received: from mail-in-17.arcor-online.net (mail-in-17.arcor-online.net [151.189.21.57]) by mail-in-20-z2.arcor-online.net (Postfix) with ESMTP id B5951107D2B for ; Fri, 21 Aug 2009 01:58:56 +0200 (CEST) Received: from [192.168.178.24] (pD9E110E8.dip0.t-ipconnect.de [217.225.16.232]) (Authenticated sender: hermann-pitton@arcor.de) by mail-in-17.arcor-online.net (Postfix) with ESMTPSA id 98C063B269D for ; Fri, 21 Aug 2009 01:58:56 +0200 (CEST) X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-17.arcor-online.net 98C063B269D DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arcor.de; s=mail-in; t=1250812736; bh=43Wdl+iEeA58Dp9qM7FMmJ84PQmZ5S2TKMgM/otOYfU=; h=Subject:From:To:Content-Type:Date:Message-Id:Mime-Version; b=bpUnmGSPavAviTs5oSCOpv9nQQ0I0tvHv9Re3ptx7lag/kpXrFLiAOU7Ji7pDoVSO Ory58+drN4xmbvsZipAXIWbxMeYcR9ZeoT+0lW7Tz1PPtvKN3oPPjZQwiPBiiy9Uou DU8XArv8p0t41mVZ8Z/GI7GGmOpxkGKtRrLVRIQk= Subject: [PATCH] saa7134: start to investigate the LNA mess on 310i and hvr1110 products From: hermann pitton To: linux-media@vger.kernel.org Date: Fri, 21 Aug 2009 01:49:24 +0200 Message-Id: <1250812164.3249.18.camel@pc07.localdom.local> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-5.fc8) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org There is a great maintenance mess for those devices currently. All attempts, to get some further information out of those assumed to be closest to the above manufactures, failed. Against any previous advice, newer products with an additional LNA, which needs to be configured correctly, have been added and we can't make any difference to previous products without LNA. Even more, the type of LNA configuration, either over tuner gain or some on the analog IF demodulator, conflicts within this two devices itself. Since we never had a chance, to see such devices with all details reported to our lists, but might still be able to make eventually a difference, to get out of that mess, we should prefer to start exactly where it started. Signed-off-by: hermann pitton diff -r d0ec20a376fe linux/drivers/media/video/saa7134/saa7134-cards.c --- a/linux/drivers/media/video/saa7134/saa7134-cards.c Thu Aug 20 01:30:58 2009 +0000 +++ b/linux/drivers/media/video/saa7134/saa7134-cards.c Fri Aug 21 01:28:37 2009 +0200 @@ -3242,7 +3242,7 @@ .radio_type = UNSET, .tuner_addr = ADDR_UNSET, .radio_addr = ADDR_UNSET, - .tuner_config = 1, + .tuner_config = 0, .mpeg = SAA7134_MPEG_DVB, .gpiomask = 0x000200000, .inputs = {{ @@ -3346,7 +3346,7 @@ .radio_type = UNSET, .tuner_addr = ADDR_UNSET, .radio_addr = ADDR_UNSET, - .tuner_config = 1, + .tuner_config = 0, .mpeg = SAA7134_MPEG_DVB, .gpiomask = 0x0200100, .inputs = {{ diff -r d0ec20a376fe linux/drivers/media/video/saa7134/saa7134-dvb.c --- a/linux/drivers/media/video/saa7134/saa7134-dvb.c Thu Aug 20 01:30:58 2009 +0000 +++ b/linux/drivers/media/video/saa7134/saa7134-dvb.c Fri Aug 21 01:28:37 2009 +0200 @@ -1144,12 +1144,12 @@ break; case SAA7134_BOARD_PINNACLE_PCTV_310i: if (configure_tda827x_fe(dev, &pinnacle_pctv_310i_config, - &tda827x_cfg_1) < 0) + &tda827x_cfg_0) < 0) goto dettach_frontend; break; case SAA7134_BOARD_HAUPPAUGE_HVR1110: if (configure_tda827x_fe(dev, &hauppauge_hvr_1110_config, - &tda827x_cfg_1) < 0) + &tda827x_cfg_0) < 0) goto dettach_frontend; break; case SAA7134_BOARD_HAUPPAUGE_HVR1150: diff -r d0ec20a376fe linux/drivers/media/video/saa7134/saa7134-cards.c --- a/linux/drivers/media/video/saa7134/saa7134-cards.c Thu Aug 20 01:30:58 2009 +0000 +++ b/linux/drivers/media/video/saa7134/saa7134-cards.c Fri Aug 21 01:28:37 2009 +0200 @@ -3242,7 +3242,7 @@ .radio_type = UNSET, .tuner_addr = ADDR_UNSET, .radio_addr = ADDR_UNSET, - .tuner_config = 1, + .tuner_config = 0, .mpeg = SAA7134_MPEG_DVB, .gpiomask = 0x000200000, .inputs = {{ @@ -3346,7 +3346,7 @@ .radio_type = UNSET, .tuner_addr = ADDR_UNSET, .radio_addr = ADDR_UNSET, - .tuner_config = 1, + .tuner_config = 0, .mpeg = SAA7134_MPEG_DVB, .gpiomask = 0x0200100, .inputs = {{ diff -r d0ec20a376fe linux/drivers/media/video/saa7134/saa7134-dvb.c --- a/linux/drivers/media/video/saa7134/saa7134-dvb.c Thu Aug 20 01:30:58 2009 +0000 +++ b/linux/drivers/media/video/saa7134/saa7134-dvb.c Fri Aug 21 01:28:37 2009 +0200 @@ -1144,12 +1144,12 @@ break; case SAA7134_BOARD_PINNACLE_PCTV_310i: if (configure_tda827x_fe(dev, &pinnacle_pctv_310i_config, - &tda827x_cfg_1) < 0) + &tda827x_cfg_0) < 0) goto dettach_frontend; break; case SAA7134_BOARD_HAUPPAUGE_HVR1110: if (configure_tda827x_fe(dev, &hauppauge_hvr_1110_config, - &tda827x_cfg_1) < 0) + &tda827x_cfg_0) < 0) goto dettach_frontend; break; case SAA7134_BOARD_HAUPPAUGE_HVR1150: