From patchwork Fri Aug 21 02:49:26 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shine Liu X-Patchwork-Id: 43039 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n7L2oiOm011786 for ; Fri, 21 Aug 2009 02:50:45 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751933AbZHUCuk (ORCPT ); Thu, 20 Aug 2009 22:50:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752314AbZHUCuk (ORCPT ); Thu, 20 Aug 2009 22:50:40 -0400 Received: from smtpbg65.qq.com ([119.147.10.224]:58320 "HELO smtpbg65.qq.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751933AbZHUCuk (ORCPT ); Thu, 20 Aug 2009 22:50:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s0907; t=1250822977; bh=qDjl9stWaPW3OdSkYifxxb6JUPY2b7Dd3ym37a/tisY=; h=X-QQ-mid:Received:Subject:From:Reply-To:To:Cc:Content-Type:Date: Message-Id:Mime-Version:X-Mailer:Content-Transfer-Encoding; b=I4Pc/bcdmiOfGRFv2FxonAcwK4EJ8eapStael0TKdeLkof3Wznqr2BgcVXQAl2Szu d/ihSZSzJ2t/ISMY1l9/5BWiVsqLIUI89sg3qcjeWm/yhhpi5OidDAuivnEHZhW X-QQ-mid: esmtp3t1250822977t458t31623 Received: from esmtpproxy (unknown [123.112.76.245]) by esmtp10.qq.com (ESMTP) with id ; Fri, 21 Aug 2009 10:49:35 +0800 (CST) Subject: [PATCH] em28xx: Don't call em28xx_ir_init when disable_ir is true From: Shine Liu Reply-To: shinel@foxmail.com To: linux-media@vger.kernel.org Cc: dheitmueller@kernellabs.com Date: Fri, 21 Aug 2009 10:49:26 +0800 Message-Id: <1250822966.5248.6.camel@shinel> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org I think we should call em28xx_ir_init(dev) when disable_ir is true. Following patch will fix the bug. Cheers, Shine Signed-off-by: Shine Liu ----------------------------------------------------- Reviewed-by: Devin Heitmueller --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/media/video/em28xx/em28xx-cards.c 2009-08-14 06:43:34.000000000 +0800 +++ a/drivers/media/video/em28xx/em28xx-cards.c 2009-08-21 10:39:23.000000000 +0800 @@ -2367,7 +2367,9 @@ } em28xx_tuner_setup(dev); - em28xx_ir_init(dev); + + if(!disable_ir) + em28xx_ir_init(dev); }