mbox series

[GIT,PULL,FOR,v5.16] Add support for DMA2D of STMicroelectronics STM32 Soc series

Message ID 126f13fc-1d37-8bef-3411-4553864fe5be@xs4all.nl (mailing list archive)
State New, archived
Headers show
Series [GIT,PULL,FOR,v5.16] Add support for DMA2D of STMicroelectronics STM32 Soc series | expand

Pull-request

git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.16k

Message

Hans Verkuil Oct. 21, 2021, 2:45 p.m. UTC
The following changes since commit 57c3b9f55ba875a6f6295fa59f0bdc0a01c544f8:

  media: venus: core: Add sdm660 DT compatible and resource struct (2021-10-21 14:26:19 +0100)

are available in the Git repository at:

  git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.16k

for you to fetch changes up to b019395c863f436adb30237b50f22b027bec7351:

  media: stm32-dma2d: STM32 DMA2D driver (2021-10-21 16:14:57 +0200)

----------------------------------------------------------------
Tag branch

----------------------------------------------------------------
Dillon Min (8):
      media: admin-guide: add stm32-dma2d description
      media: dt-bindings: media: add document for STM32 DMA2d bindings
      media: v4l2-mem2mem: add v4l2_m2m_get_unmapped_area for no-mmu platform
      media: videobuf2: Fix the size printk format
      media: v4l2-ctrls: Add V4L2_CID_COLORFX_CBCR max setting
      media: v4l2-ctrls: Add RGB color effects control
      clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after system enter shell
      media: stm32-dma2d: STM32 DMA2D driver

 Documentation/admin-guide/media/platform-cardlist.rst       |   1 +
 Documentation/devicetree/bindings/media/st,stm32-dma2d.yaml |  71 +++++
 Documentation/userspace-api/media/v4l/control.rst           |   9 +
 drivers/clk/clk-stm32f4.c                                   |   4 -
 drivers/media/common/videobuf2/videobuf2-dma-contig.c       |   8 +-
 drivers/media/platform/Kconfig                              |  11 +
 drivers/media/platform/Makefile                             |   1 +
 drivers/media/platform/stm32/Makefile                       |   2 +
 drivers/media/platform/stm32/dma2d/dma2d-hw.c               | 143 ++++++++++
 drivers/media/platform/stm32/dma2d/dma2d-regs.h             | 113 ++++++++
 drivers/media/platform/stm32/dma2d/dma2d.c                  | 739 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/media/platform/stm32/dma2d/dma2d.h                  | 135 ++++++++++
 drivers/media/v4l2-core/v4l2-ctrls-defs.c                   |  12 +-
 drivers/media/v4l2-core/v4l2-mem2mem.c                      |  21 ++
 include/media/v4l2-mem2mem.h                                |   5 +
 include/uapi/linux/v4l2-controls.h                          |   4 +-
 16 files changed, 1268 insertions(+), 11 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/st,stm32-dma2d.yaml
 create mode 100644 drivers/media/platform/stm32/dma2d/dma2d-hw.c
 create mode 100644 drivers/media/platform/stm32/dma2d/dma2d-regs.h
 create mode 100644 drivers/media/platform/stm32/dma2d/dma2d.c
 create mode 100644 drivers/media/platform/stm32/dma2d/dma2d.h

Comments

Hans Verkuil Oct. 21, 2021, 2:57 p.m. UTC | #1
I'll make a new PR for this without the clk patch.

Sorry Dillon, after digging a bit more into the clk series I think that this
should go to the CLK subsystem. I do not feel comfortable merging that patch
via the media subsystem because: 1) from what I can see it is part of a larger
unmerged patch series, and 2) I do not have the expertise to tell if this is
correct or not to just merge this patch.

Regards,

	Hans

On 21/10/2021 16:45, Hans Verkuil wrote:
> The following changes since commit 57c3b9f55ba875a6f6295fa59f0bdc0a01c544f8:
> 
>   media: venus: core: Add sdm660 DT compatible and resource struct (2021-10-21 14:26:19 +0100)
> 
> are available in the Git repository at:
> 
>   git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.16k
> 
> for you to fetch changes up to b019395c863f436adb30237b50f22b027bec7351:
> 
>   media: stm32-dma2d: STM32 DMA2D driver (2021-10-21 16:14:57 +0200)
> 
> ----------------------------------------------------------------
> Tag branch
> 
> ----------------------------------------------------------------
> Dillon Min (8):
>       media: admin-guide: add stm32-dma2d description
>       media: dt-bindings: media: add document for STM32 DMA2d bindings
>       media: v4l2-mem2mem: add v4l2_m2m_get_unmapped_area for no-mmu platform
>       media: videobuf2: Fix the size printk format
>       media: v4l2-ctrls: Add V4L2_CID_COLORFX_CBCR max setting
>       media: v4l2-ctrls: Add RGB color effects control
>       clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after system enter shell
>       media: stm32-dma2d: STM32 DMA2D driver
> 
>  Documentation/admin-guide/media/platform-cardlist.rst       |   1 +
>  Documentation/devicetree/bindings/media/st,stm32-dma2d.yaml |  71 +++++
>  Documentation/userspace-api/media/v4l/control.rst           |   9 +
>  drivers/clk/clk-stm32f4.c                                   |   4 -
>  drivers/media/common/videobuf2/videobuf2-dma-contig.c       |   8 +-
>  drivers/media/platform/Kconfig                              |  11 +
>  drivers/media/platform/Makefile                             |   1 +
>  drivers/media/platform/stm32/Makefile                       |   2 +
>  drivers/media/platform/stm32/dma2d/dma2d-hw.c               | 143 ++++++++++
>  drivers/media/platform/stm32/dma2d/dma2d-regs.h             | 113 ++++++++
>  drivers/media/platform/stm32/dma2d/dma2d.c                  | 739 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/media/platform/stm32/dma2d/dma2d.h                  | 135 ++++++++++
>  drivers/media/v4l2-core/v4l2-ctrls-defs.c                   |  12 +-
>  drivers/media/v4l2-core/v4l2-mem2mem.c                      |  21 ++
>  include/media/v4l2-mem2mem.h                                |   5 +
>  include/uapi/linux/v4l2-controls.h                          |   4 +-
>  16 files changed, 1268 insertions(+), 11 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/media/st,stm32-dma2d.yaml
>  create mode 100644 drivers/media/platform/stm32/dma2d/dma2d-hw.c
>  create mode 100644 drivers/media/platform/stm32/dma2d/dma2d-regs.h
>  create mode 100644 drivers/media/platform/stm32/dma2d/dma2d.c
>  create mode 100644 drivers/media/platform/stm32/dma2d/dma2d.h
>
Jenkins Oct. 21, 2021, 3:29 p.m. UTC | #2
From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/126f13fc-1d37-8bef-3411-4553864fe5be@xs4all.nl/
Build log: https://builder.linuxtv.org/job/patchwork/149931/
Build time: 00:37:00
Link: https://lore.kernel.org/linux-media/126f13fc-1d37-8bef-3411-4553864fe5be@xs4all.nl

gpg: Signature made Thu 21 Oct 2021 02:44:48 PM UTC
gpg:                using RSA key AAA7FFBA4D2D77EF4CAEA1421326E0CD23ABDCE5
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg:                 aka "Hans Verkuil <hverkuil@xs4all.nl>" [unknown]
gpg: Note: This key has expired!
Primary key fingerprint: 052C DE7B C215 053B 689F  1BCA BD2D 6148 6614 3B4C
     Subkey fingerprint: AAA7 FFBA 4D2D 77EF 4CAE  A142 1326 E0CD 23AB DCE5

Summary: got 5/8 patches with issues, being 3 at build time, plus one error when buinding PDF document

Error/warnings:

patches/0001-media-admin-guide-add-stm32-dma2d-description.patch:

    allyesconfig: return code #0:
	../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
	../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
	../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples

    allyesconfig: return code #0:
	../drivers/media/cec/core/cec-adap.c: ../drivers/media/cec/core/cec-adap.c:926 cec_transmit_msg_fh() warn: '&data->list' not removed from list
	../drivers/media/rc/meson-ir-tx.c:22: warning: expecting prototype for meson(). Prototype was for DEVICE_NAME() instead
	../drivers/media/pci/intel/ipu3/cio2-bridge.c:242 cio2_bridge_connect_sensor() warn: missing error code 'ret'
	SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
	SPARSE:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2625 dvb_register() parse error: turning off implications after 60 seconds
	../drivers/media/usb/pvrusb2/pvrusb2-encoder.c: ../drivers/media/usb/pvrusb2/pvrusb2-encoder.c:288 pvr2_encoder_cmd() warn: inconsistent indenting
	../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:1730 pvr2_hdw_set_streaming() warn: inconsistent indenting
	../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3461 pvr2_hdw_cpufw_set_enabled() warn: inconsistent indenting
	../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3501 pvr2_hdw_cpufw_get() warn: inconsistent indenting
	../drivers/media/platform/qcom/venus/helpers.c: ../drivers/media/platform/qcom/venus/helpers.c:658 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 654)
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2894 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

patches/0002-media-dt-bindings-media-add-document-for-STM32-DMA2d.patch:

   checkpatch.pl:
	$ cat patches/0002-media-dt-bindings-media-add-document-for-STM32-DMA2d.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:17: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

patches/0003-media-v4l2-mem2mem-add-v4l2_m2m_get_unmapped_area-fo.patch:

    allyesconfig: return code #0:
	../drivers/media/platform/qcom/venus/helpers.c: ../drivers/media/platform/qcom/venus/helpers.c:658 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 654)

patches/0006-media-v4l2-ctrls-Add-RGB-color-effects-control.patch:

    allyesconfig: return code #0:
	../drivers/media/pci/intel/ipu3/cio2-bridge.c:242 cio2_bridge_connect_sensor() warn: missing error code 'ret'
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2625 dvb_register() parse error: turning off implications after 60 seconds
	../drivers/media/platform/qcom/venus/helpers.c: ../drivers/media/platform/qcom/venus/helpers.c:658 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 654)
	../drivers/media/usb/pvrusb2/pvrusb2-encoder.c: ../drivers/media/usb/pvrusb2/pvrusb2-encoder.c:288 pvr2_encoder_cmd() warn: inconsistent indenting
	../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:1730 pvr2_hdw_set_streaming() warn: inconsistent indenting
	../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3461 pvr2_hdw_cpufw_set_enabled() warn: inconsistent indenting
	../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3501 pvr2_hdw_cpufw_get() warn: inconsistent indenting
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2900 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

   checkpatch.pl:
	$ cat patches/0006-media-v4l2-ctrls-Add-RGB-color-effects-control.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:87: CHECK: spaces preferred around that '+' (ctx:VxV)
	-:91: CHECK: spaces preferred around that '+' (ctx:VxV)

patches/0008-media-stm32-dma2d-STM32-DMA2D-driver.patch:

   checkpatch.pl:
	$ cat patches/0008-media-stm32-dma2d-STM32-DMA2D-driver.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:42: WARNING: please write a paragraph that describes the config symbol fully
	-:78: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?


Error #512 when building PDF docs
Dillon Min Oct. 21, 2021, 9:45 p.m. UTC | #3
Hi Hans

On Thu, 21 Oct 2021 at 22:57, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
> I'll make a new PR for this without the clk patch.

Sure.

>
> Sorry Dillon, after digging a bit more into the clk series I think that this
> should go to the CLK subsystem. I do not feel comfortable merging that patch
> via the media subsystem because: 1) from what I can see it is part of a larger
> unmerged patch series, and 2) I do not have the expertise to tell if this is
> correct or not to just merge this patch.

That's fine thanks, there is no reason for clk patch not to be merged
via clk subsystem.
I can follow up on clk and dts patches, thanks for quick response on
my media driver review.

Best Regards
Dillon

>
> Regards,
>
>         Hans
>
> On 21/10/2021 16:45, Hans Verkuil wrote:
> > The following changes since commit 57c3b9f55ba875a6f6295fa59f0bdc0a01c544f8:
> >
> >   media: venus: core: Add sdm660 DT compatible and resource struct (2021-10-21 14:26:19 +0100)
> >
> > are available in the Git repository at:
> >
> >   git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.16k
> >
> > for you to fetch changes up to b019395c863f436adb30237b50f22b027bec7351:
> >
> >   media: stm32-dma2d: STM32 DMA2D driver (2021-10-21 16:14:57 +0200)
> >
> > ----------------------------------------------------------------
> > Tag branch
> >
> > ----------------------------------------------------------------
> > Dillon Min (8):
> >       media: admin-guide: add stm32-dma2d description
> >       media: dt-bindings: media: add document for STM32 DMA2d bindings
> >       media: v4l2-mem2mem: add v4l2_m2m_get_unmapped_area for no-mmu platform
> >       media: videobuf2: Fix the size printk format
> >       media: v4l2-ctrls: Add V4L2_CID_COLORFX_CBCR max setting
> >       media: v4l2-ctrls: Add RGB color effects control
> >       clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after system enter shell
> >       media: stm32-dma2d: STM32 DMA2D driver
> >
> >  Documentation/admin-guide/media/platform-cardlist.rst       |   1 +
> >  Documentation/devicetree/bindings/media/st,stm32-dma2d.yaml |  71 +++++
> >  Documentation/userspace-api/media/v4l/control.rst           |   9 +
> >  drivers/clk/clk-stm32f4.c                                   |   4 -
> >  drivers/media/common/videobuf2/videobuf2-dma-contig.c       |   8 +-
> >  drivers/media/platform/Kconfig                              |  11 +
> >  drivers/media/platform/Makefile                             |   1 +
> >  drivers/media/platform/stm32/Makefile                       |   2 +
> >  drivers/media/platform/stm32/dma2d/dma2d-hw.c               | 143 ++++++++++
> >  drivers/media/platform/stm32/dma2d/dma2d-regs.h             | 113 ++++++++
> >  drivers/media/platform/stm32/dma2d/dma2d.c                  | 739 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  drivers/media/platform/stm32/dma2d/dma2d.h                  | 135 ++++++++++
> >  drivers/media/v4l2-core/v4l2-ctrls-defs.c                   |  12 +-
> >  drivers/media/v4l2-core/v4l2-mem2mem.c                      |  21 ++
> >  include/media/v4l2-mem2mem.h                                |   5 +
> >  include/uapi/linux/v4l2-controls.h                          |   4 +-
> >  16 files changed, 1268 insertions(+), 11 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/media/st,stm32-dma2d.yaml
> >  create mode 100644 drivers/media/platform/stm32/dma2d/dma2d-hw.c
> >  create mode 100644 drivers/media/platform/stm32/dma2d/dma2d-regs.h
> >  create mode 100644 drivers/media/platform/stm32/dma2d/dma2d.c
> >  create mode 100644 drivers/media/platform/stm32/dma2d/dma2d.h
> >
>