From patchwork Mon Sep 13 22:07:14 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Perches X-Patchwork-Id: 175962 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id o8DM7iIP025732 for ; Mon, 13 Sep 2010 22:07:44 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752382Ab0IMWHR (ORCPT ); Mon, 13 Sep 2010 18:07:17 -0400 Received: from mail.perches.com ([173.55.12.10]:1966 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752079Ab0IMWHQ (ORCPT ); Mon, 13 Sep 2010 18:07:16 -0400 Received: from [192.168.1.162] (unknown [192.168.1.162]) by mail.perches.com (Postfix) with ESMTP id 0DB0D24368; Mon, 13 Sep 2010 15:07:12 -0700 (PDT) Subject: [PATCH 07/25] drivers/media/video/zoran: Don't use initialized char array From: Joe Perches To: Mauro Carvalho Chehab Cc: linux-kernel@vger.kernel.org, mjpeg-users@lists.sourceforge.net, linux-media@vger.kernel.org In-Reply-To: <4C8E9C95.8070201@infradead.org> References: <6b7055a2e53510e8903828a53cad300a7d5bb912.1284406638.git.joe@perches.com> <4C8E9C95.8070201@infradead.org> Date: Mon, 13 Sep 2010 15:07:14 -0700 Message-ID: <1284415634.26719.103.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Mon, 13 Sep 2010 22:07:44 +0000 (UTC) diff --git a/drivers/media/video/zoran/zoran_device.c b/drivers/media/video/zoran/zoran_device.c index 6f846ab..b02007e 100644 --- a/drivers/media/video/zoran/zoran_device.c +++ b/drivers/media/video/zoran/zoran_device.c @@ -1470,8 +1470,7 @@ zoran_irq (int irq, (zr->codec_mode == BUZ_MODE_MOTION_DECOMPRESS || zr->codec_mode == BUZ_MODE_MOTION_COMPRESS)) { if (zr36067_debug > 1 && (!zr->frame_num || zr->JPEG_error)) { - char sc[] = "0000"; - char sv[5]; + char sv[BUZ_NUM_STAT_COM + 1]; int i; printk(KERN_INFO @@ -1481,12 +1480,9 @@ zoran_irq (int irq, zr->jpg_settings.field_per_buff, zr->JPEG_missed); - strcpy(sv, sc); - for (i = 0; i < 4; i++) { - if (le32_to_cpu(zr->stat_com[i]) & 1) - sv[i] = '1'; - } - sv[4] = 0; + for (i = 0; i < BUZ_NUM_STAT_COM; i++) + sv[i] = le32_to_cpu(zr->stat_com[i]) & 1 ? '1' : '0'; + sv[BUZ_NUM_STAT_COM] = 0; printk(KERN_INFO "%s: stat_com=%s queue_state=%ld/%ld/%ld/%ld\n", ZR_DEVNAME(zr), sv,