| Message ID | 1304869873-9974-3-git-send-email-steve@stevekerrison.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Em 08-05-2011 12:51, Steve Kerrison escreveu: > Unimplemented delivery system and modes were #define'd to > arbitrary values for internal use. API now includes these values > so we can remove this hack. > > Signed-off-by: Steve Kerrison <steve@stevekerrison.com> > --- > drivers/media/dvb/frontends/cxd2820r_priv.h | 12 ------------ > 1 files changed, 0 insertions(+), 12 deletions(-) > > diff --git a/drivers/media/dvb/frontends/cxd2820r_priv.h b/drivers/media/dvb/frontends/cxd2820r_priv.h > index d4e2e0b..25adbee 100644 > --- a/drivers/media/dvb/frontends/cxd2820r_priv.h > +++ b/drivers/media/dvb/frontends/cxd2820r_priv.h > @@ -40,18 +40,6 @@ > #undef warn > #define warn(f, arg...) printk(KERN_WARNING LOG_PREFIX": " f "\n" , ## arg) > > -/* > - * FIXME: These are totally wrong and must be added properly to the API. > - * Only temporary solution in order to get driver compile. > - */ > -#define SYS_DVBT2 SYS_DAB > -#define TRANSMISSION_MODE_1K 0 > -#define TRANSMISSION_MODE_16K 0 > -#define TRANSMISSION_MODE_32K 0 > -#define GUARD_INTERVAL_1_128 0 > -#define GUARD_INTERVAL_19_128 0 > -#define GUARD_INTERVAL_19_256 0 > - Please, just fold this patch with Andreas one, adding a small note like: [steve@...: removed the priv definitions from cxd2820r] Otherwise, you'll be breaking git disect. Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/dvb/frontends/cxd2820r_priv.h b/drivers/media/dvb/frontends/cxd2820r_priv.h index d4e2e0b..25adbee 100644 --- a/drivers/media/dvb/frontends/cxd2820r_priv.h +++ b/drivers/media/dvb/frontends/cxd2820r_priv.h @@ -40,18 +40,6 @@ #undef warn #define warn(f, arg...) printk(KERN_WARNING LOG_PREFIX": " f "\n" , ## arg) -/* - * FIXME: These are totally wrong and must be added properly to the API. - * Only temporary solution in order to get driver compile. - */ -#define SYS_DVBT2 SYS_DAB -#define TRANSMISSION_MODE_1K 0 -#define TRANSMISSION_MODE_16K 0 -#define TRANSMISSION_MODE_32K 0 -#define GUARD_INTERVAL_1_128 0 -#define GUARD_INTERVAL_19_128 0 -#define GUARD_INTERVAL_19_256 0 - struct reg_val_mask { u32 reg; u8 val;
Unimplemented delivery system and modes were #define'd to arbitrary values for internal use. API now includes these values so we can remove this hack. Signed-off-by: Steve Kerrison <steve@stevekerrison.com> --- drivers/media/dvb/frontends/cxd2820r_priv.h | 12 ------------ 1 files changed, 0 insertions(+), 12 deletions(-)