From patchwork Mon Aug 29 17:02:38 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luciano Coelho X-Patchwork-Id: 1109202 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p7THrWSX008158 for ; Mon, 29 Aug 2011 17:53:35 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754368Ab1H2RCo (ORCPT ); Mon, 29 Aug 2011 13:02:44 -0400 Received: from na3sys009aog116.obsmtp.com ([74.125.149.240]:49608 "EHLO na3sys009aog116.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754325Ab1H2RCn (ORCPT ); Mon, 29 Aug 2011 13:02:43 -0400 Received: from mail-bw0-f51.google.com ([209.85.214.51]) (using TLSv1) by na3sys009aob116.postini.com ([74.125.148.12]) with SMTP ID DSNKTlvGMuYnguFcXFVDhchX+2MCwsHowh/q@postini.com; Mon, 29 Aug 2011 10:02:43 PDT Received: by mail-bw0-f51.google.com with SMTP id r19so3799538bka.10 for ; Mon, 29 Aug 2011 10:02:42 -0700 (PDT) Received: by 10.204.141.220 with SMTP id n28mr2344237bku.361.1314637361909; Mon, 29 Aug 2011 10:02:41 -0700 (PDT) Received: from [192.168.100.30] (a88-115-100-174.elisa-laajakaista.fi [88.115.100.174]) by mx.google.com with ESMTPS id u14sm1265099bkt.62.2011.08.29.10.02.39 (version=SSLv3 cipher=OTHER); Mon, 29 Aug 2011 10:02:40 -0700 (PDT) Subject: Kconfig unmet dependency with RADIO_WL1273 From: Luciano Coelho To: matti.j.aaltonen@nokia.com Cc: johannes@sipsolutions.net, linux-kernel@vger.kernel.org, sameo@linux.intel.com, mchehab@infradead.org, linux-media@vger.kernel.org Date: Mon, 29 Aug 2011 20:02:38 +0300 Message-ID: <1314637358.2296.395.camel@cumari> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Mon, 29 Aug 2011 17:53:35 +0000 (UTC) Hi Matti, Johannes has just reported a problem in the Kconfig of radio-wl1273. It seems to select MFD_CORE, but if the platform doesn't support MFD, then MFD_SUPPORT won't be selected and this kind of warning will come out: warning: (OLPC_XO1_PM && OLPC_XO1_SCI && I2C_ISCH && GPIO_SCH && GPIO_RDC321X && RADIO_WL1273) selects MFD_CORE which has unmet direct dependencies (MFD_SUPPORT) I guess it must depend on MFD_SUPPORT, right? If that's the correct solution, the following patch should fix the problem: The same problem is happening with other drivers too, so maybe there is a better solution to fix all problems at once. ;) Reported-by: Johannes Berg diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig index 52798a1..e87f544 100644 --- a/drivers/media/radio/Kconfig +++ b/drivers/media/radio/Kconfig @@ -425,7 +425,7 @@ config RADIO_TIMBERDALE config RADIO_WL1273 tristate "Texas Instruments WL1273 I2C FM Radio" - depends on I2C && VIDEO_V4L2 + depends on I2C && VIDEO_V4L2 && MFD_SUPPORT select MFD_CORE select MFD_WL1273_CORE select FW_LOADER