From patchwork Tue Aug 7 09:58:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 10558479 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8DD1814E2 for ; Tue, 7 Aug 2018 09:59:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7C27929808 for ; Tue, 7 Aug 2018 09:59:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 701E729842; Tue, 7 Aug 2018 09:59:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1393729808 for ; Tue, 7 Aug 2018 09:59:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732135AbeHGMMf (ORCPT ); Tue, 7 Aug 2018 08:12:35 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:59386 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729922AbeHGMMe (ORCPT ); Tue, 7 Aug 2018 08:12:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Sender:Message-Id:Date:Subject:Cc:To: From:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MhzFZXeCA33kcmlN5hr7m2XUde+L+GeogSammzMHCiQ=; b=Hi29G0XhlTuLcP8Rh21xMXmjDh r2+ME+ebf1rRU44gpUY3syyDUyIHVGIXk9I/buxet3POUuEHthgK2m9UlgAEK7Z7+xtaz+AHnQ9qb UeCA2Z0V7uGpfJpRoPQw9xjDafnmE+en/ipUjvEqU6HYsJWZWBOpr3BgWkLHLZUcW0YqxwPJv8k2l Rn/+N4pXFlY27Ftjny3lcAHhCiTE7BNB2lbPLzhG5AkW5e41y7/+CRt0tf+hAxesLmuOHjmimPZzx MGJ4+aZ7m6SrUCaMTyw05N+KOc55LYKoid9qAFS0uDZ6rnA+hxkooCPx3iEvhLyfmPicr5n7ik4yv UvDF9I9A==; Received: from [179.177.31.111] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fmylZ-0001ES-I6; Tue, 07 Aug 2018 09:59:01 +0000 Received: from mchehab by bombadil.infradead.org with local (Exim 4.91) (envelope-from ) id 1fmylX-00084J-1J; Tue, 07 Aug 2018 05:58:59 -0400 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Linux Media Mailing List , Mauro Carvalho Chehab , Steve Longerbeam , Philipp Zabel , Greg Kroah-Hartman , devel@driverdev.osuosl.org Subject: [PATCH] media: imx: shut up a false positive warning Date: Tue, 7 Aug 2018 05:58:58 -0400 Message-Id: <132f3c7bb98673f713be9511de16b7622803df36.1533635936.git.mchehab+samsung@kernel.org> X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP With imx, gcc produces a false positive warning: drivers/staging/media/imx/imx-media-csi.c: In function 'csi_idmac_setup_channel': drivers/staging/media/imx/imx-media-csi.c:457:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (passthrough) { ^ drivers/staging/media/imx/imx-media-csi.c:464:2: note: here default: ^~~~~~~ That's because the regex it uses for fall trough is not good enough. So, rearrange the fall through comment in a way that gcc will recognize. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/imx/imx-media-csi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c index 4647206f92ca..b7ffd231c64b 100644 --- a/drivers/staging/media/imx/imx-media-csi.c +++ b/drivers/staging/media/imx/imx-media-csi.c @@ -460,7 +460,8 @@ static int csi_idmac_setup_channel(struct csi_priv *priv) passthrough_cycles = incc->cycles; break; } - /* fallthrough for non-passthrough RGB565 (CSI-2 bus) */ + /* for non-passthrough RGB565 (CSI-2 bus) */ + /* Falls through */ default: burst_size = (image.pix.width & 0xf) ? 8 : 16; passthrough_bits = 16;