From patchwork Sat Jun 30 22:42:15 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 1143781 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 8CDFADFF7B for ; Sat, 30 Jun 2012 22:42:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753127Ab2F3Wmf (ORCPT ); Sat, 30 Jun 2012 18:42:35 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:51113 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752813Ab2F3Wme (ORCPT ); Sat, 30 Jun 2012 18:42:34 -0400 Received: by mail-bk0-f46.google.com with SMTP id ji2so3878345bkc.19 for ; Sat, 30 Jun 2012 15:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=7sG5YXimdlPuqBNkhdStqdA7XsR2D9LpNzgfiTdFb8U=; b=JDrOKKqJDgsp4WFxf9AxdVQr7UKPJiOlT6RpFffJD9P+F8bso79Ua0BG8MZOIdFkOT jJ2nv/fF/4xqqy4XjCvmHknFriY2u509kwckq5dKuTxNapMitDgkcw7T/V5pl30aLfr4 Txombo0O2oOQ3bWOlTLDHSuArLSbmyWFi2KQOuxlS2DRmy13vpsb4ywdsPDXwUs6UE2p fAsePpDfvmPlSwN9Juv6GfhkhJOttaJT5IVwn3vouYaLRJZT3KBOlVaKuv7NZVywUw3I MJG4SHi2qBixxpM115Px5mBPVTaSvF6RNLIHvCdLoUcNW9OG53Snt4H0TzHAjT3GpV4h Dv2Q== Received: by 10.204.145.89 with SMTP id c25mr4015647bkv.5.1341096153256; Sat, 30 Jun 2012 15:42:33 -0700 (PDT) Received: from blackbox.lan (p4FE613E4.dip0.t-ipconnect.de. [79.230.19.228]) by mx.google.com with ESMTPS id ig1sm7647682bkc.4.2012.06.30.15.42.31 (version=SSLv3 cipher=OTHER); Sat, 30 Jun 2012 15:42:32 -0700 (PDT) From: Martin Blumenstingl To: linux-media@vger.kernel.org Cc: Martin Blumenstingl Subject: [PATCH 2/2] [media] drxk: Improve logging. Date: Sun, 1 Jul 2012 00:42:15 +0200 Message-Id: <1341096135-1393-2-git-send-email-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 1.7.11.1 In-Reply-To: <1340918440-17523-3-git-send-email-martin.blumenstingl@googlemail.com> References: <1340918440-17523-3-git-send-email-martin.blumenstingl@googlemail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This patch simply fixes some logging calls: - Use KERN_INFO when printing the chip status. - Add a missing space when logging the drxk_gate_ctrl call. - Use the same logging text as always if the scu_command in GetQAMLockStatus fails. Signed-off-by: Martin Blumenstingl --- drivers/media/dvb/frontends/drxk_hard.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb/frontends/drxk_hard.c b/drivers/media/dvb/frontends/drxk_hard.c index ef146ca..128a4e6 100644 --- a/drivers/media/dvb/frontends/drxk_hard.c +++ b/drivers/media/dvb/frontends/drxk_hard.c @@ -959,7 +959,7 @@ static int GetDeviceCapabilities(struct drxk_state *state) if (status < 0) goto error; -printk(KERN_ERR "drxk: status = 0x%08x\n", sioTopJtagidLo); + printk(KERN_INFO "drxk: status = 0x%08x\n", sioTopJtagidLo); /* driver 0.9.0 */ switch ((sioTopJtagidLo >> 29) & 0xF) { @@ -5388,7 +5388,7 @@ static int GetQAMLockStatus(struct drxk_state *state, u32 *pLockStatus) SCU_RAM_COMMAND_CMD_DEMOD_GET_LOCK, 0, NULL, 2, Result); if (status < 0) - printk(KERN_ERR "drxk: %s status = %08x\n", __func__, status); + printk(KERN_ERR "drxk: Error %d on %s\n", status, __func__); if (Result[1] < SCU_RAM_QAM_LOCKED_LOCKED_DEMOD_LOCKED) { /* 0x0000 NOT LOCKED */ @@ -6318,7 +6318,7 @@ static int drxk_gate_ctrl(struct dvb_frontend *fe, int enable) { struct drxk_state *state = fe->demodulator_priv; - dprintk(1, "%s\n", enable ? "enable" : "disable"); + dprintk(1, ": %s\n", enable ? "enable" : "disable"); if (state->m_DrxkState == DRXK_NO_DEV) return -ENODEV;