From patchwork Fri Jul 20 14:00:57 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 1221201 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id F3DC23FD48 for ; Fri, 20 Jul 2012 14:01:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752216Ab2GTOBL (ORCPT ); Fri, 20 Jul 2012 10:01:11 -0400 Received: from mail-gg0-f174.google.com ([209.85.161.174]:40542 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752136Ab2GTOBK (ORCPT ); Fri, 20 Jul 2012 10:01:10 -0400 Received: by gglu4 with SMTP id u4so3985484ggl.19 for ; Fri, 20 Jul 2012 07:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=sTfXbrYliU8yfiKP5kGc1Gk1bNdWWf1kVQ1OltkI/tQ=; b=traJzewRIFFUY+cUkM9mHCWpBhLIJw71XZbEf8hbisFHGS0o4IoL9ipVR8SCiZdzlw /Y6Fm2IoQStz1zfDkfh8wm+FGgac1OVWA9WwidvOTRXPQq9abLRAy60JjCRlDCgoZNVy oYOR4GjiI35n0HQgYcpd1MoZh/HRkxQG06lrr+3oP1kBQg45oNhpJME6EESbA4bq7D8N e6ZDdS+TepHzganGvs0DgWndfwDl3ugS5608FFeyDwSDbQxFasYh28y8jTQANVm3Bhjb Cs8+dyDFpk1O6QUt+xdH6o28cBsmBlsK5xMKlKCdVIlD9JVYObvhIDkLgm1SDlWb8TY/ fa7Q== Received: by 10.66.88.39 with SMTP id bd7mr8304673pab.50.1342792869370; Fri, 20 Jul 2012 07:01:09 -0700 (PDT) Received: from localhost.localdomain ([122.166.13.141]) by mx.google.com with ESMTPS id ob9sm4030704pbb.28.2012.07.20.07.01.06 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 20 Jul 2012 07:01:08 -0700 (PDT) From: Prabhakar Lad To: LMML Cc: dlos , "Lad, Prabhakar" , Manjunath Hadli Subject: [PATCH] davinci: vpbe: fix check for s_dv_preset function pointer Date: Fri, 20 Jul 2012 19:30:57 +0530 Message-Id: <1342792857-16421-1-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.7.4.1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Lad, Prabhakar fix check for s_dv_preset function pointer to be NULL. return -EINVAL if function pointer is NULL. Signed-off-by: Lad, Prabhakar Signed-off-by: Manjunath Hadli --- drivers/media/video/davinci/vpbe_display.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/davinci/vpbe_display.c b/drivers/media/video/davinci/vpbe_display.c index e106b72..f78ccc0 100644 --- a/drivers/media/video/davinci/vpbe_display.c +++ b/drivers/media/video/davinci/vpbe_display.c @@ -1083,7 +1083,7 @@ vpbe_display_s_dv_preset(struct file *file, void *priv, } /* Set the given standard in the encoder */ - if (NULL != vpbe_dev->ops.s_dv_preset) + if (!vpbe_dev->ops.s_dv_preset) return -EINVAL; ret = vpbe_dev->ops.s_dv_preset(vpbe_dev, preset);