diff mbox

[media] tw686x-kh: use the cached value

Message ID 13431509a41889a70cc76b31180f63fd10d0a5b3.1461170447.git.mchehab@osg.samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mauro Carvalho Chehab April 20, 2016, 4:41 p.m. UTC 
the dma_requests field is cached, but cache is not used:

drivers/staging/media/tw686x-kh/tw686x-kh-video.c: In function 'tw686x_video_irq':
drivers/staging/media/tw686x-kh/tw686x-kh-video.c:622:6: warning: variable 'requests' set but not used [-Wunused-but-set-variable]
  u32 requests;
      ^

Use the cache instead, as it seems reading it needs to be done
with spin lock taken.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
---
 drivers/staging/media/tw686x-kh/tw686x-kh-video.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/drivers/staging/media/tw686x-kh/tw686x-kh-video.c b/drivers/staging/media/tw686x-kh/tw686x-kh-video.c
index 2fbc3cbd9eb0..0650c29f78eb 100644
--- a/drivers/staging/media/tw686x-kh/tw686x-kh-video.c
+++ b/drivers/staging/media/tw686x-kh/tw686x-kh-video.c
@@ -625,7 +625,7 @@  int tw686x_video_irq(struct tw686x_dev *dev)
 	requests = dev->dma_requests;
 	spin_unlock_irqrestore(&dev->irq_lock, flags);
 
-	if (dev->dma_requests & dev->video_active) {
+	if (requests & dev->video_active) {
 		wake_up_interruptible_all(&dev->video_thread_wait);
 		handled = 1;
 	}