From patchwork Thu Aug 2 23:31:53 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Malcolm Priestley X-Patchwork-Id: 1268291 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 529133FC33 for ; Thu, 2 Aug 2012 23:32:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754009Ab2HBXcH (ORCPT ); Thu, 2 Aug 2012 19:32:07 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:33459 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753639Ab2HBXcD (ORCPT ); Thu, 2 Aug 2012 19:32:03 -0400 Received: by weyx8 with SMTP id x8so53303wey.19 for ; Thu, 02 Aug 2012 16:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-type:x-mailer:content-transfer-encoding:mime-version; bh=VRJNW6DHOHgXbgN5KnGgf8fO8lc0YUhbYHXR42oiz7Q=; b=h+uzPjO2k11Op44ZliG5MzS3c/UOl6n/chN0gUX/GfjfgHu7XCHkPNlzg+keCUbomC HbHaFtHBkqOlSQOAZcqA0Gr7tLPlcB1x50puU1xCMY4g/VLFY1Z5Peu0+VFXCGhpP7oz SFH9e2GCNRjQq4POzmB1dyvDT1pLGtWil6QxKtYk7lxiZqCxugSEqbOJuO3NXCQoWMdJ YRhUU/oFI1IfAfmSuYGGpCwKwYQMwR4lFItxqb5fT3xpwrqEA2VKcrSSb+DH+OKaAtV9 bqWzP9rszq8EsisZ8oxAejUGtGKexHv1j2lSOsUDrANp53xu9XLFLaoKaR9aRPGhbHDP NOxA== Received: by 10.180.81.38 with SMTP id w6mr8477072wix.10.1343950322407; Thu, 02 Aug 2012 16:32:02 -0700 (PDT) Received: from [94.197.238.252] (94.197.238.252.threembb.co.uk. [94.197.238.252]) by mx.google.com with ESMTPS id t7sm21069826wix.6.2012.08.02.16.31.59 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 02 Aug 2012 16:32:00 -0700 (PDT) Message-ID: <1343950313.11458.10.camel@router7789> Subject: [PATCH] [BUG] Re: dvb_usb_lmedm04 crash Kernel (rs2000) From: Malcolm Priestley To: Antti Palosaari Cc: linux-media Date: Fri, 03 Aug 2012 00:31:53 +0100 In-Reply-To: <501AE90E.2020201@iki.fi> References: <501AE90E.2020201@iki.fi> X-Mailer: Evolution 3.2.3-0ubuntu6 Mime-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, 2012-08-02 at 23:54 +0300, Antti Palosaari wrote: > Moi Malcolm, > Any idea why this seems to crash Kernel just when device is plugged? > Hi Antti Yes, there missing error handling when no firmware file found. It seems that this is more of a problem with udev-182+. However, so far udev-182 is only a problem on first ever plug. Regards Malcolm Signed-off-by: Malcolm Priestley Tested-by: Antti Palosaari --- drivers/media/dvb/dvb-usb/lmedm04.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c b/drivers/media/dvb/dvb-usb/lmedm04.c index 25d1031..26ba5bc 100644 --- a/drivers/media/dvb/dvb-usb/lmedm04.c +++ b/drivers/media/dvb/dvb-usb/lmedm04.c @@ -878,6 +878,10 @@ static int lme_firmware_switch(struct usb_device *udev, int cold) fw_lme = fw_c_rs2000; ret = request_firmware(&fw, fw_lme, &udev->dev); dvb_usb_lme2510_firmware = TUNER_RS2000; + if (ret == 0) + break; + info("FRM No Firmware Found - please install"); + cold_fw = 0; break; default: fw_lme = fw_c_s7395;