| Message ID | 1344016352-20302-1-git-send-email-elezegarcia@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Aug 3, 2012 at 2:52 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote: > This was introduced on commit c2a6b54a9: > "em28xx: fix: don't do image interlacing on webcams" > It is a known bug that has already been reported several times > and confirmed by Mauro. > Tested by compilation only. > I wonder if it's possible to get an Ack or a Tested-By from any of the em28xx owners? Also, Devin: you mentioned in an old mail [1] you had some patches for em28xx, but you had no time to put them into shape for submission. If you want to, send then to me (or the full em28xx tree) and I can try to submit the patches. Thanks, Ezequiel. [1] http://www.mail-archive.com/linux-media@vger.kernel.org/msg48232.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Aug 3, 2012 at 2:11 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote: > On Fri, Aug 3, 2012 at 2:52 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote: >> This was introduced on commit c2a6b54a9: >> "em28xx: fix: don't do image interlacing on webcams" >> It is a known bug that has already been reported several times >> and confirmed by Mauro. >> Tested by compilation only. >> > > I wonder if it's possible to get an Ack or a Tested-By from any of the > em28xx owners? This shouldn't be accepted upstream without testing at least on x86. I did make such a change to make it work in my ARM tree, but I don't fully understand the nature of the change and I'm not completely confident it's correct for x86 (based on my reading of the datasheet and how the accumulator field is structured in the em28xx chip). Also, I actually don't have any progressive devices (I've got probably a dozen em28xx devices, but they are all interlaced capture), which made me particularly hesitant to submit this patch. > Also, Devin: you mentioned in an old mail [1] you had some patches for em28xx, > but you had no time to put them into shape for submission. > > If you want to, send then to me (or the full em28xx tree) and I can > try to submit > the patches. Yeah, probably not a bad idea. I've been sitting on the tree because they haven't been tested on any other platforms and some of them are not necessarily generally suitable for the mainline kernel. And of course the tree needs to be parsed out into an actual patch series, and each patch has to be individually validated across multiple devices to ensure they don't cause breakage (they were tested on an em2863, but I have no idea if they cause problems on other chips such as the em2820 or em2880). All that said, I'm not really sure what the benefit would be in sending you the tree if you don't actually have any hardware to test with. The last thing we need is more crap being sent upstream that is "compile tested only" since that's where many of the regressions come from (well meaning people sending completely untested 'cleanup patches' can cause more harm than good). Devin
diff --git a/drivers/media/video/em28xx/em28xx-core.c b/drivers/media/video/em28xx/em28xx-core.c index de2cb20..6daa861 100644 --- a/drivers/media/video/em28xx/em28xx-core.c +++ b/drivers/media/video/em28xx/em28xx-core.c @@ -786,7 +786,7 @@ int em28xx_resolution_set(struct em28xx *dev) dev->vbi_height = 18; if (!dev->progressive) - height >>= norm_maxh(dev); + height = height / 2; em28xx_set_outfmt(dev);
This was introduced on commit c2a6b54a9: "em28xx: fix: don't do image interlacing on webcams" It is a known bug that has already been reported several times and confirmed by Mauro. Tested by compilation only. Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com> --- Hi, I have no idea why this hasn't been fixed before. See this mail for Mauro's confirmation http://www.digipedia.pl/usenet/thread/18550/7691/#post7685 where he requested a patch on reporter. I guess the patch never came in. Regards, Ezequiel. --- drivers/media/video/em28xx/em28xx-core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)