From patchwork Mon Aug 13 18:42:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Malcolm Priestley X-Patchwork-Id: 1314701 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 984F3E0000 for ; Mon, 13 Aug 2012 18:42:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752380Ab2HMSmo (ORCPT ); Mon, 13 Aug 2012 14:42:44 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:41247 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752429Ab2HMSmm (ORCPT ); Mon, 13 Aug 2012 14:42:42 -0400 Received: by wicr5 with SMTP id r5so2902606wic.1 for ; Mon, 13 Aug 2012 11:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:date:in-reply-to:references:content-type :x-mailer:content-transfer-encoding:mime-version; bh=txYijNZRUteAGihQMfTie57FDle2pWPQefTc/cbibk0=; b=TOtNBZnAE9I8fFq3VEHXVB4g8e9qzpvqJH0vNLbikXWWaReBfUX0pZmTPUK6JTtKNW YaSS5xmUGK9p85NJNsSD6p3IFeUyK4gPM6gADaMripQS3e8RinosGPr0lAmShanwVboU lDjzl03/8NsnyQbRx7m8DNUnwthLuTKJD298OJL75h8/MeMgDJE7XAi1525jq7nlzvog vZRc1bZlJbiaPJahlepPGfOQvzaSPhpXnxc+ywxql113pEr2Ri4UMMZ7+CKYT+6og7eQ JcHXuDU/FUmpGXNlcGfR5IwXV1Q9W/kw5pQP0G/qDFf2oOlATCqXCd8sEJYzfvCSVJPF I1/w== Received: by 10.180.74.33 with SMTP id q1mr20662393wiv.4.1344883360896; Mon, 13 Aug 2012 11:42:40 -0700 (PDT) Received: from [94.197.54.194] (94.197.54.194.threembb.co.uk. [94.197.54.194]) by mx.google.com with ESMTPS id q4sm17837595wix.9.2012.08.13.11.42.38 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 13 Aug 2012 11:42:40 -0700 (PDT) Message-ID: <1344883337.3041.0.camel@router7789> Subject: [PATCH] re: [media] lmedm04: fix build From: Malcolm Priestley To: linux-media@vger.kernel.org Date: Mon, 13 Aug 2012 19:42:17 +0100 In-Reply-To: <20120813165811.GB5363@elgon.mountain> References: <20120813165811.GB5363@elgon.mountain> X-Mailer: Evolution 3.2.3-0ubuntu6 Mime-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, 2012-08-13 at 19:58 +0300, Dan Carpenter wrote: > Hello Mauro Carvalho Chehab, > > The patch db6651a9ebb3: "[media] lmedm04: fix build" from Aug 12, > 2012, leads to the following warning: > drivers/media/dvb/dvb-usb-v2/lmedm04.c:769 lme2510_download_firmware() > error: usb_control_msg() 'data' too small (128 vs 265) > > 737 data = kzalloc(128, GFP_KERNEL); > ^^^ > data is 128 bytes. Hi All Control isn't used, so remove it. Signed-off-by: Malcolm Priestley --- drivers/media/dvb/dvb-usb-v2/lmedm04.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/media/dvb/dvb-usb-v2/lmedm04.c b/drivers/media/dvb/dvb-usb-v2/lmedm04.c index c6bc1b8..c41d9d9 100644 --- a/drivers/media/dvb/dvb-usb-v2/lmedm04.c +++ b/drivers/media/dvb/dvb-usb-v2/lmedm04.c @@ -766,10 +766,6 @@ static int lme2510_download_firmware(struct dvb_usb_device *d, } } - usb_control_msg(d->udev, usb_rcvctrlpipe(d->udev, 0), - 0x06, 0x80, 0x0200, 0x00, data, 0x0109, 1000); - - data[0] = 0x8a; len_in = 1; msleep(2000);