From patchwork Thu Aug 23 13:08:31 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 1367061 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 350013FC66 for ; Thu, 23 Aug 2012 13:09:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758805Ab2HWNJV (ORCPT ); Thu, 23 Aug 2012 09:09:21 -0400 Received: from mail-gg0-f174.google.com ([209.85.161.174]:41263 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758878Ab2HWNJT (ORCPT ); Thu, 23 Aug 2012 09:09:19 -0400 Received: by ggdk6 with SMTP id k6so170818ggd.19 for ; Thu, 23 Aug 2012 06:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=wlff5R4AOzrVWwJPlzXFvZuuI4KC1o5W4vOYwlWcWh0=; b=gOAIy3AhOrDL7NXnnMkPly3ftPOL6SmwFXuw+n5tcsL4kdvyqPYLWWpNXlpDe3vlEB 3sS+EjDunv/iMm9cBxzr1bA8Skr0mRcqCLquHXcE559qUu31eJpjwmmSYhxMqYu9iUn1 IgqM1uXPrnXyLYP7KYjuWMIaDVop1uTvPOzZpXGCYPD1yO5xGjAR1RVXILzJeiVvWWNi aki/vp5xvCFTKpSN+UsSuZmyfZw21gkBzKW9S6XyPXXgw3czOOhkxZ6BwLTZ0g9vTBH8 oHdcM2GPT50PBZPH7pS9zp42CnFlOpGSxC6VC6LdWW/87iZ/k1uLgGV+T91wuk4Ww4TW /1Eg== Received: by 10.236.177.70 with SMTP id c46mr1174944yhm.33.1345727358784; Thu, 23 Aug 2012 06:09:18 -0700 (PDT) Received: from localhost.cpe.express.com.ar ([200.81.126.15]) by mx.google.com with ESMTPS id v5sm6703664anj.16.2012.08.23.06.09.16 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 23 Aug 2012 06:09:17 -0700 (PDT) From: Ezequiel Garcia To: Mauro Carvalho Chehab , Cc: Ezequiel Garcia , Kamil Debski Subject: [PATCH 10/10] s5p-g2d: Remove unneeded struct vb2_queue clear on queue_init() Date: Thu, 23 Aug 2012 10:08:31 -0300 Message-Id: <1345727311-27478-10-git-send-email-elezegarcia@gmail.com> X-Mailer: git-send-email 1.7.8.6 In-Reply-To: <1345727311-27478-1-git-send-email-elezegarcia@gmail.com> References: <1345727311-27478-1-git-send-email-elezegarcia@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org queue_init() is always called by v4l2_m2m_ctx_init(), which allocates a context struct v4l2_m2m_ctx with kzalloc. Therefore, there is no need to clear vb2_queue src/dst structs. Cc: Kamil Debski Signed-off-by: Ezequiel Garcia --- drivers/media/platform/s5p-g2d/g2d.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-g2d/g2d.c b/drivers/media/platform/s5p-g2d/g2d.c index 0edc2df..30195ef 100644 --- a/drivers/media/platform/s5p-g2d/g2d.c +++ b/drivers/media/platform/s5p-g2d/g2d.c @@ -151,7 +151,6 @@ static int queue_init(void *priv, struct vb2_queue *src_vq, struct g2d_ctx *ctx = priv; int ret; - memset(src_vq, 0, sizeof(*src_vq)); src_vq->type = V4L2_BUF_TYPE_VIDEO_OUTPUT; src_vq->io_modes = VB2_MMAP | VB2_USERPTR; src_vq->drv_priv = ctx; @@ -163,7 +162,6 @@ static int queue_init(void *priv, struct vb2_queue *src_vq, if (ret) return ret; - memset(dst_vq, 0, sizeof(*dst_vq)); dst_vq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE; dst_vq->io_modes = VB2_MMAP | VB2_USERPTR; dst_vq->drv_priv = ctx;