From patchwork Thu Aug 23 13:08:25 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 1367001 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 4794CDF2AB for ; Thu, 23 Aug 2012 13:09:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758851Ab2HWNI7 (ORCPT ); Thu, 23 Aug 2012 09:08:59 -0400 Received: from mail-gh0-f174.google.com ([209.85.160.174]:55121 "EHLO mail-gh0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751635Ab2HWNI6 (ORCPT ); Thu, 23 Aug 2012 09:08:58 -0400 Received: by mail-gh0-f174.google.com with SMTP id r11so169562ghr.19 for ; Thu, 23 Aug 2012 06:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=Vx8CsALRXaseopg9oYk8XnY3wpoY/QhSOBEfqdlvCv0=; b=ybOgoHwh4EyzPyvfWtxw9aelq/nYHDY4p+KdDP10kaKjPcucW56ZQdYNXK3rAYsExi lB9mEwDZRQ8ed38/unZ6D4rObSr7QmK+C9i7P9Sx4thUJnc95SC3rK/srRkO8sfhDhwg oGc6EdeiMSUi7xXHHprRIamBno5lu/LzJuVDD3ii7n6xHGthOqsO2UWV51MYbxISnswj /kxlKjKg3fXidp2BjYcSZ8UlOyzULQxdjscjdsqDRcHuntsktC1d2q2/XnccOGK2xQAS WbQSpCXcyLmc3x/RmZASjoduZHUWWKpFNVP+pdRfA2aDotUKbVN17ifyZR61cvs6AdHN U+7w== Received: by 10.236.135.147 with SMTP id u19mr1086525yhi.115.1345727338133; Thu, 23 Aug 2012 06:08:58 -0700 (PDT) Received: from localhost.cpe.express.com.ar ([200.81.126.15]) by mx.google.com with ESMTPS id v5sm6703664anj.16.2012.08.23.06.08.55 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 23 Aug 2012 06:08:57 -0700 (PDT) From: Ezequiel Garcia To: Mauro Carvalho Chehab , Cc: Ezequiel Garcia Subject: [PATCH 04/10] mem2mem_testdev: Remove unneeded struct vb2_queue clear on queue_init() Date: Thu, 23 Aug 2012 10:08:25 -0300 Message-Id: <1345727311-27478-4-git-send-email-elezegarcia@gmail.com> X-Mailer: git-send-email 1.7.8.6 In-Reply-To: <1345727311-27478-1-git-send-email-elezegarcia@gmail.com> References: <1345727311-27478-1-git-send-email-elezegarcia@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org queue_init() is always called by v4l2_m2m_ctx_init(), which allocates a context struct v4l2_m2m_ctx with kzalloc. Therefore, there is no need to clear vb2_queue src/dst structs. Signed-off-by: Ezequiel Garcia --- drivers/media/platform/mem2mem_testdev.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mem2mem_testdev.c b/drivers/media/platform/mem2mem_testdev.c index 51b6dd4..9a8b14f 100644 --- a/drivers/media/platform/mem2mem_testdev.c +++ b/drivers/media/platform/mem2mem_testdev.c @@ -838,7 +838,6 @@ static int queue_init(void *priv, struct vb2_queue *src_vq, struct vb2_queue *ds struct m2mtest_ctx *ctx = priv; int ret; - memset(src_vq, 0, sizeof(*src_vq)); src_vq->type = V4L2_BUF_TYPE_VIDEO_OUTPUT; src_vq->io_modes = VB2_MMAP; src_vq->drv_priv = ctx; @@ -850,7 +849,6 @@ static int queue_init(void *priv, struct vb2_queue *src_vq, struct vb2_queue *ds if (ret) return ret; - memset(dst_vq, 0, sizeof(*dst_vq)); dst_vq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE; dst_vq->io_modes = VB2_MMAP; dst_vq->drv_priv = ctx;