| Message ID | 1345727311-27478-7-git-send-email-elezegarcia@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 23 August 2012 15:08, Ezequiel Garcia <elezegarcia@gmail.com> wrote: > queue_init() is always called by v4l2_m2m_ctx_init(), which allocates > a context struct v4l2_m2m_ctx with kzalloc. > Therefore, there is no need to clear vb2_queue src/dst structs. > > Cc: Javier Martin <javier.martin@vista-silicon.com> > Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com> > --- > drivers/media/platform/mx2_emmaprp.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/mx2_emmaprp.c b/drivers/media/platform/mx2_emmaprp.c > index dab380a..59aaca4 100644 > --- a/drivers/media/platform/mx2_emmaprp.c > +++ b/drivers/media/platform/mx2_emmaprp.c > @@ -757,7 +757,6 @@ static int queue_init(void *priv, struct vb2_queue *src_vq, > struct emmaprp_ctx *ctx = priv; > int ret; > > - memset(src_vq, 0, sizeof(*src_vq)); > src_vq->type = V4L2_BUF_TYPE_VIDEO_OUTPUT; > src_vq->io_modes = VB2_MMAP | VB2_USERPTR; > src_vq->drv_priv = ctx; > @@ -769,7 +768,6 @@ static int queue_init(void *priv, struct vb2_queue *src_vq, > if (ret) > return ret; > > - memset(dst_vq, 0, sizeof(*dst_vq)); > dst_vq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE; > dst_vq->io_modes = VB2_MMAP | VB2_USERPTR; > dst_vq->drv_priv = ctx; > -- > 1.7.8.6 > Acked-By: Javier Martin <javier.martin@vista-silicon.com>
diff --git a/drivers/media/platform/mx2_emmaprp.c b/drivers/media/platform/mx2_emmaprp.c index dab380a..59aaca4 100644 --- a/drivers/media/platform/mx2_emmaprp.c +++ b/drivers/media/platform/mx2_emmaprp.c @@ -757,7 +757,6 @@ static int queue_init(void *priv, struct vb2_queue *src_vq, struct emmaprp_ctx *ctx = priv; int ret; - memset(src_vq, 0, sizeof(*src_vq)); src_vq->type = V4L2_BUF_TYPE_VIDEO_OUTPUT; src_vq->io_modes = VB2_MMAP | VB2_USERPTR; src_vq->drv_priv = ctx; @@ -769,7 +768,6 @@ static int queue_init(void *priv, struct vb2_queue *src_vq, if (ret) return ret; - memset(dst_vq, 0, sizeof(*dst_vq)); dst_vq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE; dst_vq->io_modes = VB2_MMAP | VB2_USERPTR; dst_vq->drv_priv = ctx;
queue_init() is always called by v4l2_m2m_ctx_init(), which allocates a context struct v4l2_m2m_ctx with kzalloc. Therefore, there is no need to clear vb2_queue src/dst structs. Cc: Javier Martin <javier.martin@vista-silicon.com> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com> --- drivers/media/platform/mx2_emmaprp.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)