From patchwork Tue Aug 28 10:53:52 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Zabel X-Patchwork-Id: 1380681 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 514BD3FDF5 for ; Tue, 28 Aug 2012 10:54:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752503Ab2H1Kyg (ORCPT ); Tue, 28 Aug 2012 06:54:36 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:48358 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751747Ab2H1KyL (ORCPT ); Tue, 28 Aug 2012 06:54:11 -0400 Received: from dude.hi.pengutronix.de ([10.1.0.7] helo=dude.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1T6JQt-0003Df-9M; Tue, 28 Aug 2012 12:54:07 +0200 From: Philipp Zabel To: linux-media@vger.kernel.org Cc: Javier Martin , Mauro Carvalho Chehab , Richard Zhao , Laurent Pinchart , Sylwester Nawrocki , Kyungmin Park , Hans Verkuil , kernel@pengutronix.de, Philipp Zabel Subject: [PATCH v2 05/14] media: coda: ignore coda busy status in coda_job_ready Date: Tue, 28 Aug 2012 12:53:52 +0200 Message-Id: <1346151241-10449-6-git-send-email-p.zabel@pengutronix.de> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1346151241-10449-1-git-send-email-p.zabel@pengutronix.de> References: <1346151241-10449-1-git-send-email-p.zabel@pengutronix.de> X-SA-Exim-Connect-IP: 10.1.0.7 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-media@vger.kernel.org Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org job_ready is supposed to signal whether a context is ready to be added to the job queue, not whether the CODA is ready to run it immediately. Calling v4l2_m2m_job_finish at the end of coda_irq_handler already guarantees that the coda is ready when v4l2-mem2mem eventually tries to run the next queued job. Signed-off-by: Philipp Zabel --- drivers/media/video/coda.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/media/video/coda.c b/drivers/media/video/coda.c index cb556d5..9119875 100644 --- a/drivers/media/video/coda.c +++ b/drivers/media/video/coda.c @@ -739,12 +739,6 @@ static int coda_job_ready(void *m2m_priv) return 0; } - if (coda_isbusy(ctx->dev)) { - v4l2_dbg(1, coda_debug, &ctx->dev->v4l2_dev, - "not ready: coda is still busy.\n"); - return 0; - } - v4l2_dbg(1, coda_debug, &ctx->dev->v4l2_dev, "job ready\n"); return 1;