diff mbox

[PATCHv3,9/9] ir-rx51: Add missing quote mark in Kconfig text

Message ID 1346349271-28073-10-git-send-email-timo.t.kokkonen@iki.fi (mailing list archive)
State New, archived
Headers show

Commit Message

Timo Kokkonen Aug. 30, 2012, 5:54 p.m. UTC
This trivial fix cures the following warning message:

drivers/media/rc/Kconfig:275:warning: multi-line strings not supported

Signed-off-by: Timo Kokkonen <timo.t.kokkonen@iki.fi>
---
 drivers/media/rc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sakari Ailus Sept. 1, 2012, 5:16 p.m. UTC | #1
Moi,

On Thu, Aug 30, 2012 at 08:54:31PM +0300, Timo Kokkonen wrote:
> This trivial fix cures the following warning message:
> 
> drivers/media/rc/Kconfig:275:warning: multi-line strings not supported
> 
> Signed-off-by: Timo Kokkonen <timo.t.kokkonen@iki.fi>
> ---
>  drivers/media/rc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig
> index 4a68014..1300655 100644
> --- a/drivers/media/rc/Kconfig
> +++ b/drivers/media/rc/Kconfig
> @@ -272,7 +272,7 @@ config IR_IGUANA
>  	   be called iguanair.
>  
>  config IR_RX51
> -	tristate "Nokia N900 IR transmitter diode
> +	tristate "Nokia N900 IR transmitter diode"
>  	depends on OMAP_DM_TIMER && LIRC
>  	---help---
>  	   Say Y or M here if you want to enable support for the IR

This should be combined with patch 1.
Timo Kokkonen Sept. 2, 2012, 2:57 p.m. UTC | #2
On 09/01/12 20:16, Sakari Ailus wrote:
> Moi,
> 
> On Thu, Aug 30, 2012 at 08:54:31PM +0300, Timo Kokkonen wrote:
>> This trivial fix cures the following warning message:
>>
>> drivers/media/rc/Kconfig:275:warning: multi-line strings not supported
>>
>> Signed-off-by: Timo Kokkonen <timo.t.kokkonen@iki.fi>
>> ---
>>  drivers/media/rc/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig
>> index 4a68014..1300655 100644
>> --- a/drivers/media/rc/Kconfig
>> +++ b/drivers/media/rc/Kconfig
>> @@ -272,7 +272,7 @@ config IR_IGUANA
>>  	   be called iguanair.
>>  
>>  config IR_RX51
>> -	tristate "Nokia N900 IR transmitter diode
>> +	tristate "Nokia N900 IR transmitter diode"
>>  	depends on OMAP_DM_TIMER && LIRC
>>  	---help---
>>  	   Say Y or M here if you want to enable support for the IR
> 
> This should be combined with patch 1.
> 

Actually I'd rather keep the patch 1 as is as it has already a purpose.
Instead, I'd squash this into patch 3 as it already touches the Kconfig
file and it has also the other trivial fixes combined in it.

-Timo

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sakari Ailus Sept. 2, 2012, 8:06 p.m. UTC | #3
On Sun, Sep 02, 2012 at 05:57:25PM +0300, Timo Kokkonen wrote:
> On 09/01/12 20:16, Sakari Ailus wrote:
> > Moi,
> > 
> > On Thu, Aug 30, 2012 at 08:54:31PM +0300, Timo Kokkonen wrote:
> >> This trivial fix cures the following warning message:
> >>
> >> drivers/media/rc/Kconfig:275:warning: multi-line strings not supported
> >>
> >> Signed-off-by: Timo Kokkonen <timo.t.kokkonen@iki.fi>
> >> ---
> >>  drivers/media/rc/Kconfig | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig
> >> index 4a68014..1300655 100644
> >> --- a/drivers/media/rc/Kconfig
> >> +++ b/drivers/media/rc/Kconfig
> >> @@ -272,7 +272,7 @@ config IR_IGUANA
> >>  	   be called iguanair.
> >>  
> >>  config IR_RX51
> >> -	tristate "Nokia N900 IR transmitter diode
> >> +	tristate "Nokia N900 IR transmitter diode"
> >>  	depends on OMAP_DM_TIMER && LIRC
> >>  	---help---
> >>  	   Say Y or M here if you want to enable support for the IR
> > 
> > This should be combined with patch 1.
> > 
> 
> Actually I'd rather keep the patch 1 as is as it has already a purpose.
> Instead, I'd squash this into patch 3 as it already touches the Kconfig
> file and it has also the other trivial fixes combined in it.

Sounds good, that's actually a better place for it.
diff mbox

Patch

diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig
index 4a68014..1300655 100644
--- a/drivers/media/rc/Kconfig
+++ b/drivers/media/rc/Kconfig
@@ -272,7 +272,7 @@  config IR_IGUANA
 	   be called iguanair.
 
 config IR_RX51
-	tristate "Nokia N900 IR transmitter diode
+	tristate "Nokia N900 IR transmitter diode"
 	depends on OMAP_DM_TIMER && LIRC
 	---help---
 	   Say Y or M here if you want to enable support for the IR