diff mbox

[2/2] media v4l2-mem2mem: fix src/out and dst/cap num_rdy

Message ID 1346419084-10879-3-git-send-email-s.hauer@pengutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Sascha Hauer Aug. 31, 2012, 1:18 p.m. UTC
src bufs belong to out queue, dst bufs belong to in queue. Currently
this is not a real problem since all users currently need exactly one
input and one output buffer.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 include/media/v4l2-mem2mem.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Marek Szyprowski Aug. 31, 2012, 6:35 p.m. UTC | #1
Hello,

On 8/31/2012 3:18 PM, Sascha Hauer wrote:
> src bufs belong to out queue, dst bufs belong to in queue. Currently
> this is not a real problem since all users currently need exactly one
> input and one output buffer.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---
>   include/media/v4l2-mem2mem.h |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/media/v4l2-mem2mem.h b/include/media/v4l2-mem2mem.h
> index 16ac473..131cc4a 100644
> --- a/include/media/v4l2-mem2mem.h
> +++ b/include/media/v4l2-mem2mem.h
> @@ -140,7 +140,7 @@ void v4l2_m2m_buf_queue(struct v4l2_m2m_ctx *m2m_ctx, struct vb2_buffer *vb);
>   static inline
>   unsigned int v4l2_m2m_num_src_bufs_ready(struct v4l2_m2m_ctx *m2m_ctx)
>   {
> -	return m2m_ctx->cap_q_ctx.num_rdy;
> +	return m2m_ctx->out_q_ctx.num_rdy;
>   }
>
>   /**
> @@ -150,7 +150,7 @@ unsigned int v4l2_m2m_num_src_bufs_ready(struct v4l2_m2m_ctx *m2m_ctx)
>   static inline
>   unsigned int v4l2_m2m_num_dst_bufs_ready(struct v4l2_m2m_ctx *m2m_ctx)
>   {
> -	return m2m_ctx->out_q_ctx.num_rdy;
> +	return m2m_ctx->cap_q_ctx.num_rdy;
>   }
>
>   void *v4l2_m2m_next_buf(struct v4l2_m2m_queue_ctx *q_ctx);
>


Best regards
Pawel Osciak Sept. 1, 2012, 1:29 a.m. UTC | #2
On Fri, Aug 31, 2012 at 6:18 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> src bufs belong to out queue, dst bufs belong to in queue. Currently
> this is not a real problem since all users currently need exactly one
> input and one output buffer.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---

Acked-by: Pawel Osciak <pawel@osciak.com>

>  include/media/v4l2-mem2mem.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/media/v4l2-mem2mem.h b/include/media/v4l2-mem2mem.h
> index 16ac473..131cc4a 100644
> --- a/include/media/v4l2-mem2mem.h
> +++ b/include/media/v4l2-mem2mem.h
> @@ -140,7 +140,7 @@ void v4l2_m2m_buf_queue(struct v4l2_m2m_ctx *m2m_ctx, struct vb2_buffer *vb);
>  static inline
>  unsigned int v4l2_m2m_num_src_bufs_ready(struct v4l2_m2m_ctx *m2m_ctx)
>  {
> -       return m2m_ctx->cap_q_ctx.num_rdy;
> +       return m2m_ctx->out_q_ctx.num_rdy;
>  }
>
>  /**
> @@ -150,7 +150,7 @@ unsigned int v4l2_m2m_num_src_bufs_ready(struct v4l2_m2m_ctx *m2m_ctx)
>  static inline
>  unsigned int v4l2_m2m_num_dst_bufs_ready(struct v4l2_m2m_ctx *m2m_ctx)
>  {
> -       return m2m_ctx->out_q_ctx.num_rdy;
> +       return m2m_ctx->cap_q_ctx.num_rdy;
>  }
>
>  void *v4l2_m2m_next_buf(struct v4l2_m2m_queue_ctx *q_ctx);
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/media/v4l2-mem2mem.h b/include/media/v4l2-mem2mem.h
index 16ac473..131cc4a 100644
--- a/include/media/v4l2-mem2mem.h
+++ b/include/media/v4l2-mem2mem.h
@@ -140,7 +140,7 @@  void v4l2_m2m_buf_queue(struct v4l2_m2m_ctx *m2m_ctx, struct vb2_buffer *vb);
 static inline
 unsigned int v4l2_m2m_num_src_bufs_ready(struct v4l2_m2m_ctx *m2m_ctx)
 {
-	return m2m_ctx->cap_q_ctx.num_rdy;
+	return m2m_ctx->out_q_ctx.num_rdy;
 }
 
 /**
@@ -150,7 +150,7 @@  unsigned int v4l2_m2m_num_src_bufs_ready(struct v4l2_m2m_ctx *m2m_ctx)
 static inline
 unsigned int v4l2_m2m_num_dst_bufs_ready(struct v4l2_m2m_ctx *m2m_ctx)
 {
-	return m2m_ctx->out_q_ctx.num_rdy;
+	return m2m_ctx->cap_q_ctx.num_rdy;
 }
 
 void *v4l2_m2m_next_buf(struct v4l2_m2m_queue_ctx *q_ctx);