From patchwork Thu Sep 6 15:23:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Senna Tschudin X-Patchwork-Id: 1415911 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 769ECDFFCF for ; Thu, 6 Sep 2012 15:25:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757857Ab2IFPZe (ORCPT ); Thu, 6 Sep 2012 11:25:34 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:49110 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757859Ab2IFPYT (ORCPT ); Thu, 6 Sep 2012 11:24:19 -0400 Received: by mail-wg0-f44.google.com with SMTP id dr13so1754180wgb.1 for ; Thu, 06 Sep 2012 08:24:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=G1mIszfUiXxeqb8uc0f/Pv4YkNYHJDjORtMuIfHtvBU=; b=LD9GVnEm8+mxOc3objd7cMK4QUk1k64/ATfd66eKXUb85b2rSs8S+bJD47+M/1QbRf JzugLMGa8gP7e9FbynWHFtvUVttvrhNg+i/C4is8SZG3vtD3ziVBIjQL+oCJDD1lXL4q Ch5KUAZ6MNo7NX2CK4HUtTuEGdfBYzupZMUPAyXx+aFQ7W3Gt9KlfCmmeUG0YrH40kaM P4fGWxFrIKp6VGB3dpwHwMYeMgPSXS6ZOljj7C6d1gDTyBpRJqUBCSjdu2nr9PKS1Hvq M96G1CiusP3D7eG+hl//eakRgqTtHUaTjPgvp7IP/bHjDjQzJ1RXIjsHcOmblVPveJNc DVKg== Received: by 10.180.84.169 with SMTP id a9mr5621662wiz.8.1346945058484; Thu, 06 Sep 2012 08:24:18 -0700 (PDT) Received: from localhost.localdomain ([132.227.100.38]) by mx.google.com with ESMTPS id el6sm4572331wib.8.2012.09.06.08.24.17 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 06 Sep 2012 08:24:18 -0700 (PDT) From: Peter Senna Tschudin To: Mauro Carvalho Chehab Cc: kernel-janitors@vger.kernel.org, Julia.Lawall@lip6.fr, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/14] drivers/media/platform/blackfin/bfin_capture.c: fix error return code Date: Thu, 6 Sep 2012 17:23:58 +0200 Message-Id: <1346945041-26676-11-git-send-email-peter.senna@gmail.com> X-Mailer: git-send-email 1.7.11.4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // Signed-off-by: Peter Senna Tschudin --- drivers/media/platform/blackfin/bfin_capture.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/platform/blackfin/bfin_capture.c b/drivers/media/platform/blackfin/bfin_capture.c index 1677623..cb2eb26 100644 --- a/drivers/media/platform/blackfin/bfin_capture.c +++ b/drivers/media/platform/blackfin/bfin_capture.c @@ -968,6 +968,7 @@ static int __devinit bcap_probe(struct platform_device *pdev) if (!i2c_adap) { v4l2_err(&bcap_dev->v4l2_dev, "Unable to find i2c adapter\n"); + ret = -ENODEV; goto err_unreg_vdev; }