From patchwork Thu Sep 6 15:24:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Senna Tschudin X-Patchwork-Id: 1415891 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 0BCBADFFCF for ; Thu, 6 Sep 2012 15:25:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757951Ab2IFPYw (ORCPT ); Thu, 6 Sep 2012 11:24:52 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:33245 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757743Ab2IFPYU (ORCPT ); Thu, 6 Sep 2012 11:24:20 -0400 Received: by mail-wi0-f178.google.com with SMTP id hr14so1620841wib.1 for ; Thu, 06 Sep 2012 08:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=GsVoX64LQ31oFnLOD3wx7fhjsX/F0JMe4y6jckM+cvY=; b=Krcw5zG3cuxW/U5Z/7nmu3Ob0yByJKYgKzfjx+F9+pBwlEZIlozfdWW/S4n56dVz65 iVpGJGuXD6B4XORYCZ10cUndp9Wu/8XFm3AykHbXNePUHTFeeaQ+22/uGKi4CRK3ucUI Ud0CFi9Yrz5tjOXwDTlpNFe3+/0A7cwTQHceHDKMj26hoPsZYisPTSOJ9LaC/p40DiFd rhR8EFJ8QZINcHrAzHUa9yXfCYrAwiGvUF3aINtIdGA0upWDoGN+s1GGBQJ+UwGXGLTd WvV6f8THfrpw5Wi+MIOmvuENr2ATj2kvfeZHEYWEPrDZjRDIb7yEUZqDuNKFiZSQDWwe vdiQ== Received: by 10.180.82.39 with SMTP id f7mr5642853wiy.2.1346945059727; Thu, 06 Sep 2012 08:24:19 -0700 (PDT) Received: from localhost.localdomain ([132.227.100.38]) by mx.google.com with ESMTPS id el6sm4572331wib.8.2012.09.06.08.24.19 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 06 Sep 2012 08:24:19 -0700 (PDT) From: Peter Senna Tschudin To: Mauro Carvalho Chehab Cc: kernel-janitors@vger.kernel.org, Julia.Lawall@lip6.fr, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/14] drivers/media/platform/soc_camera/soc_camera.c: fix error return code Date: Thu, 6 Sep 2012 17:24:00 +0200 Message-Id: <1346945041-26676-13-git-send-email-peter.senna@gmail.com> X-Mailer: git-send-email 1.7.11.4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // Signed-off-by: Peter Senna Tschudin --- drivers/media/platform/soc_camera/soc_camera.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers/media/platform/soc_camera/soc_camera.c index 10b57f8..a4beb6c 100644 --- a/drivers/media/platform/soc_camera/soc_camera.c +++ b/drivers/media/platform/soc_camera/soc_camera.c @@ -1184,7 +1184,8 @@ static int soc_camera_probe(struct soc_camera_device *icd) sd->grp_id = soc_camera_grp_id(icd); v4l2_set_subdev_hostdata(sd, icd); - if (v4l2_ctrl_add_handler(&icd->ctrl_handler, sd->ctrl_handler)) + ret = v4l2_ctrl_add_handler(&icd->ctrl_handler, sd->ctrl_handler); + if (ret) goto ectrl; /* At this point client .probe() should have run already */