From patchwork Thu Sep 6 15:23:51 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Senna Tschudin X-Patchwork-Id: 1416031 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id A122E3FC71 for ; Thu, 6 Sep 2012 15:27:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932109Ab2IFP1i (ORCPT ); Thu, 6 Sep 2012 11:27:38 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:62900 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757667Ab2IFPYP (ORCPT ); Thu, 6 Sep 2012 11:24:15 -0400 Received: by wibhi8 with SMTP id hi8so567488wib.1 for ; Thu, 06 Sep 2012 08:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=C27pyUSvQ2xNhFeOJq3fSb1JlggJd4kQsgQ2VwGhGJo=; b=vHsBOv8BrBghzBxViDEqOFLIDtvnzxkQ8GMP9/V6feyt//lnQ8oTeCIS8RJpTKPx3V 8hNAQB5rgbbEYd/i7Lr0DDHUc51bhKuwul3I9GajOQNiH9bbayqbcPwL88AgtUha7fC6 u7UMi47CZUBe4Bd9E9mxtDm1dTqhY32WMUwb+GzA1haN7tEP5TJdq1CzSbHmHPAQSbK5 qEflQ+KK7dJy6OdfQvNrfAi8XCM3zmWsXJT84Ekas9ebviROVj8hc6Vy0Q5br0eTAnH+ hc04d+gG00bjy/Tg6p8DyGRo2NbUzsxz4WNRC6mBTM6zC2nbBQErxMhP7IYo1D6fwCL0 2DNg== Received: by 10.180.108.45 with SMTP id hh13mr46469187wib.15.1346945053655; Thu, 06 Sep 2012 08:24:13 -0700 (PDT) Received: from localhost.localdomain ([132.227.100.38]) by mx.google.com with ESMTPS id el6sm4572331wib.8.2012.09.06.08.24.13 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 06 Sep 2012 08:24:13 -0700 (PDT) From: Peter Senna Tschudin To: Mauro Carvalho Chehab Cc: kernel-janitors@vger.kernel.org, Julia.Lawall@lip6.fr, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/14] drivers/media/i2c/mt9m032.c: fix error return code Date: Thu, 6 Sep 2012 17:23:51 +0200 Message-Id: <1346945041-26676-4-git-send-email-peter.senna@gmail.com> X-Mailer: git-send-email 1.7.11.4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // Signed-off-by: Peter Senna Tschudin --- drivers/media/i2c/mt9m032.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/i2c/mt9m032.c b/drivers/media/i2c/mt9m032.c index 445359c..f80c1d7 100644 --- a/drivers/media/i2c/mt9m032.c +++ b/drivers/media/i2c/mt9m032.c @@ -781,7 +781,7 @@ static int mt9m032_probe(struct i2c_client *client, ret = mt9m032_write(client, MT9M032_RESET, 1); /* reset on */ if (ret < 0) goto error_entity; - mt9m032_write(client, MT9M032_RESET, 0); /* reset off */ + ret = mt9m032_write(client, MT9M032_RESET, 0); /* reset off */ if (ret < 0) goto error_entity;