From patchwork Sun Sep 9 18:02:23 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Frank_Sch=C3=A4fer?= X-Patchwork-Id: 1427921 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id D7853E0000 for ; Sun, 9 Sep 2012 18:02:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754314Ab2IISCa (ORCPT ); Sun, 9 Sep 2012 14:02:30 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:42428 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754330Ab2IISBx (ORCPT ); Sun, 9 Sep 2012 14:01:53 -0400 Received: by mail-ee0-f46.google.com with SMTP id c1so640416eek.19 for ; Sun, 09 Sep 2012 11:01:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=9aFeEWmXi1P1JXapip4NkgSPMhJuCfYimI6AElaP2mQ=; b=VPoLy7J1ETEY4eNc2mLvWwV2OkGErW2MiCVCb/y/M3/Nf99tlHRjjUHcV19k+Y0Caa vrjTQ4hrLaU6IH0eml9cUq4TWi00y02an6W1AhWpm2/yRFuOS5awNdMwXhaE31E/giBU /Q30S6HmSVXkzSUfjsdxsMHY7zhtJsuxkoNXlKUzgijItRGEfK0LuStgNOwdf82GtX94 r5TW5+2+RFJhLBAJM5d/Z6lDicqKuTGtwY+S9OunefHrQSMPG3XKSSTRh1h3JpYphh7O iGW+N7x42fOWACOYfYx3rklQtvHyG98a+FRjwRB4eSa3m6rcqBqiIXTM07i447yX6/2S kOmg== Received: by 10.204.156.73 with SMTP id v9mr3310629bkw.116.1347213712390; Sun, 09 Sep 2012 11:01:52 -0700 (PDT) Received: from localhost.localdomain (ip-176-199-46-78.unitymediagroup.de. [176.199.46.78]) by mx.google.com with ESMTPS id n5sm5475483bkv.14.2012.09.09.11.01.49 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 09 Sep 2012 11:01:51 -0700 (PDT) From: =?UTF-8?q?Frank=20Sch=C3=A4fer?= To: hdegoede@redhat.com Cc: linux-media@vger.kernel.org, =?UTF-8?q?Frank=20Sch=C3=A4fer?= Subject: [PATCH 5/6] gspca_pac7302: avoid duplicate calls of the image quality adjustment functions on capturing start Date: Sun, 9 Sep 2012 20:02:23 +0200 Message-Id: <1347213744-8509-5-git-send-email-fschaefer.oss@googlemail.com> X-Mailer: git-send-email 1.7.7 In-Reply-To: <1347213744-8509-1-git-send-email-fschaefer.oss@googlemail.com> References: <1347213744-8509-1-git-send-email-fschaefer.oss@googlemail.com> MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org There is no need to call the image quality adjustment functions in sd_start. The gspca main driver calls v4l2_ctrl_handler_setup in gspca_init_transfer, which already applies all image control values. Signed-off-by: Frank Schäfer --- drivers/media/usb/gspca/pac7302.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/drivers/media/usb/gspca/pac7302.c b/drivers/media/usb/gspca/pac7302.c index bed34df..71fa5a4 100644 --- a/drivers/media/usb/gspca/pac7302.c +++ b/drivers/media/usb/gspca/pac7302.c @@ -673,14 +673,6 @@ static int sd_start(struct gspca_dev *gspca_dev) reg_w_var(gspca_dev, start_7302, page3_7302, sizeof(page3_7302)); - setbrightcont(gspca_dev); - setcolors(gspca_dev); - setwhitebalance(gspca_dev); - setredbalance(gspca_dev); - setbluebalance(gspca_dev); - setexposure(gspca_dev); - setgain(gspca_dev); - sethvflip(gspca_dev); sd->sof_read = 0; sd->autogain_ignore_frames = 0;