| Message ID | 1347291000-340-6-git-send-email-p.zabel@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 10 September 2012 17:29, Philipp Zabel <p.zabel@pengutronix.de> wrote: > job_ready is supposed to signal whether a context is ready to be > added to the job queue, not whether the CODA is ready to run it > immediately. > Calling v4l2_m2m_job_finish at the end of coda_irq_handler already > guarantees that the coda is ready when v4l2-mem2mem eventually tries > to run the next queued job. > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> > --- > drivers/media/platform/coda.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c > index f4b4a6f..d069787 100644 > --- a/drivers/media/platform/coda.c > +++ b/drivers/media/platform/coda.c > @@ -738,12 +738,6 @@ static int coda_job_ready(void *m2m_priv) > return 0; > } > > - if (coda_isbusy(ctx->dev)) { > - v4l2_dbg(1, coda_debug, &ctx->dev->v4l2_dev, > - "not ready: coda is still busy.\n"); > - return 0; > - } > - > v4l2_dbg(1, coda_debug, &ctx->dev->v4l2_dev, > "job ready\n"); > return 1; > -- > 1.7.10.4 > Tested-by: Javier Martin <javier.martin@vista-silicon.com
diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c index f4b4a6f..d069787 100644 --- a/drivers/media/platform/coda.c +++ b/drivers/media/platform/coda.c @@ -738,12 +738,6 @@ static int coda_job_ready(void *m2m_priv) return 0; } - if (coda_isbusy(ctx->dev)) { - v4l2_dbg(1, coda_debug, &ctx->dev->v4l2_dev, - "not ready: coda is still busy.\n"); - return 0; - } - v4l2_dbg(1, coda_debug, &ctx->dev->v4l2_dev, "job ready\n"); return 1;
job_ready is supposed to signal whether a context is ready to be added to the job queue, not whether the CODA is ready to run it immediately. Calling v4l2_m2m_job_finish at the end of coda_irq_handler already guarantees that the coda is ready when v4l2-mem2mem eventually tries to run the next queued job. Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> --- drivers/media/platform/coda.c | 6 ------ 1 file changed, 6 deletions(-)