From patchwork Wed Sep 12 12:55:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Senna Tschudin X-Patchwork-Id: 1443631 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 1108E4025E for ; Wed, 12 Sep 2012 13:00:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758421Ab2ILM7n (ORCPT ); Wed, 12 Sep 2012 08:59:43 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:38091 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757608Ab2ILM4T (ORCPT ); Wed, 12 Sep 2012 08:56:19 -0400 Received: by wgbdr13 with SMTP id dr13so1485556wgb.1 for ; Wed, 12 Sep 2012 05:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=LZhUr9TrIWGItEa6zqeQVm1bBRlYSceXzr9t4G/p70w=; b=fZg4DY90zi4xnJKWSiExx4yKt4fxsoa0+o4e8QKgqr+bUOx2Bch1NIWlSbyLPIBIrw PCBuen8eHkJzaJfK49XK1wBW9CpaajEVsZm2mx2NpoVTn712FVx6LErtgVXPLnBB0twS aCFVhGxWoqADnib4tKlXJ3splxCvcBq8gAzb2OBrKPs4UK98iljJzJxTLZhN0rRO0tS3 NP9RL8i8rSnHbeWqiABY8Vdi5tQ/HehYViz4Is9y5EksuO6Yr/5nPXPOV4gpd51hXi/k w1fRI/rBZ+iCfpRzwx7DkpL9vYH41ixT1x1DHUMyQuwJ7PgimNoWhmoiZ1oP3kMKuF8T J8NQ== Received: by 10.216.236.163 with SMTP id w35mr12009571weq.13.1347454578105; Wed, 12 Sep 2012 05:56:18 -0700 (PDT) Received: from localhost.localdomain (ppeter.rsr.lip6.fr. [132.227.76.16]) by mx.google.com with ESMTPS id cl8sm7933596wib.10.2012.09.12.05.56.16 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 12 Sep 2012 05:56:17 -0700 (PDT) From: Peter Senna Tschudin To: Mauro Carvalho Chehab Cc: kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 7/8] drivers/media/platform/davinci/vpbe.c: Removes useless kfree() Date: Wed, 12 Sep 2012 14:55:58 +0200 Message-Id: <1347454564-5178-2-git-send-email-peter.senna@gmail.com> X-Mailer: git-send-email 1.7.11.4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Peter Senna Tschudin Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged exists@ position r.p1,r.p2; expression e <= r.x,x,e1; iterator I; statement S; @@ if (x@p1 == NULL) { ... when != I(x,...) S when != e = e1 when != e += e1 when != e -= e1 when != ++e when != --e when != e++ when != e-- when != &e kfree@p2(x); ... return ...; } @ok depends on unchanged exists@ position any r.p1; position r.p2; expression x; @@ ... when != true x@p1 == NULL kfree@p2(x); @depends on !ok && unchanged@ position r.p2; expression x; @@ *kfree@p2(x); // Signed-off-by: Peter Senna Tschudin --- drivers/media/platform/davinci/vpbe.c | 1 - 1 file changed, 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c index c4a82a1..1125a87 100644 --- a/drivers/media/platform/davinci/vpbe.c +++ b/drivers/media/platform/davinci/vpbe.c @@ -771,7 +771,6 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev) return 0; vpbe_fail_amp_register: - kfree(vpbe_dev->amp); vpbe_fail_sd_register: kfree(vpbe_dev->encoders); vpbe_fail_v4l2_device: