From patchwork Mon Sep 17 13:47:38 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 1467211 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 2C4BBDF2D8 for ; Mon, 17 Sep 2012 13:47:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753775Ab2IQNrq (ORCPT ); Mon, 17 Sep 2012 09:47:46 -0400 Received: from mail-gg0-f174.google.com ([209.85.161.174]:54366 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752532Ab2IQNrp (ORCPT ); Mon, 17 Sep 2012 09:47:45 -0400 Received: by ggdk6 with SMTP id k6so1433998ggd.19 for ; Mon, 17 Sep 2012 06:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=7pASU3Misyyw2SxgrP18b4aLkDBsTNDd5SjM2MruA9c=; b=cNdKoFrWqR0PLGZuNiIEMg1vh8JxZDson+OD1V5hzx94x+MRcWelAJ4kR7HxTMJZj+ jUQU3eU6eSVNyjjIL3Ei06uCkRZWI23cMBSzBrQYu96vfifZCAGih/yHUA8J3e4DiKmp MnQS4TiQq37mknNFsOtMoRmTQsxVwf9oTB0MPDHDq5QrNY6O0WDQBzLDcXbY02XoDziA umG6ZVP7qUnFgLadwahD38l2UXUUfbAhSZOAqQl61WLRpd//E8wWKl/EhCHB0aI3gBpd TpnBJrnUcd3ZhTnzU3pKjbWtxZ+4N97gQewkHW1EUpuc/Nz1PHq8fxwfUNWLFRReiDg2 0dTg== Received: by 10.100.236.40 with SMTP id j40mr3570157anh.19.1347889664567; Mon, 17 Sep 2012 06:47:44 -0700 (PDT) Received: from localhost.cpe.express.com.ar ([200.81.126.15]) by mx.google.com with ESMTPS id k22sm9119695ann.1.2012.09.17.06.47.41 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 17 Sep 2012 06:47:43 -0700 (PDT) From: elezegarcia@gmail.com To: Mauro Carvalho Chehab , Cc: Ezequiel Garcia , Hans de Goede Subject: [PATCH 2/4] pwc: Add return code check at vb2_queue_init() Date: Mon, 17 Sep 2012 10:47:38 -0300 Message-Id: <1347889658-15116-1-git-send-email-elezegarcia@gmail.com> X-Mailer: git-send-email 1.7.8.6 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Ezequiel Garcia This function returns an integer and it's mandatory to check the return code. Cc: Hans de Goede Signed-off-by: Ezequiel Garcia --- drivers/media/usb/pwc/pwc-if.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/media/usb/pwc/pwc-if.c b/drivers/media/usb/pwc/pwc-if.c index 42e36ba..31d082e 100644 --- a/drivers/media/usb/pwc/pwc-if.c +++ b/drivers/media/usb/pwc/pwc-if.c @@ -1000,7 +1000,9 @@ static int usb_pwc_probe(struct usb_interface *intf, const struct usb_device_id pdev->vb_queue.buf_struct_size = sizeof(struct pwc_frame_buf); pdev->vb_queue.ops = &pwc_vb_queue_ops; pdev->vb_queue.mem_ops = &vb2_vmalloc_memops; - vb2_queue_init(&pdev->vb_queue); + rc = vb2_queue_init(&pdev->vb_queue); + if (rc) + goto err_free_mem; /* Init video_device structure */ memcpy(&pdev->vdev, &pwc_template, sizeof(pwc_template));