From patchwork Mon Sep 17 13:49:38 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 1467221 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 744113FCFC for ; Mon, 17 Sep 2012 13:49:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753878Ab2IQNtm (ORCPT ); Mon, 17 Sep 2012 09:49:42 -0400 Received: from mail-gg0-f174.google.com ([209.85.161.174]:63906 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753478Ab2IQNtl (ORCPT ); Mon, 17 Sep 2012 09:49:41 -0400 Received: by ggdk6 with SMTP id k6so1434646ggd.19 for ; Mon, 17 Sep 2012 06:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=MKM46G40pxaqmaTfbmFR7RhtaYTX2hzw2JJ45ABsEGo=; b=z88PTQ0Hy7ubfpqYAq8FGX90BgGPhJKlqygvl0SunJzgwhfM+si/yEM4ehRs65I50B sPoMV7K6JeZ7/eP/JUnAvTBtXCP/qK7n+yaaMoYjgC3Kr/eLDryln7UyjzyPKKpssBzj kwRKsxDSsSmoF+4Da/CRmVefTryQ3X4mPZusYf+sNdzKc4+e4G7XzBLrVWDfDY5yfOKB 1srZu5/mCZnAfG52Y4M435GFC1hN/+MNxB/vN8XeX2Dhn084WfYm6Mvr7rKjnM0boYpE cWroAtkWDcvv+hTDcnwjQ39bZ7DGKonasaG61LAkTb5Y8iVh83AFbgYh2vIsb3Ec1aEt r5Ug== Received: by 10.236.144.225 with SMTP id n61mr4585660yhj.119.1347889781132; Mon, 17 Sep 2012 06:49:41 -0700 (PDT) Received: from localhost.cpe.express.com.ar ([200.81.126.15]) by mx.google.com with ESMTPS id d66sm14155860yhe.1.2012.09.17.06.49.38 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 17 Sep 2012 06:49:39 -0700 (PDT) From: Ezequiel Garcia To: Mauro Carvalho Chehab , Cc: Ezequiel Garcia Subject: [PATCH 3/4] vivi: Add return code check at vb2_queue_init() Date: Mon, 17 Sep 2012 10:49:38 -0300 Message-Id: <1347889778-15152-1-git-send-email-elezegarcia@gmail.com> X-Mailer: git-send-email 1.7.8.6 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This function returns an integer and it's mandatory to check the return code. Signed-off-by: Ezequiel Garcia --- drivers/media/platform/vivi.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/vivi.c b/drivers/media/platform/vivi.c index fca8019..c1401dd 100644 --- a/drivers/media/platform/vivi.c +++ b/drivers/media/platform/vivi.c @@ -1313,7 +1313,9 @@ static int __init vivi_create_instance(int inst) q->ops = &vivi_video_qops; q->mem_ops = &vb2_vmalloc_memops; - vb2_queue_init(q); + ret = vb2_queue_init(q); + if (ret) + goto unreg_dev; mutex_init(&dev->mutex);