From patchwork Mon Sep 24 06:17:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 1496231 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 80CB8DF280 for ; Mon, 24 Sep 2012 06:21:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754915Ab2IXGV0 (ORCPT ); Mon, 24 Sep 2012 02:21:26 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:39008 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754107Ab2IXGVZ (ORCPT ); Mon, 24 Sep 2012 02:21:25 -0400 Received: by pbbrr4 with SMTP id rr4so6542460pbb.19 for ; Sun, 23 Sep 2012 23:21:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=v9s5YzhW/scqNAJ0VQ4QYkWk4bQGyvua9pYj0n4xlgg=; b=RHcUCzVApdXNSpO8seNVm1ZebXrCI8Y4JW6Y62Z4zE9fKu1nom0svJlD4tDTrdl3jO HeNg7xjCXT1IniZ27bTYo2cDjMi2YMeOv/nzAyaSv+SFii9YbrduiQvuVLpipjr1gSLn 8FEwY4ok1K8/nfQKOQurmpNk5STOvKwSWuQb0o6Z22nWzFffOrOsGUaNZobsouIoTw7X sTSbaaN8ehjAtsWCF7n6pnI8ydEfnLaANIyohlyc3KcDQh9WmY4g39w2z2XTX9aOnlcR yLS4pMmPa61wQmwfrRSN1A47N1W58Kcwp4mb4XtCtqwrt6XAWNVG4YA/Zllp8JZyEKoP Incg== Received: by 10.68.203.230 with SMTP id kt6mr33687787pbc.163.1348467685164; Sun, 23 Sep 2012 23:21:25 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id ho7sm9161024pbc.3.2012.09.23.23.21.22 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 23 Sep 2012 23:21:24 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: mchehab@infradead.org, sachin.kamat@linaro.org, m.szyprowski@samsung.com, pawel@osciak.com, patches@linaro.org Subject: [PATCH 1/4] [media] mem2mem_testdev: Fix incorrect location of v4l2_m2m_release() Date: Mon, 24 Sep 2012 11:47:45 +0530 Message-Id: <1348467468-19854-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQmLdUYgnZ5Q9ce7+dUn22oRId1eF9F1VZC+xpEG2O2wWm+5IFxbxkn4k6TaanF3IswwDfUn Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org v4l2_m2m_release() was placed after the return statement and outside any of the goto labels and hence was not getting executed under the error exit path. This patch moves it under the exit path label. Signed-off-by: Sachin Kamat Acked-by: Marek Szyprowski --- drivers/media/platform/mem2mem_testdev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/mem2mem_testdev.c b/drivers/media/platform/mem2mem_testdev.c index 771a84f..fc95559 100644 --- a/drivers/media/platform/mem2mem_testdev.c +++ b/drivers/media/platform/mem2mem_testdev.c @@ -1067,8 +1067,8 @@ static int m2mtest_probe(struct platform_device *pdev) return 0; - v4l2_m2m_release(dev->m2m_dev); err_m2m: + v4l2_m2m_release(dev->m2m_dev); video_unregister_device(dev->vfd); rel_vdev: video_device_release(vfd);