From patchwork Mon Sep 24 11:26:24 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 1497431 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 916843FC71 for ; Mon, 24 Sep 2012 11:30:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754105Ab2IXLaE (ORCPT ); Mon, 24 Sep 2012 07:30:04 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:53648 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753777Ab2IXLaC (ORCPT ); Mon, 24 Sep 2012 07:30:02 -0400 Received: by padhz1 with SMTP id hz1so860987pad.19 for ; Mon, 24 Sep 2012 04:30:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=vO7NZ28AXs/OMQwaIyIXmFjauAOK+IXM5TPKpwk+W88=; b=Pjgp7iOHV/mXVDrwoojtwLMJYFhJQVZc5wJwnOsRnDI5Jo7pTU/MRexxMHLKggEG32 iC7OSTok38paOsHuDZJORFoVuMIKuZZS/yQI0xe6QT0rvw+xsHxo0zQ4HbUgcgpuTr26 26UslKePpsttOzW/+LEF9XFP9u6ozzI86XOu4T93sJj4kOXGCAnpzUyReOUZB4PUfJEo JvRyXkGWd+1gejBBh/esKOfQ15NznKapX2p5lUc3LOV3l3aidXMCB9kC8FKTZPtTU7DY fBcl1UsCR5nuKKqaYvQdtnbyWnBLBXEW7Lf6qlHVAoFCZhSpGBytuOONlOl4FsqCQE3c KuzQ== Received: by 10.68.237.38 with SMTP id uz6mr36479238pbc.23.1348486202506; Mon, 24 Sep 2012 04:30:02 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id gk5sm723831pbc.21.2012.09.24.04.29.59 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 24 Sep 2012 04:30:01 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: mchehab@infradead.org, laurent.pinchart@ideasonboard.com, sakari.ailus@iki.fi, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH] [media] media-devnode: Replace printk with pr_* Date: Mon, 24 Sep 2012 16:56:24 +0530 Message-Id: <1348485984-22198-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQknNTikcMptjuBsVdWiq9eTTr8s/mF9jP47x3rmWXu6KjwYu1Q0QLA/qnFQzgliaOh3WpVx Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Fixes checkpatch warnings related to printk. Signed-off-by: Sachin Kamat Acked-by: Sakari Ailus Acked-by: Laurent Pinchart --- drivers/media/media-devnode.c | 14 ++++++++------ 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/media/media-devnode.c b/drivers/media/media-devnode.c index f6b52d5..023b2a1 100644 --- a/drivers/media/media-devnode.c +++ b/drivers/media/media-devnode.c @@ -30,6 +30,8 @@ * counting. */ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + #include #include #include @@ -215,7 +217,7 @@ int __must_check media_devnode_register(struct media_devnode *mdev) minor = find_next_zero_bit(media_devnode_nums, MEDIA_NUM_DEVICES, 0); if (minor == MEDIA_NUM_DEVICES) { mutex_unlock(&media_devnode_lock); - printk(KERN_ERR "could not get a free minor\n"); + pr_err("could not get a free minor\n"); return -ENFILE; } @@ -230,7 +232,7 @@ int __must_check media_devnode_register(struct media_devnode *mdev) ret = cdev_add(&mdev->cdev, MKDEV(MAJOR(media_dev_t), mdev->minor), 1); if (ret < 0) { - printk(KERN_ERR "%s: cdev_add failed\n", __func__); + pr_err("%s: cdev_add failed\n", __func__); goto error; } @@ -243,7 +245,7 @@ int __must_check media_devnode_register(struct media_devnode *mdev) dev_set_name(&mdev->dev, "media%d", mdev->minor); ret = device_register(&mdev->dev); if (ret < 0) { - printk(KERN_ERR "%s: device_register failed\n", __func__); + pr_err("%s: device_register failed\n", __func__); goto error; } @@ -287,18 +289,18 @@ static int __init media_devnode_init(void) { int ret; - printk(KERN_INFO "Linux media interface: v0.10\n"); + pr_info("Linux media interface: v0.10\n"); ret = alloc_chrdev_region(&media_dev_t, 0, MEDIA_NUM_DEVICES, MEDIA_NAME); if (ret < 0) { - printk(KERN_WARNING "media: unable to allocate major\n"); + pr_warn("unable to allocate major\n"); return ret; } ret = bus_register(&media_bus_type); if (ret < 0) { unregister_chrdev_region(media_dev_t, MEDIA_NUM_DEVICES); - printk(KERN_WARNING "media: bus_register failed\n"); + pr_warn("bus_register failed\n"); return -EIO; }