From patchwork Thu Sep 27 14:07:30 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guennadi Liakhovetski X-Patchwork-Id: 1514491 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id D2F1D3FE1C for ; Thu, 27 Sep 2012 14:08:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753278Ab2I0OHr (ORCPT ); Thu, 27 Sep 2012 10:07:47 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:51041 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752581Ab2I0OHo (ORCPT ); Thu, 27 Sep 2012 10:07:44 -0400 Received: from axis700.grange (dslb-178-001-228-192.pools.arcor-ip.net [178.1.228.192]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0LuHCt-1TPrR93btP-011GOI; Thu, 27 Sep 2012 16:07:37 +0200 Received: from 6a.grange (6a.grange [192.168.1.11]) by axis700.grange (Postfix) with ESMTPS id E652E189B89; Thu, 27 Sep 2012 16:07:34 +0200 (CEST) Received: from lyakh by 6a.grange with local (Exim 4.72) (envelope-from ) id 1THEkY-0007Sb-G2; Thu, 27 Sep 2012 16:07:34 +0200 From: Guennadi Liakhovetski To: linux-media@vger.kernel.org Cc: devicetree-discuss@lists.ozlabs.org, Sylwester Nawrocki , Laurent Pinchart , Hans Verkuil , Magnus Damm , linux-sh@vger.kernel.org, Mark Brown , Stephen Warren , Arnd Bergmann , Grant Likely Subject: [PATCH 11/14] media: sh-mobile-ceu-camera: runtime PM suspending doesn't have to be synchronous Date: Thu, 27 Sep 2012 16:07:30 +0200 Message-Id: <1348754853-28619-12-git-send-email-g.liakhovetski@gmx.de> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1348754853-28619-1-git-send-email-g.liakhovetski@gmx.de> References: <1348754853-28619-1-git-send-email-g.liakhovetski@gmx.de> X-Provags-ID: V02:K0:Yj+WJ6IuXaNTiuBeGZQM7W+sA8iIuYwdA61Oy/jBZDF vp6ckUUtnAIZwMccvLP4v3+bqZ6wzHVoV2tVGChCoct5LJRydw gF2VQ+EVdrZTWdN2y/ZS/+b/563O7xTbgk5ZfV1sLVH1BokFcW P2TTnE5CbwdEoZRmKa9XOmdvb8YEOr2cdsDn5Gw+2gXC4OKsPt dod80vsbkaD9KYYz9J/vmIth9nBbfOU1E5REp9LXhJfAEuHRKq giXgQYyf2TRudvSl2Yg6hHUKSCvaeUhBgcvBjBQc+9AGKekmig 50PUtEtQtkuWCUdmY00q2rr3eBdncjK72ExNALF6Ddx6mBaYm0 qYFMiRbccuEEhkTnoDHXqBW7bn3Hj9Y//vfMYD5B/8jSKs/NUP kY6AeR55ZIwc/BchSRPiVBGzdf5rqUu7ik= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org In both error and clean up cases there is no need to wait for runtime PM to finish suspending the device. Signed-off-by: Guennadi Liakhovetski --- .../platform/soc_camera/sh_mobile_ceu_camera.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c b/drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c index 0a24253..41e4664 100644 --- a/drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c +++ b/drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c @@ -572,7 +572,7 @@ static int sh_mobile_ceu_add_device(struct soc_camera_device *icd) ret = v4l2_subdev_call(csi2_sd, core, s_power, 1); if (ret < 0 && ret != -ENOIOCTLCMD && ret != -ENODEV) { - pm_runtime_put_sync(ici->v4l2_dev.dev); + pm_runtime_put(ici->v4l2_dev.dev); return ret; } @@ -612,7 +612,7 @@ static void sh_mobile_ceu_remove_device(struct soc_camera_device *icd) } spin_unlock_irq(&pcdev->lock); - pm_runtime_put_sync(ici->v4l2_dev.dev); + pm_runtime_put(ici->v4l2_dev.dev); dev_info(icd->parent, "SuperH Mobile CEU driver detached from camera %d\n",