From patchwork Fri Sep 28 12:47:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guennadi Liakhovetski X-Patchwork-Id: 1519071 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 823E13FE80 for ; Fri, 28 Sep 2012 12:47:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757365Ab2I1MrJ (ORCPT ); Fri, 28 Sep 2012 08:47:09 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:60513 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754836Ab2I1MrG (ORCPT ); Fri, 28 Sep 2012 08:47:06 -0400 Received: from axis700.grange (dslb-178-001-143-176.pools.arcor-ip.net [178.1.143.176]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0MgHB8-1T3sZr0TBu-00O9TK; Fri, 28 Sep 2012 14:47:05 +0200 Received: from 6a.grange (6a.grange [192.168.1.11]) by axis700.grange (Postfix) with ESMTPS id 7DC6F189B0F; Fri, 28 Sep 2012 14:47:04 +0200 (CEST) Received: from lyakh by 6a.grange with local (Exim 4.72) (envelope-from ) id 1THZyC-0001EG-AT; Fri, 28 Sep 2012 14:47:04 +0200 From: Guennadi Liakhovetski To: linux-media@vger.kernel.org Cc: Hans Verkuil Subject: [PATCH 4/7] media: mx3_camera: fix const cropping related warnings Date: Fri, 28 Sep 2012 14:47:00 +0200 Message-Id: <1348836424-4672-5-git-send-email-g.liakhovetski@gmx.de> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1348836424-4672-1-git-send-email-g.liakhovetski@gmx.de> References: <1348836424-4672-1-git-send-email-g.liakhovetski@gmx.de> X-Provags-ID: V02:K0:J+rJmsnWoPCFXrCT9vZiYjYmnWc9QvMqG93ozS94a5o 7J6dmq9thk2JLzbGT+b80U/WytmtAMe3XQXJDjnDfCC08AL8S7 aCg7XFxQIL130ZZZ+Oe+Weg0fL15i/93X1axyukAqNlH6wR1GE LlMhMBYyNezztlrmuiPzSQ3o/LeBrN9NxflRMJGJOvYgUDzZZw iugHU2prAhriSAP1zkhqBB9WziP0JrYW3Mu7f4dt6VKOpQSPaz GBI0RX16zi7ealspwImHxGBdwdMf/wztBa3YcMrR6D6E4egACr 54w3KQBfqDEfHU2KQcIAUNITFMQQOohs6jQGtz1zUo8T7v8eyf 6BqNEQ/YC+elXpoIvCf7HpdPhWHipSlb2Xa/I73FcVtc2KOjXB 8u4N65qPidcdw== Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org A recent commit "[media] v4l2: make vidioc_s_crop const" introduced warnings in mx3_camera. Fix them by cleanly separating writable and read-only variables in cropping operations. Signed-off-by: Guennadi Liakhovetski --- drivers/media/platform/soc_camera/mx3_camera.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/soc_camera/mx3_camera.c b/drivers/media/platform/soc_camera/mx3_camera.c index 16975c6..968b6d7 100644 --- a/drivers/media/platform/soc_camera/mx3_camera.c +++ b/drivers/media/platform/soc_camera/mx3_camera.c @@ -799,9 +799,10 @@ static inline void stride_align(__u32 *width) * default g_crop and cropcap from soc_camera.c */ static int mx3_camera_set_crop(struct soc_camera_device *icd, - struct v4l2_crop *a) + const struct v4l2_crop *a) { - struct v4l2_rect *rect = &a->c; + struct v4l2_crop a_writable = *a; + struct v4l2_rect *rect = &a_writable.c; struct soc_camera_host *ici = to_soc_camera_host(icd->parent); struct mx3_camera_dev *mx3_cam = ici->priv; struct v4l2_subdev *sd = soc_camera_to_subdev(icd);