From patchwork Fri Sep 28 12:47:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guennadi Liakhovetski X-Patchwork-Id: 1519101 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 3843A3FE80 for ; Fri, 28 Sep 2012 12:47:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757572Ab2I1MrT (ORCPT ); Fri, 28 Sep 2012 08:47:19 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:51056 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756195Ab2I1MrI (ORCPT ); Fri, 28 Sep 2012 08:47:08 -0400 Received: from axis700.grange (dslb-178-001-143-176.pools.arcor-ip.net [178.1.143.176]) by mrelayeu.kundenserver.de (node=mrbap3) with ESMTP (Nemesis) id 0Lucpk-1TQLQf08W0-00zkCV; Fri, 28 Sep 2012 14:47:05 +0200 Received: from 6a.grange (6a.grange [192.168.1.11]) by axis700.grange (Postfix) with ESMTPS id 8905D189B12; Fri, 28 Sep 2012 14:47:04 +0200 (CEST) Received: from lyakh by 6a.grange with local (Exim 4.72) (envelope-from ) id 1THZyC-0001EJ-Bw; Fri, 28 Sep 2012 14:47:04 +0200 From: Guennadi Liakhovetski To: linux-media@vger.kernel.org Cc: Hans Verkuil Subject: [PATCH 5/7] media: mx2_camera: fix const cropping related warnings Date: Fri, 28 Sep 2012 14:47:01 +0200 Message-Id: <1348836424-4672-6-git-send-email-g.liakhovetski@gmx.de> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1348836424-4672-1-git-send-email-g.liakhovetski@gmx.de> References: <1348836424-4672-1-git-send-email-g.liakhovetski@gmx.de> X-Provags-ID: V02:K0:kI/wiA56Hwn9HYCOlc7fPrdJts4PqydjNqbviMH/dvq 3P3bKX7C/+j7K1drViMw+w+fJg8ATtEInRu0SegraqFg5KRER4 Nj2nZ9Xq/sck0xWWRZLIMZIhgC5L9g9evlDZYv3vlYPOQfaeva K3w4VhrYeUe/JSlO/tNgVo18pMTR5eHI/cGqWK56GpiN8iW4wy DmysddNEmsUQ0GCJ654tk/7XiVHZbgoUiwtwGFuPzZz22iJPsI vlx1WV6X4MrpvlaxIRw/uTfj0u7NKzPZBe3t5bANkTOLqwy6Sw Eu/sywnVvhLJ56Igd0OQ9MetfeRjbse1JutWntRdCOmwQmYe2c 9kh+YwiLS9+vQbQURxC22rD7tIHLrPfvVEaFwT4Ifs+Gk/p4wl YZMgKuiZrNSpw== Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org A recent commit "[media] v4l2: make vidioc_s_crop const" introduced warnings in mx2_camera. Fix them by cleanly separating writable and read-only variables in cropping operations. Signed-off-by: Guennadi Liakhovetski --- drivers/media/platform/soc_camera/mx2_camera.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/soc_camera/mx2_camera.c b/drivers/media/platform/soc_camera/mx2_camera.c index 29758b0..0854f83 100644 --- a/drivers/media/platform/soc_camera/mx2_camera.c +++ b/drivers/media/platform/soc_camera/mx2_camera.c @@ -1104,9 +1104,10 @@ static int mx2_camera_set_bus_param(struct soc_camera_device *icd) } static int mx2_camera_set_crop(struct soc_camera_device *icd, - struct v4l2_crop *a) + const struct v4l2_crop *a) { - struct v4l2_rect *rect = &a->c; + struct v4l2_crop a_writable = *a; + struct v4l2_rect *rect = &a_writable.c; struct v4l2_subdev *sd = soc_camera_to_subdev(icd); struct v4l2_mbus_framefmt mf; int ret;