From patchwork Thu Oct 4 15:42:41 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rahul Sharma X-Patchwork-Id: 1544951 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 39DA640AC9 for ; Thu, 4 Oct 2012 07:24:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752749Ab2JDHYm (ORCPT ); Thu, 4 Oct 2012 03:24:42 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:34547 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752593Ab2JDHYl (ORCPT ); Thu, 4 Oct 2012 03:24:41 -0400 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MBC00AFWXWZED70@mailout3.samsung.com> for linux-media@vger.kernel.org; Thu, 04 Oct 2012 16:24:39 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.125]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id BA.49.03860.7B93D605; Thu, 04 Oct 2012 16:24:39 +0900 (KST) X-AuditID: cbfee61b-b7f2b6d000000f14-de-506d39b736ed Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 99.49.03860.7B93D605; Thu, 04 Oct 2012 16:24:39 +0900 (KST) Received: from localhost.localdomain ([107.108.73.106]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MBC006I9XWMLU10@mmp2.samsung.com> for linux-media@vger.kernel.org; Thu, 04 Oct 2012 16:24:39 +0900 (KST) From: Rahul Sharma To: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Cc: t.stanislaws@samsung.com, inki.dae@samsung.com, kyungmin.park@samsung.com, joshi@samsung.com Subject: [PATCH v1 03/14] drm: exynos: hdmi: fix interrupt handling Date: Thu, 04 Oct 2012 21:12:41 +0530 Message-id: <1349365372-21417-4-git-send-email-rahul.sharma@samsung.com> X-Mailer: git-send-email 1.7.0.4 In-reply-to: <1349365372-21417-1-git-send-email-rahul.sharma@samsung.com> References: <1349365372-21417-1-git-send-email-rahul.sharma@samsung.com> DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJLMWRmVeSWpSXmKPExsWyRsSkVne7ZW6AwYqLhhY9G7ayOjB6fN4k F8AYxWWTkpqTWZZapG+XwJWx7vM6xoI3HBX/H7axNjCuY+9i5OSQEDCRuPzkCRuELSZx4d56 IJuLQ0hgKaPEnlkrWGGKNq96xw6RmM4oMfnlDChnOZPEw45/LCBVbAK6ErMPPmMEsUUEXCW2 brkJZjMLJEl8/zmJCcQWFnCWuHO/FayeRUBV4uLnBqA4BwevgIfE9wmSEMsUJFqXHWIHCXMK eEoc+ZkIEhYCqpj0oYMVolNA4tvkQywgJRICshKbDjBDdF5mk7izPRjClpQ4uOIGywRG4QWM DKsYRVMLkguKk9JzjfSKE3OLS/PS9ZLzczcxAsPv9L9n0jsYVzVYHGIU4GBU4uG1mJQTIMSa WFZcmXuIUYKDWUmEd7NiboAQb0piZVVqUX58UWlOavEhRh+gQyYyS4km5wNjI68k3tDYxNzU 2NTSyMjM1BSHsJI4b7NHSoCQQHpiSWp2ampBahHMOCYOTqkGxozl7Wv7Wg5raRXsk5vbbfhI v8O0dOHrrqi9LkKL/K8c/nSSb12mXPymz3/E3ota/dBj6t8cae8k33Un79dDzafCGb4OaZoL lrWdX5S269DLc/tn+6bknd2otNGCz2nuo+zC8/F1l7Zznl+77bQsl7RX2McDYT95UgS2Rf9d ovz1/9P1Hu9+7FNiKc5INNRiLipOBACny8ujbAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkkeLIzCtJLcpLzFFi42I5/e+xoO52y9wAg3UdqhY9G7ayOjB6fN4k F8AY1cBok5GamJJapJCal5yfkpmXbqvkHRzvHG9qZmCoa2hpYa6kkJeYm2qr5OIToOuWmQM0 VUmhLDGnFCgUkFhcrKRvh2lCaIibrgVMY4Sub0gQXI+RARpIWMOYse7zOsaCNxwV/x+2sTYw rmPvYuTkkBAwkdi86h2ULSZx4d56ti5GLg4hgemMEpNfzmCHcJYzSTzs+McCUsUmoCsx++Az RhBbRMBVYuuWm2A2s0CSxPefk5hAbGEBZ4k791vB6lkEVCUufm4AinNw8Ap4SHyfIAmxTEGi ddkhdpAwp4CnxJGfiSBhIaCKSR86WCcw8i5gZFjFKJpakFxQnJSea6RXnJhbXJqXrpecn7uJ ERzez6R3MK5qsDjEKMDBqMTDazEpJ0CINbGsuDL3EKMEB7OSCO9mxdwAId6UxMqq1KL8+KLS nNTiQ4w+QDdNZJYSTc4Hxl5eSbyhsYm5qbGppYmFiZklDmElcd5mj5QAIYH0xJLU7NTUgtQi mHFMHJxSDYxbdOcaH1gx571WwsXtRYXfBDU3bJl5PPfvtg/qqazzXJRaTpRvr2xQb4jxWHW2 yE/oU7pL2L/GgiuyGWUVnqIqgRu7zp96e/ngudjZ65Zsuc/Q4BC34JHt9e2X2P73fTgasNTy zPLw9TJz00REYj/NuHvd8vLjw9t8d3P6XBGQeMpxr8iA92ikEktxRqKhFnNRcSIAO1XyC5wC AAA= X-CFilter-Loop: Reflected Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Tomasz Stanislawski This patch fixes 'unsigned < 0' check in probe. Moreover it releases an interrupt at remove. Signed-off-by: Tomasz Stanislawski Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index b3a802b..3902917 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -64,8 +64,8 @@ struct hdmi_context { struct mutex hdmi_mutex; void __iomem *regs; - unsigned int external_irq; - unsigned int internal_irq; + int external_irq; + int internal_irq; struct i2c_client *ddc_port; struct i2c_client *hdmiphy_port; @@ -2424,6 +2424,7 @@ static int __devexit hdmi_remove(struct platform_device *pdev) pm_runtime_disable(dev); free_irq(hdata->internal_irq, hdata); + free_irq(hdata->external_irq, hdata); hdmi_resources_cleanup(hdata);