diff mbox

[v4l-utils] Use RCC variable to call rcc compiler

Message ID 1349635312-3045-1-git-send-email-raj.khem@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Khem Raj Oct. 7, 2012, 6:41 p.m. UTC
In cross compile environment rcc native version
may be staged in a different directory or even
called rcc4 or somesuch. Lets provide a facility
to specify it in environment

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 utils/qv4l2/Makefile.am |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gregor Jasny Oct. 8, 2012, 6:26 a.m. UTC | #1
Hello Khem,

On 10/7/12 8:41 PM, Khem Raj wrote:
> In cross compile environment rcc native version
> may be staged in a different directory or even
> called rcc4 or somesuch. Lets provide a facility
> to specify it in environment

I'll take care of this patch.

> diff --git a/utils/qv4l2/Makefile.am b/utils/qv4l2/Makefile.am
> index 02d0bcb..86d0285 100644
> --- a/utils/qv4l2/Makefile.am
> +++ b/utils/qv4l2/Makefile.am
> @@ -29,7 +29,7 @@ moc_capture-win.cpp: $(srcdir)/capture-win.h
>  
>  # Call the Qt resource compiler
>  qrc_qv4l2.cpp: $(srcdir)/qv4l2.qrc
> -	rcc -name qv4l2 -o $@ $(srcdir)/qv4l2.qrc
> +	$(RCC) -name qv4l2 -o $@ $(srcdir)/qv4l2.qrc
>  
>  install-data-local:
>  	$(INSTALL_DATA) -D -p "$(srcdir)/qv4l2.desktop"   "$(DESTDIR)$(datadir)/applications/qv4l2.desktop"
> 

Where does RCC gets populated? The configure.ac parts seems to be missing.

Thanks,
Gregor
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Khem Raj Oct. 8, 2012, 1:50 p.m. UTC | #2
On Sun, Oct 7, 2012 at 11:26 PM, Gregor Jasny <gjasny@googlemail.com> wrote:
> Hello Khem,
>
> On 10/7/12 8:41 PM, Khem Raj wrote:
>> In cross compile environment rcc native version
>> may be staged in a different directory or even
>> called rcc4 or somesuch. Lets provide a facility
>> to specify it in environment
>
> I'll take care of this patch.
>
>> diff --git a/utils/qv4l2/Makefile.am b/utils/qv4l2/Makefile.am
>> index 02d0bcb..86d0285 100644
>> --- a/utils/qv4l2/Makefile.am
>> +++ b/utils/qv4l2/Makefile.am
>> @@ -29,7 +29,7 @@ moc_capture-win.cpp: $(srcdir)/capture-win.h
>>
>>  # Call the Qt resource compiler
>>  qrc_qv4l2.cpp: $(srcdir)/qv4l2.qrc
>> -     rcc -name qv4l2 -o $@ $(srcdir)/qv4l2.qrc
>> +     $(RCC) -name qv4l2 -o $@ $(srcdir)/qv4l2.qrc
>>
>>  install-data-local:
>>       $(INSTALL_DATA) -D -p "$(srcdir)/qv4l2.desktop"   "$(DESTDIR)$(datadir)/applications/qv4l2.desktop"
>>
>
> Where does RCC gets populated? The configure.ac parts seems to be missing.
>

hmm ok. I have been using it in environment. but I will do a v2 with
configure.in detecting it with pkgconfig

> Thanks,
> Gregor
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/utils/qv4l2/Makefile.am b/utils/qv4l2/Makefile.am
index 02d0bcb..86d0285 100644
--- a/utils/qv4l2/Makefile.am
+++ b/utils/qv4l2/Makefile.am
@@ -29,7 +29,7 @@  moc_capture-win.cpp: $(srcdir)/capture-win.h
 
 # Call the Qt resource compiler
 qrc_qv4l2.cpp: $(srcdir)/qv4l2.qrc
-	rcc -name qv4l2 -o $@ $(srcdir)/qv4l2.qrc
+	$(RCC) -name qv4l2 -o $@ $(srcdir)/qv4l2.qrc
 
 install-data-local:
 	$(INSTALL_DATA) -D -p "$(srcdir)/qv4l2.desktop"   "$(DESTDIR)$(datadir)/applications/qv4l2.desktop"