From patchwork Tue Oct 23 19:57:15 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 1632581 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 828283FD4E for ; Tue, 23 Oct 2012 20:03:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933443Ab2JWT7H (ORCPT ); Tue, 23 Oct 2012 15:59:07 -0400 Received: from mail-gg0-f174.google.com ([209.85.161.174]:61542 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933441Ab2JWT7E (ORCPT ); Tue, 23 Oct 2012 15:59:04 -0400 Received: by mail-gg0-f174.google.com with SMTP id k5so820742ggd.19 for ; Tue, 23 Oct 2012 12:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=clzQToe1/m4j5l9EaYVTPDHhhXg2SfKcW+ZsVBHlsbc=; b=Na42EC6Vq18Z6od0iwjuxRcI+N0EzW0Kmj8Kc/FH3/TCKMI5bbZr+hlBhaFGKJ18sV B8D9IOWhd9TvW4UpMVLSRn4ak09UNxWS6H9KCUeQlKEipLESJdPDzOuHYwgNg1dpLgFf b9fhRHL5VI4qdd5q4/Bw9O+w3vgEhCu3rXvfZ0M+IrA3xmH4wacOZqbAnvidDyBJUZxu jc7NjTV+k1y5dDAHJXNNf1HhaRIyU6/BhoCFOM3niHt1aGQqS4I92l5lNosdc+3eybLi tpTFbRbyFl0nzJY3+n/c1CBIQfpQZr4yGJx9ahWWMvRbts3bSf90ejsm9wshVmhjxbwN cOEw== Received: by 10.236.118.229 with SMTP id l65mr3850365yhh.3.1351022343912; Tue, 23 Oct 2012 12:59:03 -0700 (PDT) Received: from localhost.localdomain ([186.153.120.250]) by mx.google.com with ESMTPS id k63sm12813347yhj.20.2012.10.23.12.59.01 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 23 Oct 2012 12:59:03 -0700 (PDT) From: Ezequiel Garcia To: , Cc: Julia.Lawall@lip6.fr, kernel-janitors@vger.kernel.org, Ezequiel Garcia , Peter Senna Tschudin Subject: [PATCH 12/23] tuners/xc4000: Replace memcpy with struct assignment Date: Tue, 23 Oct 2012 16:57:15 -0300 Message-Id: <1351022246-8201-12-git-send-email-elezegarcia@gmail.com> X-Mailer: git-send-email 1.7.4.4 In-Reply-To: <1351022246-8201-1-git-send-email-elezegarcia@gmail.com> References: <1351022246-8201-1-git-send-email-elezegarcia@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/tuners/xc4000.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/tuners/xc4000.c b/drivers/media/tuners/xc4000.c index 4937712..d178dee 100644 --- a/drivers/media/tuners/xc4000.c +++ b/drivers/media/tuners/xc4000.c @@ -1066,7 +1066,7 @@ check_device: goto fail; } - memcpy(&priv->cur_fw, &new_fw, sizeof(priv->cur_fw)); + priv->cur_fw = new_fw; /* * By setting BASE in cur_fw.type only after successfully loading all