From patchwork Tue Oct 23 19:57:16 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 1632601 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 05B3CDF283 for ; Tue, 23 Oct 2012 20:04:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933575Ab2JWUDs (ORCPT ); Tue, 23 Oct 2012 16:03:48 -0400 Received: from mail-gh0-f174.google.com ([209.85.160.174]:62157 "EHLO mail-gh0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933317Ab2JWT7G (ORCPT ); Tue, 23 Oct 2012 15:59:06 -0400 Received: by mail-gh0-f174.google.com with SMTP id g15so834680ghb.19 for ; Tue, 23 Oct 2012 12:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=aP9zygv8qsDQ1l282YbY9dJQzcOiSUSXf1KF/5DWkmg=; b=Z60wNrU4fBG+OYZa4euJ9kR5ncHPpVt+/OkEPqPNUS22J2F/7GVbfRjz7U5ny4W94b dyh686EZR3Cy5HSVaZ4JnC/TdNLU1wmBswhaZ/r/4VQTsCRZV+8Fhxr02TQ2aIAkBsVz qY60mAjZjx1b3KxtnewP2sURuX5/oyrBszmV18BI9Rbj2eNjmh8DZhwAFFIlOO3dSIzC 38Z0sPFiKsl2caA0GqWs9pPJRZwNZgJl9Rgfhr932wKFm4Wd4ulpZIv++AkaeGf16TGc yyFMRqh6cF198HNryuG+3nTOWHt9GyL3WAAf4nlafzEq7HkzN1ENy5esu+7kEfrJYqvX zKLA== Received: by 10.236.85.78 with SMTP id t54mr12668053yhe.48.1351022346457; Tue, 23 Oct 2012 12:59:06 -0700 (PDT) Received: from localhost.localdomain ([186.153.120.250]) by mx.google.com with ESMTPS id k63sm12813347yhj.20.2012.10.23.12.59.04 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 23 Oct 2012 12:59:05 -0700 (PDT) From: Ezequiel Garcia To: , Cc: Julia.Lawall@lip6.fr, kernel-janitors@vger.kernel.org, Ezequiel Garcia , Peter Senna Tschudin Subject: [PATCH 13/23] tuners/xc2028: Replace memcpy with struct assignment Date: Tue, 23 Oct 2012 16:57:16 -0300 Message-Id: <1351022246-8201-13-git-send-email-elezegarcia@gmail.com> X-Mailer: git-send-email 1.7.4.4 In-Reply-To: <1351022246-8201-1-git-send-email-elezegarcia@gmail.com> References: <1351022246-8201-1-git-send-email-elezegarcia@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/tuners/tuner-xc2028.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/tuners/tuner-xc2028.c b/drivers/media/tuners/tuner-xc2028.c index 7bcb6b0..0945173 100644 --- a/drivers/media/tuners/tuner-xc2028.c +++ b/drivers/media/tuners/tuner-xc2028.c @@ -870,7 +870,7 @@ check_device: } read_not_reliable: - memcpy(&priv->cur_fw, &new_fw, sizeof(priv->cur_fw)); + priv->cur_fw = new_fw; /* * By setting BASE in cur_fw.type only after successfully loading all