From patchwork Tue Oct 23 19:57:22 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 1632511 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 9E5563FE1C for ; Tue, 23 Oct 2012 20:01:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933490Ab2JWUB0 (ORCPT ); Tue, 23 Oct 2012 16:01:26 -0400 Received: from mail-gg0-f174.google.com ([209.85.161.174]:61542 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933459Ab2JWT7W (ORCPT ); Tue, 23 Oct 2012 15:59:22 -0400 Received: by mail-gg0-f174.google.com with SMTP id k5so820742ggd.19 for ; Tue, 23 Oct 2012 12:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=bv1+Jkqxc6UwVy7ef3l2yTRABcu9H8TOQKHnWiDchmc=; b=SxtbQkFIv++39E/AYrKsn2fVKWB4rq2FA5YMJjVYRfMpuVVc7JRy4Pg+PCPf2/GhUp UAUYEXHb16cJx+wU0B+JQJl/EA9nuM4LFo5gVNVURa6xgLAWnmU7/q9Bs4PXOaBloWi+ t5/1QNVkUIO2Lq2735n5vEWSuuLKFluO1L9aeEbXg2362An3AGhEDvmwhlyTJxyixImP GXdm0TALIRhHrG1JsD1PW+isGU0uKJbVah4e4gaWFi4np1u6T+TYxriBWZPLFB1KCG5B MslER5cvh6fiND23dKvHtlewlAjG+w+WS4AFy0tBckuURchMq6aMy4tX/OR5ELvqw5Yj 2ygg== Received: by 10.236.190.194 with SMTP id e42mr12674930yhn.28.1351022361721; Tue, 23 Oct 2012 12:59:21 -0700 (PDT) Received: from localhost.localdomain ([186.153.120.250]) by mx.google.com with ESMTPS id k63sm12813347yhj.20.2012.10.23.12.59.19 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 23 Oct 2012 12:59:21 -0700 (PDT) From: Ezequiel Garcia To: , Cc: Julia.Lawall@lip6.fr, kernel-janitors@vger.kernel.org, Ezequiel Garcia , Peter Senna Tschudin Subject: [PATCH 19/23] bttv: Replace memcpy with struct assignment Date: Tue, 23 Oct 2012 16:57:22 -0300 Message-Id: <1351022246-8201-19-git-send-email-elezegarcia@gmail.com> X-Mailer: git-send-email 1.7.4.4 In-Reply-To: <1351022246-8201-1-git-send-email-elezegarcia@gmail.com> References: <1351022246-8201-1-git-send-email-elezegarcia@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/pci/bt8xx/bttv-i2c.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/bt8xx/bttv-i2c.c b/drivers/media/pci/bt8xx/bttv-i2c.c index 580c8e6..7398afa 100644 --- a/drivers/media/pci/bt8xx/bttv-i2c.c +++ b/drivers/media/pci/bt8xx/bttv-i2c.c @@ -366,8 +366,7 @@ int __devinit init_bttv_i2c(struct bttv *btv) strlcpy(btv->c.i2c_adap.name, "bttv", sizeof(btv->c.i2c_adap.name)); - memcpy(&btv->i2c_algo, &bttv_i2c_algo_bit_template, - sizeof(bttv_i2c_algo_bit_template)); + btv->i2c_algo = bttv_i2c_algo_bit_template; btv->i2c_algo.udelay = i2c_udelay; btv->i2c_algo.data = btv; btv->c.i2c_adap.algo_data = &btv->i2c_algo;