From patchwork Tue Oct 23 19:57:23 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 1632481 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 0EED83FE1C for ; Tue, 23 Oct 2012 20:01:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933454Ab2JWUAp (ORCPT ); Tue, 23 Oct 2012 16:00:45 -0400 Received: from mail-yh0-f46.google.com ([209.85.213.46]:49915 "EHLO mail-yh0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933470Ab2JWT7Y (ORCPT ); Tue, 23 Oct 2012 15:59:24 -0400 Received: by mail-yh0-f46.google.com with SMTP id m54so823993yhm.19 for ; Tue, 23 Oct 2012 12:59:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=muvetFKIUKS5NrViRVG3cekQi9gclA0ilwVfesyzzOc=; b=b89Dp1t6UdhgUnSnvCFK5YKBwR3xKpeS/dVAW/+GruaHuY4w3WdrgddxRW2hvT0BhW JpGTAZ3sGUOsEu69ufbziSQ/t1eF8PLV0oXL8tskJ9r0QkVcUL6S5ncJYEk61Zh+JwRv /sOZxMQBWQO5SFT9eiTjBkUxl+LgwtG+1Cnxm6XcT8xCEdZvrzWjDEOjKUel//SLeVJO h1qM5fEfTalxfPXIkc4zLxBIwuJwdnJ2VYB16SVA+9ClJCMB0GnEpVIw1Sj+mD0vuDbD /AY4XVdXnBBiY4ocY2/QWacAcbQ/dV1WNqVu9qh/wJVG6fm6X/dpLb2frtjH8RllqXYx CYNw== Received: by 10.236.150.130 with SMTP id z2mr12618947yhj.115.1351022364026; Tue, 23 Oct 2012 12:59:24 -0700 (PDT) Received: from localhost.localdomain ([186.153.120.250]) by mx.google.com with ESMTPS id k63sm12813347yhj.20.2012.10.23.12.59.21 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 23 Oct 2012 12:59:23 -0700 (PDT) From: Ezequiel Garcia To: , Cc: Julia.Lawall@lip6.fr, kernel-janitors@vger.kernel.org, Ezequiel Garcia , Peter Senna Tschudin Subject: [PATCH 20/23] dvb-core: Replace memcpy with struct assignment Date: Tue, 23 Oct 2012 16:57:23 -0300 Message-Id: <1351022246-8201-20-git-send-email-elezegarcia@gmail.com> X-Mailer: git-send-email 1.7.4.4 In-Reply-To: <1351022246-8201-1-git-send-email-elezegarcia@gmail.com> References: <1351022246-8201-1-git-send-email-elezegarcia@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/dvb-core/dvb_frontend.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c index 7e92793..c770464 100644 --- a/drivers/media/dvb-core/dvb_frontend.c +++ b/drivers/media/dvb-core/dvb_frontend.c @@ -2256,7 +2256,7 @@ static int dvb_frontend_ioctl_legacy(struct file *file, printk("%s switch command: 0x%04lx\n", __func__, swcmd); do_gettimeofday(&nexttime); if (dvb_frontend_debug) - memcpy(&tv[0], &nexttime, sizeof(struct timeval)); + tv[0] = nexttime; /* before sending a command, initialize by sending * a 32ms 18V to the switch */