From patchwork Tue Oct 23 19:57:11 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 1634861 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 446D33FD85 for ; Tue, 23 Oct 2012 21:17:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933386Ab2JWT65 (ORCPT ); Tue, 23 Oct 2012 15:58:57 -0400 Received: from mail-yh0-f46.google.com ([209.85.213.46]:49915 "EHLO mail-yh0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933380Ab2JWT6y (ORCPT ); Tue, 23 Oct 2012 15:58:54 -0400 Received: by mail-yh0-f46.google.com with SMTP id m54so823993yhm.19 for ; Tue, 23 Oct 2012 12:58:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=AwO0+t/jLclNQ0eYvXt0E56W3JK8rEyXT3iAgXeOKoM=; b=rICwFAlrYPAnbKTUJQt2zABhEkhQJpBD+/XXvItiXFFF3ChxFC3gxBhonIELjaOk+b RK5KrgzDF/fJbOZhi6cKywrYUh+0yY2sbHGPbRlAStfumiSFLM2akORh8U/lSgXw0lbz ptTybEZgLgE/KAKhwT6JdbMiRqJw42FymbqresywUNdRPkeGtfj5xNhTiuLWLi4Dlz1U mbf4M+KPpngfwLrEMKcH/mn/rbXbAGhnTXjJdDT4nRHmFq7vvqv+jB8UDV3L+AsQUr93 +xSf7QZ75rR9GhH99wPK13H+w43hRkMmnRg8mI4hx/17Q+fUW6R35sQdYncIDGt8AcNT bZUw== Received: by 10.236.85.78 with SMTP id t54mr12667487yhe.48.1351022333831; Tue, 23 Oct 2012 12:58:53 -0700 (PDT) Received: from localhost.localdomain ([186.153.120.250]) by mx.google.com with ESMTPS id k63sm12813347yhj.20.2012.10.23.12.58.51 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 23 Oct 2012 12:58:53 -0700 (PDT) From: Ezequiel Garcia To: , Cc: Julia.Lawall@lip6.fr, kernel-janitors@vger.kernel.org, Ezequiel Garcia , Peter Senna Tschudin Subject: [PATCH 08/23] cx25840: Replace memcpy with struct assignment Date: Tue, 23 Oct 2012 16:57:11 -0300 Message-Id: <1351022246-8201-8-git-send-email-elezegarcia@gmail.com> X-Mailer: git-send-email 1.7.4.4 In-Reply-To: <1351022246-8201-1-git-send-email-elezegarcia@gmail.com> References: <1351022246-8201-1-git-send-email-elezegarcia@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia Signed-off-by: Andy Walls --- drivers/media/i2c/cx25840/cx25840-ir.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/cx25840/cx25840-ir.c b/drivers/media/i2c/cx25840/cx25840-ir.c index 38ce76e..9ae977b 100644 --- a/drivers/media/i2c/cx25840/cx25840-ir.c +++ b/drivers/media/i2c/cx25840/cx25840-ir.c @@ -1251,13 +1251,11 @@ int cx25840_ir_probe(struct v4l2_subdev *sd) cx25840_write4(ir_state->c, CX25840_IR_IRQEN_REG, 0); mutex_init(&ir_state->rx_params_lock); - memcpy(&default_params, &default_rx_params, - sizeof(struct v4l2_subdev_ir_parameters)); + default_params = default_rx_params; v4l2_subdev_call(sd, ir, rx_s_parameters, &default_params); mutex_init(&ir_state->tx_params_lock); - memcpy(&default_params, &default_tx_params, - sizeof(struct v4l2_subdev_ir_parameters)); + default_params = default_tx_params; v4l2_subdev_call(sd, ir, tx_s_parameters, &default_params); return 0;