From patchwork Tue Oct 23 19:57:12 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 1634881 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id C91AEDF283 for ; Tue, 23 Oct 2012 21:17:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933616Ab2JWVRE (ORCPT ); Tue, 23 Oct 2012 17:17:04 -0400 Received: from mail-ye0-f174.google.com ([209.85.213.174]:40896 "EHLO mail-ye0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933334Ab2JWT64 (ORCPT ); Tue, 23 Oct 2012 15:58:56 -0400 Received: by mail-ye0-f174.google.com with SMTP id m12so525603yen.19 for ; Tue, 23 Oct 2012 12:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=IXQ4epwnIV+jBId2xPPYMOQ0Oq9WUH2i82nfjDsYrlU=; b=rKk2iX8WotPpty42O7Ss91bNi5EFRRiG1wIebJmVUw3wDwIBATfraymZPlbs5WyQKv gGqewuynm8u5ENx9tEEI0z43yEccm6JvKwfxRH9VMY490JY8ilAQl5dAmpiliagbDA47 tZWA4DIFc3f4Xo8zWf/yEOCMtbvrMtoolBcGtnLRJolw906DCRe2L9gyJJRyF0xj0IMr xgFK5RFYEyQZ0Jtp5YQVPdiQSDXqsOjQtOxu5T6kIC/eVanW85DkXV1AV36FDDpzr8rB kRst8FzJ6vQ02DI+5bppTBgkHVHg6770Ap+XXfiW33VH1z3bXmXw+0ukKF2WuOAxoBjU QDjQ== Received: by 10.236.122.148 with SMTP id t20mr12656377yhh.19.1351022336361; Tue, 23 Oct 2012 12:58:56 -0700 (PDT) Received: from localhost.localdomain ([186.153.120.250]) by mx.google.com with ESMTPS id k63sm12813347yhj.20.2012.10.23.12.58.54 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 23 Oct 2012 12:58:55 -0700 (PDT) From: Ezequiel Garcia To: , Cc: Julia.Lawall@lip6.fr, kernel-janitors@vger.kernel.org, Ezequiel Garcia , Peter Senna Tschudin Subject: [PATCH 09/23] zr36067: Replace memcpy with struct assignment Date: Tue, 23 Oct 2012 16:57:12 -0300 Message-Id: <1351022246-8201-9-git-send-email-elezegarcia@gmail.com> X-Mailer: git-send-email 1.7.4.4 In-Reply-To: <1351022246-8201-1-git-send-email-elezegarcia@gmail.com> References: <1351022246-8201-1-git-send-email-elezegarcia@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/pci/zoran/zoran_card.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/zoran/zoran_card.c b/drivers/media/pci/zoran/zoran_card.c index fffc54b..cea325d 100644 --- a/drivers/media/pci/zoran/zoran_card.c +++ b/drivers/media/pci/zoran/zoran_card.c @@ -708,8 +708,7 @@ static const struct i2c_algo_bit_data zoran_i2c_bit_data_template = { static int zoran_register_i2c (struct zoran *zr) { - memcpy(&zr->i2c_algo, &zoran_i2c_bit_data_template, - sizeof(struct i2c_algo_bit_data)); + zr->i2c_algo = zoran_i2c_bit_data_template; zr->i2c_algo.data = zr; strlcpy(zr->i2c_adapter.name, ZR_DEVNAME(zr), sizeof(zr->i2c_adapter.name));