| Message ID | 1351858169-5742-1-git-send-email-yamanetoshi@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Nov 2, 2012 at 1:09 PM, YAMANE Toshiaki <yamanetoshi@gmail.com> wrote: > fixed below checkpatch warnings. > - WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... > - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... > > Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com> Tested-by: Peter Senna Tschudin <peter.senna@gmail.com> > --- > drivers/staging/media/go7007/wis-ov7640.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/go7007/wis-ov7640.c b/drivers/staging/media/go7007/wis-ov7640.c > index eb5efc9..fe46374 100644 > --- a/drivers/staging/media/go7007/wis-ov7640.c > +++ b/drivers/staging/media/go7007/wis-ov7640.c > @@ -59,12 +59,12 @@ static int wis_ov7640_probe(struct i2c_client *client, > > client->flags = I2C_CLIENT_SCCB; > > - printk(KERN_DEBUG > + dev_dbg(&client->dev, > "wis-ov7640: initializing OV7640 at address %d on %s\n", > client->addr, adapter->name); > > if (write_regs(client, initial_registers) < 0) { > - printk(KERN_ERR "wis-ov7640: error initializing OV7640\n"); > + dev_err(&client->dev, "wis-ov7640: error initializing OV7640\n"); > return -ENODEV; > } > > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Peter -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/media/go7007/wis-ov7640.c b/drivers/staging/media/go7007/wis-ov7640.c index eb5efc9..fe46374 100644 --- a/drivers/staging/media/go7007/wis-ov7640.c +++ b/drivers/staging/media/go7007/wis-ov7640.c @@ -59,12 +59,12 @@ static int wis_ov7640_probe(struct i2c_client *client, client->flags = I2C_CLIENT_SCCB; - printk(KERN_DEBUG + dev_dbg(&client->dev, "wis-ov7640: initializing OV7640 at address %d on %s\n", client->addr, adapter->name); if (write_regs(client, initial_registers) < 0) { - printk(KERN_ERR "wis-ov7640: error initializing OV7640\n"); + dev_err(&client->dev, "wis-ov7640: error initializing OV7640\n"); return -ENODEV; }
fixed below checkpatch warnings. - WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com> --- drivers/staging/media/go7007/wis-ov7640.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)