diff mbox

staging/media: Use dev_ printks in go7007/s2250-loader.c

Message ID 1352128271.16194.8.camel@joe-AO722 (mailing list archive)
State New, archived
Headers show

Commit Message

Joe Perches Nov. 5, 2012, 3:11 p.m. UTC
On Mon, 2012-11-05 at 14:11 +0100, Greg Kroah-Hartman wrote:
> On Mon, Nov 05, 2012 at 08:34:42PM +0900, YAMANE Toshiaki wrote:
> > fixed below checkpatch warnings.
> > - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
> > - WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
> > 
> > Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
> > ---
> >  drivers/staging/media/go7007/s2250-loader.c |   35 ++++++++++++++-------------
> >  1 file changed, 18 insertions(+), 17 deletions(-)
> 
> Please note that I don't touch the drivers/staging/media/* files, so
> copying me on these patches doesn't do anything :)

Maybe:

 MAINTAINERS |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)



--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Greg KH Nov. 5, 2012, 3:22 p.m. UTC | #1
On Mon, Nov 05, 2012 at 07:11:11AM -0800, Joe Perches wrote:
> On Mon, 2012-11-05 at 14:11 +0100, Greg Kroah-Hartman wrote:
> > On Mon, Nov 05, 2012 at 08:34:42PM +0900, YAMANE Toshiaki wrote:
> > > fixed below checkpatch warnings.
> > > - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
> > > - WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
> > > 
> > > Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
> > > ---
> > >  drivers/staging/media/go7007/s2250-loader.c |   35 ++++++++++++++-------------
> > >  1 file changed, 18 insertions(+), 17 deletions(-)
> > 
> > Please note that I don't touch the drivers/staging/media/* files, so
> > copying me on these patches doesn't do anything :)
> 
> Maybe:
> 
>  MAINTAINERS |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b062349..542a541 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6906,6 +6906,7 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
>  L:	devel@driverdev.osuosl.org
>  S:	Supported
>  F:	drivers/staging/
> +X:	drivers/staging/media/

Sure, that would be good, care to resend it with a signed-off-by: so I
can apply it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Joe Perches Nov. 5, 2012, 3:25 p.m. UTC | #2
On Mon, 2012-11-05 at 16:22 +0100, Greg Kroah-Hartman wrote:
> On Mon, Nov 05, 2012 at 07:11:11AM -0800, Joe Perches wrote:
> > On Mon, 2012-11-05 at 14:11 +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Nov 05, 2012 at 08:34:42PM +0900, YAMANE Toshiaki wrote:
> > > > fixed below checkpatch warnings.
> > > > - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
> > > > - WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
> > > > 
> > > > Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
> > > > ---
> > > >  drivers/staging/media/go7007/s2250-loader.c |   35 ++++++++++++++-------------
> > > >  1 file changed, 18 insertions(+), 17 deletions(-)
> > > 
> > > Please note that I don't touch the drivers/staging/media/* files, so
> > > copying me on these patches doesn't do anything :)
> > 
> > Maybe:
> > 
> >  MAINTAINERS |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index b062349..542a541 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -6906,6 +6906,7 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> >  L:	devel@driverdev.osuosl.org
> >  S:	Supported
> >  F:	drivers/staging/
> > +X:	drivers/staging/media/
> 
> Sure, that would be good, care to resend it with a signed-off-by: so I
> can apply it?

It was just a nudge.

You're the nominal staging maintainer, if you choose not to
work on a specific directory under staging, I think you can
mark it in MAINTAINERS just as easily yourself.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Toshiaki Yamane Nov. 6, 2012, 12:14 a.m. UTC | #3
On Tue, Nov 6, 2012 at 12:25 AM, Joe Perches <joe@perches.com> wrote:
> On Mon, 2012-11-05 at 16:22 +0100, Greg Kroah-Hartman wrote:
>> On Mon, Nov 05, 2012 at 07:11:11AM -0800, Joe Perches wrote:
>> > On Mon, 2012-11-05 at 14:11 +0100, Greg Kroah-Hartman wrote:
>> > > On Mon, Nov 05, 2012 at 08:34:42PM +0900, YAMANE Toshiaki wrote:
>> > > > fixed below checkpatch warnings.
>> > > > - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
>> > > > - WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
>> > > >
>> > > > Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
>> > > > ---
>> > > >  drivers/staging/media/go7007/s2250-loader.c |   35 ++++++++++++++-------------
>> > > >  1 file changed, 18 insertions(+), 17 deletions(-)
>> > >
>> > > Please note that I don't touch the drivers/staging/media/* files, so
>> > > copying me on these patches doesn't do anything :)
>> >
>> > Maybe:
>> >
>> >  MAINTAINERS |    1 +
>> >  1 files changed, 1 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > index b062349..542a541 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -6906,6 +6906,7 @@ T:    git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
>> >  L: devel@driverdev.osuosl.org
>> >  S: Supported
>> >  F: drivers/staging/
>> > +X: drivers/staging/media/
>>
>> Sure, that would be good, care to resend it with a signed-off-by: so I
>> can apply it?
>
> It was just a nudge.
>
> You're the nominal staging maintainer, if you choose not to
> work on a specific directory under staging, I think you can
> mark it in MAINTAINERS just as easily yourself.

Thanks for all.

I wait Mauro-san will pick the patches.
And I will send the patches to the correct destination from the next time.
Mauro Carvalho Chehab Dec. 21, 2012, 8:40 p.m. UTC | #4
Em Tue, 6 Nov 2012 09:14:39 +0900
Toshiaki Yamane <yamanetoshi@gmail.com> escreveu:

> On Tue, Nov 6, 2012 at 12:25 AM, Joe Perches <joe@perches.com> wrote:
> > On Mon, 2012-11-05 at 16:22 +0100, Greg Kroah-Hartman wrote:
> >> On Mon, Nov 05, 2012 at 07:11:11AM -0800, Joe Perches wrote:
> >> > On Mon, 2012-11-05 at 14:11 +0100, Greg Kroah-Hartman wrote:
> >> > > On Mon, Nov 05, 2012 at 08:34:42PM +0900, YAMANE Toshiaki wrote:
> >> > > > fixed below checkpatch warnings.
> >> > > > - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
> >> > > > - WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
> >> > > >
> >> > > > Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
> >> > > > ---
> >> > > >  drivers/staging/media/go7007/s2250-loader.c |   35 ++++++++++++++-------------
> >> > > >  1 file changed, 18 insertions(+), 17 deletions(-)
> >> > >
> >> > > Please note that I don't touch the drivers/staging/media/* files, so
> >> > > copying me on these patches doesn't do anything :)
> >> >
> >> > Maybe:
> >> >
> >> >  MAINTAINERS |    1 +
> >> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >> >
> >> > diff --git a/MAINTAINERS b/MAINTAINERS
> >> > index b062349..542a541 100644
> >> > --- a/MAINTAINERS
> >> > +++ b/MAINTAINERS
> >> > @@ -6906,6 +6906,7 @@ T:    git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> >> >  L: devel@driverdev.osuosl.org
> >> >  S: Supported
> >> >  F: drivers/staging/
> >> > +X: drivers/staging/media/
> >>
> >> Sure, that would be good, care to resend it with a signed-off-by: so I
> >> can apply it?
> >
> > It was just a nudge.
> >
> > You're the nominal staging maintainer, if you choose not to
> > work on a specific directory under staging, I think you can
> > mark it in MAINTAINERS just as easily yourself.
> 
> Thanks for all.
> 
> I wait Mauro-san will pick the patches.
> And I will send the patches to the correct destination from the next time.

I'm handling them today. Sorry for being a little late on it. Too much
stuff at the end of this year to handle.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index b062349..542a541 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6906,6 +6906,7 @@  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
 L:	devel@driverdev.osuosl.org
 S:	Supported
 F:	drivers/staging/
+X:	drivers/staging/media/
 
 STAGING - AGERE HERMES II and II.5 WIRELESS DRIVERS
 M:	Henk de Groot <pe1dnn@amsat.org>